patch review guidelines

[kareila]

My initial revision of Dev Reviewing Guidelines is up on the wiki. Check it over and see if it looks good.

Please consider being a code reviewer! It's way easier to test code than it is to write it, but for some reason we always seem to have a backlog of unreviewed patches sitting around. If patches go through peer review, that reduces the workload of the handful of developers with commit access.

Comments

Re: Reviewing patches

[afuna]

For those, you can leave a comment without setting a flag. Something along the lines, "I took a look at this, the style is clean", or "X could be a concern", etc.

Just make sure to note explicitly which aspects you've looked at, and any comments you leave will help ease the load!

(PS. \o/)