Entry tags:
patch review guidelines
My initial revision of Dev Reviewing Guidelines is up on the wiki. Check it over and see if it looks good.
Please consider being a code reviewer! It's way easier to test code than it is to write it, but for some reason we always seem to have a backlog of unreviewed patches sitting around. If patches go through peer review, that reduces the workload of the handful of developers with commit access.
Please consider being a code reviewer! It's way easier to test code than it is to write it, but for some reason we always seem to have a backlog of unreviewed patches sitting around. If patches go through peer review, that reduces the workload of the handful of developers with commit access.
Re: Reviewing patches
(If you don't have a development environment, you know you can get one really easily, right?)
There have been some patches with very good looking code that I have left alone just because I didn't know enough about the part of the site they were changing to test them with confidence.