Code Tour - 12th March to 1st May

[katieastrophe]

Whew, my first code tour! This broke my mind a bit in places, and I think I mostly failed at the "being funny" part, but I hope it helps you understand what Dreamwidth has been up to!

Bug 4380: Paletteable: new themes
Category: Style System
Patch by: momijizukamori
Description: This gives us three new colour themes for the new Palettable journal style, designed by the very talented nornoriel.

Bug 4409: /admin/capedit does not populate with caps
Category: Site Administration
Patch by: foxfirefey
Description: This is a bugfix for an administration page that none of us lowly users will ever see; essentially, code was not tested, it didn't work, and now it does. Yay for code that works!

Bug 4378: Practicality: new themes
Category: Style System
Patch by: momijizukamori
Description: More new colour themes! :D

Bug 3850: Remove Google Maps link from "current location" metadata
Category: Journal contents
Suggested by: mayfly
Patch by: kaisa
Description: This one is really, really awesome folks! For the longest time (like, since LiveJournal released the feature in the first place) I've been really annoyed by how the location in entry metadata is auto-populated with a link to Google Maps, and this fix gets rid of that auto-linking, and increases the character limit of the field, so that if you want to stick a URL in there, whether it be Google or OpenStreetMap or the website of the cafe you're in, or whatever, then you can - squee!

Bug 4405: Fix variable interpolation errors in memcache keys
Category: Misc Backend
Patch by: exor674
Description: Previously, the way Dreamwidth used the data given to it by memcache when dealing with polls on the site sometimes worked, and sometimes didn't, and generally got very confused. For the end users (that's us!) this meant an occasional short and unnecessary delay whilst the server went to find information because it thought something had changed when it hadn't, or worse, the site sometimes displayed completely the wrong thing. exor674's patch fixes that, so that the data is used differently and confuses everybody and their server less!

Bug 2646: replying to comment from email, subject line entry box does not respect character limit
Category: Misc UI/Frontend
Patch by: kaisa
Description: So, you get a comment notification email, and you reply to the comment using the form. You might type a subject line of 101 characters, and the final character would be chopped off. Also, if there's an apostrophe in there, that loses you a few more characters - and you have no idea, because the email form just lets you keep on typing, unlike the website, which stops you typing when you run out of space. Not anymore! The emails you get from the next code push will behave in the same way as the website from now on, so you shouldn't lose too many characters anymore.

Bug 4410: uninitialized warnings when viewing journal archive
Category: Misc Backend
Patch by: kareila
Description: When the archive page for a journal that has no entries was loaded (as an example) - Dreamwidth's logs would fill up with unnecessary errors. This patch tidies that up so that nobody has to read about people trying to find things that don't exist :)

Bug 2154: Allow community posting guidelines to be in the profile
Category: Communities
Suggested by: cesy
Patch by: purplecat
Description: we heart the new function that lets community admin give a link to an entry that details rules/guidelines - but what if you want to put those rules in the profile of the community instead? Now you can!

Bug 4407: Let the controller privcheck take subroutines
Category: Routing/TT
Patch by: foxfirefey
Description: this is another one of those behind the scenes things that we'll never notice but it's good to have. Basically, the site has to check when we try to view some pages to make sure we're allowed to - like admin pages and so on. This fix allows the site to do a more complex check on pages that require it.

Bug 4381: Modular: new themes
Category: Style System
Patch by: momijizukamori
Description: nornoriel strikes again! More new colour themes for our journals.

Bug 4376: Marginless: new themes
Category: Style System
Patch by: momijizukamori
Description: More new themes! nornoriel is a creative whizz.

Bug 4130: New Style: For The Bold by timeasmymeasure
Category: Style System
Patch by: ninetydegrees
Description: A new style, designed by timeasmymeasure.

Bug 3866: add the poster information to community rss feeds
Category: Feeds
Suggested by: ratcreature
Patch by: kaisa
Description: simple but awesome: if you read Dreamwidth communities through an RSS reader, you'll soon start to see a line in the feed that says "Posted by: <user name="foo">" so you know who posted in the community as well as what they said.

Bug 4415: Poll: same-page poll voting no longer works in beta-testing
Category: Journal contents
Patch by: fu
Description: A simple patch so that the nifty same-page poll results thing that Dreamwidth does works for people who have navstrip turned off.

Bug 3719: Style custom /icons pages
Category: Style System
Patch by: ninetydegrees
Description: There's a whole pile of patches here! They allow us to have our icon page styled in the same way our journals are.

Bug 1782: Handle deeply nested comment threads in various layouts
Category: Style System
Patch by: batrachian
Description: This one makes Dreamwidth better handle very deeply nested comments, so that we don't end up with one character per line towards the end of a conversation.

Bug 4418: Abstractia: add .inner class to .header
Category: Style System
Patch by: ninetydegrees
Description: This adds a bit of CSS to the Abstractia layout for more flexibility with customising our journals.

Bug 4084: Tools to manage %LJ::SECRETS
Category: Misc Backend
Patch by: exor674
Description: This fix allows us to better digitally "sign" things with secret keys, saying that Dreamwidth generated them, and not me, or you, or any other user of the site.

Bug 4374: Abstractia: new themes
Category: Style System
Patch by: momijizukamori
Description: Moar new themes yay! nornoriel made these ones too.

Bug 4072: New Style: Database by ninetydegrees
Category: Style System
Patch by: ninetydegrees
Description: Another brand new style!

Bug 4419: put authas box in the same spot on all pages
Category: Site Layout/Navigation
Patch by: ninetydegrees
Description: This patch ensures that the box on pages that allows you to switch between your account and communities that you admin is always in the same place - by default, on the left, because English readers read left-to-right.

Bug 2995: New Style: Hibiscus by branchandroot
Category: Style System
Patch by: momijizukamori
Description: Another brand new style!

Bug 4424: Add ml to plugin too
Category: Routing/TT
Patch by: exor674
Description: The previous way of requesting a translation string didn't work so well, so this patch comes up with a new way to do it that works better.

Bug 4420: Transmo: fix header margin when icon's on the right in comments
Category: Style System
Patch by: ninetydegrees
Description: A quick fix for Transmogrified, that gets rid of some negative space on the left side when the user sets their icons to be on the right.

Bug 4421: Color::set_hsl dies, Color:: hsl setters corrupt the color
Category: S2 Backend
Patch by: exor674
Description: Previously, the code in styles didn't check if requested colours had any other data than hue, saturation and lightness, and it was displaying something other than what was requested. This patch will fix that!

Bug 4367: add a link to "claim your openid" to the settings page
Category: Misc UI/Frontend
Patch by: randomling
Description: There's soon to be a link to claim an OpenID in the settings page, making it easier to find.

Bug 3669: New Style: Wide Open by mmmag
Category: Style System
Patch by: ninetydegrees
Description: New style again!

Bug 4306: paid-time.t still has problems with February
Category: Payments
Patch by: kareila
Description: we had a test that, when run in February, failed, because February is a CONFUSING month with not enough days. This patch fixes that!


Aaand that's it for now.

Comments

[brainwane]

I liked this code tour. Straightforward and helpful and explanatory. Thanks!

[azurelunatic]

Yay code tour!

[msilverstar]

Bug 3850: Remove Google Maps link from "current location" metadata

YAY! I'm avoiding Google when possible so I really appreciate this!

[fu]

Very clean and instructive. Thank you!

[liv]

Squeeee! I am so excited about getting rid of that dreadful Google maps link, I've been annoyed at having to work round it for years. And now that Google has gone to the dark side it's become even more annoying.

Also so many new styles and themes. Awe. Some!

[momijizukamori]

I'm not sure if I should be proud or ashamed of how many times my name is on this list *g*

(Worse: I have another, uh, three or four patches in the review queue?)

[katieastrophe]

I think you should go with proud! :D

[batrachian]

Seconded. Many patches is <3

[sophie]

Proud. Definitely proud. :D

[poulpette]

Definitely should be proud of yourself :)

[musyc]

Yay code tour! I love code tours. Even when I understand absolutely nothing except THERE ARE SHINY THINGS, I love seeing that things are happening, what is happening, and an explanation as to why. The transparency is so wonderful.

[katieastrophe]

I'm glad I'm not the only one who had no idea what half the patches were about ;)

[marahmarie]

For bugs 4415, 3850, and 1782: thank you, DW. Especially for 4415, which I thought was something on my end (with my s2, maybe) - had no idea it was beta-bug related. And anything like 1782 (improving comment nesting, which is the one of the few CSS/s2 issues that has consistently driven me insane, going back to 2005 or so on LJ) is equally awesome.