dw_dev | Code tour: January 05-26, 2012

Thirty four bugs, new and old, big and small. Something for everyone!

Bug 4074: "You've been invited to $community" email subject not stripped
Category: English-Stripping
Patch by:

ninetydegrees
Description: English stripping means basically what it says - the text on the page shouldn't be hardcoded as one language (aka English). Instead, it's replaced with, and I quote, "an ID you can use to refer to the string" so that multiple languages can be supported more easily.

Bug 4078: Username reminder email in htdocs/lostinfo.bml not stripped
Category: English-Stripping
Patch by:

ninetydegrees
Description: More stripping! (Oh, man).

Bug 4137: http://username.dreamwidth.org/security page has no title
Category: Journal contents
Patch by:

ninetydegrees
Description: Pages, when displayed in your browser, should show some sort of title (like the one you see on your tabs). The page for filtering your journal by security levels seemed to be title-less; that's now fixed!

Bug 4143: Misc. Styles & Themes: remove extra specificity from CSS
Category: Style System
Patch by:

ninetydegrees
Description: Kind of like a yearly housecleaning - only except for removing dust bunnies which have magically appeared under erstwhile clean-looking furniture, there's tweaking of stylesheets to make them leaner and un-superfluous. This is the version of Extreme Spring Cleaning, too: look at all those changes!

Bug 3859: Option to make archive and calendar week start on a Monday
Category: S2 Backend
Suggested by:

turlough
Patch by:

fu
Description: Not everyone's week starts on Sunday, so calendars should reflect that. With this patch, you can now choose whether to start your week on Sunday or Monday!

Bug 4186: remove /support/known_issues page
Category: Site Layout/Navigation
Patch by:

kareila
Description: There used to be a page with the URL /support/known_issues, which also used to give information on, well, known issues, but unfortunately it wasn't actually hooked up to any known issues "feed" at all due to changes. (You now get your daily dose of known bugs from a different place - the BBB. Not to be confused with the BBC). For streamlining, the old page has been removed.

Bug 4189: Add MogileFS::Client to checkconfig.pl
Category: Site Administration
Patch by:

sophie
Description: This is explained extremely well by

sophie, the patch-maker:

MogileFS::Client is a required module for the Dreamwidth code to function, but
the decision was made to stop distributing the perlbal and mogilefs
repositories with the Dreamwidth codebase (
http://hg.dwscoalition.org/dw-free/rev/39317850a5a5 ). Thus, we need to add the
module to checkconfig.pl, and this patch does so!

Bug 4191: Install fails because of incomplete replacement of "ENGINE" for "TYPE"
Category: Site Administration
Patch by:

sophie
Description: Things are breaking because of a switch in names (as the bug says, ENGINE -> TYPE), so this just fixes it.

Bug 4181: FAQ #193 no longer relevant?
Category: User documentation
Patch by:

denise
Description: FAQ 193 told you how to leave a deleted community using the only way - the admin console. Now that you can do it from the more easily accessed Manage Community page, this FAQ isn't needed anymore; it no longer shows up in the FAQ list, though you can peek at it by constructing the link!

Bug 4139: Manage Circle/Custom colors: tell users they also have to enable them at Customize
Category: Circle/Relationships
Patch by:

ninetydegrees
Description: Though your reading page can display customized colours for the people you're subscribed to, you have to first enable it from another page. This patch adds a short reminder to do so.

Bug 4161: Purged journals still shown as options when trying to recover lost usernames
Category: Misc UI/Frontend
Patch by:

yvi
Description: Since purged usernames' contents have been removed completely, it's confusing when people request lost usernames - you couldn't recover the account even if you had the password. This patch makes sure that purged usernames don't show up when you request a list of your usernames.

Bug 4154: Manage Icons: make keyword sorting case-insensitive, as on the Icons page
Category: Misc UI/Frontend
Patch by:

yvi
Description: Icons were being sorted oddly: first upper-case keywords (alphabetically), then lower-case keywords (also alphabetically). You'd have "Zebra, apple, and snow", for instance. Icons are now sorted without regard for the upper-or-lower caseness of keywords.

Bug 2352: AJAX expand/collapse of cut entries
Category: Journal contents
Suggested by:

foxfirefey
Patch by:

allen
Description: In 2010 Dreamwidth added the ability to expand cut tags without reloading the page...except the bug never got closed. Here's the official bug-closing! (Whew!)

Bug 4216: renaming to a purged account gives errors
Category: Misc Backend
Patch by:

fu
Description: Trying to rename to a purged account was throwing errors because information was being requested which had been purged - now fixed, and some additional cleaning done on the side, too.

Bug 4202: console-suspend.t fails on dreamhack
Category: Misc Backend
Patch by:

kareila
Description: More fixing of error-throwing! In this case, an admin console command was trying to perform a search update. If the search wasn't configured, though, it would fall over and throw errors.

Bug 3846: add keyword to bugzilla url constructed by suggestions generator
Category: Site Administration
Patch by:

yvi
Description: Many of the bugs filed are from the

dw_suggestions community. To keep them straight, and to remember which are which, this patch automatically adds "from suggestions" as a keyword to the create-bug URL.

Bug 3644: new inbox filter: community membership requests
Category: Inbox/Notifications
Patch by:

ninetydegrees
Description: Your inbox can now filter by community membership requests, if you have a moderated-membership community that's sending you requests! (As an administrator who had 150 people join in a month, this is pretty awesome \o/)

Bug 4162: Icons page: Add Manage Icons link
Category: Style System
Patch by:

ninetydegrees
Description: In the upcoming new customize-your-icons-page improvement, we're sadly missing a link (to, er, manage your icons) - fixed now!

Bug 4207: update DW custom 404s
Category: Frontend
Patch by:

denise
Description: If you've ever hit a 404 on Dreamwidth, it usually spits you a quip of some kind...now we have more variety. More amusement as you wait for the page to load properly!

Bug 4204: suppress reset notifications from running console-reset.t
Category: Misc Backend
Patch by:

kareila
Description: Emails are being sent out for no good reason (I suspect the pixies living in the software) - this keeps them - that is, the emails - from getting out. Suppresses, like the bug title says.

Bug 3658: QuickReply shifted to the right in ColorSide (jquery beta)
Category: Journal contents
Patch by:

fu
Description: Things are jumping around on pages.

sophie found out the core reason why and opened a bug that deals with the root problem; this bug is closed for more housekeeping. (Housekeeping appears to be a theme here.)

Bug 4061: Crisped: 3 themes by flatlanders
Category: Style System
Patch by:

delladea
Description: Three new ways to decorate your journal, brought to you by first-time patch-maker

delladea! *throws confetti*

Bug 4175: Expose ext_### username on OpenID spamreports to make suspension easier
Category: Misc UI/Frontend
Patch by:

denise
Description: To help our spam-whacking team, the extension number of the OpenID accounts should be plainly visible. This goes in the category of giving weapons to the antispam team, so they can whack more easily.

Bug 4200: update shop for 2012
Category: Payments
Patch by:

denise
Description: It is now 2012, so the shop shouldn't accept credit cards expired in 2011...this bug also had the side effect of generating a patch automating the process of above. Funny how that seems to happen :D

Bug 4284: FAQ 225 (Posting images) needs to be in an FAQ category
Category: User documentation
Patch by:

denise
Description: An FAQ on the loose! Or rather, it's not classified in a category which means the FAQ doesn't show up in the list and that means support volunteers can't easily reference it and that makes many people sad. Now fixed!

Bug 4271: Make logging out a one-step process
Category: Misc UI/Frontend
Suggested by:

ninetydegrees
Patch by:

fu
Description: From the Navigation Strip you could log out in one click. From other places, it requires two - this patch standardizes it to one click only.

Bug 4133: No userpic image should have consistent language and say "icons"
Category: Misc UI/Frontend
Patch by:

ninetydegrees
Description: Shifting terminology from 'userpic' to 'icon' means that the picture prompting you to upload an icon has been changed. The little graphic now says "Upload icon".

Bug 4233: Add max card lifetime configuration data for automatic generation of expiry years menu
Category: Payments
Patch by:

kareila
Description: This is the automation I was babbling about a few bugs ago - removing the need to manually update the accepted credit-card expiry-dates.

Bug 3309: mimic polls on entry preview
Category: Journal contents
Patch by:

fu
Description: This lets you see a mock-up of a poll on Entry Preview. You could do this before with the poll creator, but now you can see it in the entry preview, too, where people are more likely to go and check.

Bug 2867: Reloading a page with a returnto= URL should go to the return URL if already logged in
Category: Misc UI/Frontend
Suggested by:

rb
Patch by:

fu
Description: If you reload a page that requires you to log in (having logged in from a different tab), the page used to ask you to log in again, instead of reloading the page as though you were logged in. #dreamwidth says that suddenly it was magically fixed - apparently this problem was fixed at some point by another fix (somewhere...), so this bug doesn't need to be here anymore.

Bug 1847: Highlight in subjects as well as content when searching
Category: Search
Suggested by:

cesy
Patch by:

emclaughlin
Description: If you've ever used search, you know that the search term is highlighted in the body of the text. This patch also highlights things when you find them in the entry title, so you know where the search engine pulled your result from!

Bug 4177: Make choosing random icon a button
Category: Misc UI/Frontend
Suggested by:

silverflight8
Patch by:

fu
Description: Button-ifies the "Choose random icon" option when commenting.

Bug 4203: undefined string warning in LJ/Widget/Login.pm
Category: Misc Backend
Patch by:

kareila
Description: Shushes the random error messages that get thrown.

Bug 4291: Files need_res'd for multiple groups only show up in the first group
Category: Misc Backend
Patch by:

fu
Description: JavaScript files not being loaded in all cases - not good! This patch will fix the problem.

And that's it for this round! Hope you enjoyed the ride, and stay tuned for the next code tour!

Flat | Top-Level Comments Only

I am so glad about 4271. And hooray for

delladea's first patch!

(You have a typo for

dw_suggestions.)

Wait, where is the typo? *on the hunt*

OH I found it. Oops! Thanks for pointing it out.

4175 had me basically turning cartwheels in #dreamwidth, because it makes things easier for me, and I also get a bizarre little kick out of the sort of bug that changes admin-area stuff that only a few people will use. In this case I may actually be the only one who ever uses 4175, because I tend to be the one suspending the spammer OpenIDs.

I think the thrill may be because it's a signal that I'm important and taken-care-of as an assistant. Why yes, I can perform my job function without this little touch, it just annoys me every time. However, the well-being of volunteers is important enough to the site as a whole that it is worth spending developer time on a little fix that will make things a little easier.