dw_dev | Code Tour (with champers!), December 23-28, 2011

Darlings! Happy Friday, the last of the year! It's time for another code tour!

Of course, if you're in Samoa, where there is no Friday (Samoa has no Friday. Samoa needs no Friday), I suggest just popping open another bottle of bubbly and dealing with it. (On the plus side, Samoans, that's 1/52nd less of an opportunity than the rest of the world to hear Rebecca Black. Silver linings, darlings, silver linings.)

We have a wonderful 46 presents under the nondenominational Code Tour seasonal shrub today. (Ours is pohutukawa, on account of me being in New Zealand. Yes, we get New Year's first, on account of being the most awesome country ever. True facts.)

That may sound like a lot of presents! I mean fixed bugs. But many of them are related to journal styles or FAQs, so don't think that we're going all Dudley Dursley on you.

So sit back, relax, pop open a bottle of bubbly (or two! 46 bugs, remember?) and join me on this three hour (code) tour.

WARNING: Code tour may contain the occasional naughty word, naughty innuendo, and dangerous amounts of wine related puns. Do not read code tour while drinking hot beverage. Or cold beverage. Except for perfectly chilled champers.

Bug 4135: quick sanitychecks for suggestions generator
Category: Site Administration
Patch by:

denise
Description: this charming little bug (which means it's not a weta. Yes, we have those.) checks whether an account trying to use the suggestions generator is validated or suspended. That means less spam. Hurrah for less spam! Doesn't go with champers.

Bug 4128: Add header background images to Sunday Morning
Category: Style System
Patch by:

foxfirefey
Description: I tell you, darlings, one occasionally has Saturday nights where the background images on Sunday morning are deeply unpleasant. But now Sunday Morning (see? Capital letters are important!) has header background images. If you happened to have customised your Sunday Morning (as opposed to your Sunday morning), there has been some shifting around of color_header_background and color_page_title_background. Click through to the bug if you're affected. And perhaps pop open another bottle. Champagne is officially a breakfast beverage.

Bug 4064: Some spam report views display header line as HTML <title> instead of body <h1>
Category: Misc UI/Frontend
Patch by:

fu
Description: Backend change! (And who doesn't like a bit of backend change, if you know what I mean?) Minor change to how the backend spam reporting display works.

Bug 1044: add warning when buying paid time for a deleted account
Category: Payments
Patch by:

fu
Description: Darlings, I am terribly sorry, but if you're trying to buy paid time for a deleted/purged/expunged/EXTERMINATED account, you probably need to find something better to spend your money on. May I recommend some of Old Mrs Clickwot's rather tasty fizzy wine? The Vintage Brut 2002 is currently my favourite. What's that? You do want to buy paid time for an EXTERMINATED account? Whatever,

dalekthay. You'll now get a specific "are you sure?!" to check. Perhaps we should use stairs instead.

Bug 4134: suggestions generator needs to check for valid post before posting admin entry
Category: Site Administration
Patch by:

fu
Description: Oh for the love of...who spams a suggestions generator? (Don't answer that, darlings. It'll give you an excess of choler and you might require some smelling salts. Or possibly some bubbles.) This is the latest instalment of the thrilling tales of our intrepid heroines

denise and

fu as they battle the forces of the dread lord spamfiend and its millions of botty, botty cronies.

Bug 4138: Site Skin description: incorrect info for Tropo skins
Category: Site Layout/Navigation
Patch by:

fu
Description: Seventy-five percent is not twenty-five percent, as any #occupier would know. (The bug is a minor descriptive error. Nothing to see here.) I feel bad about all the champagne now. Could I have a top-up of my glass of social justice please?

Bug 4129: Customize Wizard: font field not big enough
Category: S2 Backend
Patch by:

ninetydegrees
Description: Customizing a style and running out of space to specify font names? ("Haettenschweiler" is terribly long, isn't it?) Now you can roll around naked in fifty whole characters of room! Alas, "Louis Roederer Blanc de Blancs" is not a font. :(

Bug 3816: indicate which support categories are private cats
Category: Site Administration
Patch by:

fu
Description: PRIVATE CAT IS PRIIIIIIIIIVATE. And now you know. (Because there's now a star next to the name of private categories on the support board.) And knowing is half the battle. (Champagne is the other half.)

Bug 3087: Need method to get keyword from kwid
Category: Misc Backend
Patch by: Princess Sparkle The Magic Bug-Fixing Fairy
Description: You know how, sometimes, a case of really good champagne sometimes arrives on your doorstep and you have no idea who sent it? No? Well, this is exactly like that. Except with a bug. This one got fixed by proxy because of another bug that

kareila fixed, and it's now more efficient to look things up in the database.

Bug 3986: Outdated text for 'Don't show on Reading Pages' error message
Category: Journal contents
Patch by:

fu
Description: Darlings, you know the wonderful, fabulous, amazing new Update Page? Well, this is a minor tweak so the error message you get if you messed up the backdating reflects the new wording, "Don't show on Reading Pages", rather than "Date Out of Order". Only Samoa is allowed dates out of order this year.

Bug 4132: profile linking module needs to lose the lj:user
Category: Misc UI/Frontend
Patch by:

fu
Description: I'm trying to figure out what the Latin for "who loses the lj:users" is. Quis perdit ipsos pj:erdere? Answers in a comment below. Anyway, darlings, LJ changed the way that profile linking works, so this is a fix for that so everything is hunky-dory. Both hunky and dory. Especially hunky. More champagne?

Bug 4140: Adding a user to your circle is confusing with access and subscribe filters both visible on the page at once
Category: Circle/Relationships
Patch by:

fu
Description: This lovely little fix makes adding a user to your circle a bit more intuitive. I tell you what else is intuitive: champagne.

Bug 4146: Reference to community importing issues should be removed
Category: User documentation
Patch by:

denise
Description: Alas, poor Yorick! I knew him, Horatio; a fellow of infinite jest, of most excellent fancy; he hath borne me on his back a thousand times; and now, how abhorred in my imagination it is! My gorge rises at it. Here hung those lips that I have kissed I know not how oft. Now that we have community imports (thanks to

marky baby, who put community imports under the tree) the FAQs needed updating, and this FAQ is dead. Hence the Hamlet quote.

Bug 4150: FAQ #129: Back link links to current FAQ instead of previous FAQ
Category: User documentation
Patch by:

denise
Description: Nants ingonyama bagithi Baba! It's the ciiiiiiircle of FAQ! And we read them all...except when somebody makes the "back" URL link to the current FAQ. And by somebody, I mean somebody whose name rhymes with, um, "Bernice Chattahoochee". I like that the final comment on this bug is "*facepalm*".

Bug 2391: allow maintainers to import communities from other sites
Category: Importer
Suggested by:

beet
Patch by:

mark
Description: What's that? We can import communities now? Darlings, I had no idea. How exciting! (If you hadn't realised this, head on over to

dw_news after you pop open the champagne.)

Bug 4050: Expanding the thread does not update comment-wrapper classes (jQuery beta)
Category: Misc UI/Frontend
Patch by:

fu
Description: For some reason, "comment-wrapper classes" makes me think of those little wonton wrappers you can find in a good supermarket. Alas that wontons, while delicious, do not go with champagne. Wantons, however, do. (This one wantonly fixes icon overlapping in the Transmogrified theme in the JS beta using ~~wonton~~ comment wrappers.)

Bug 750: Can't choose non-US country with state
Category: Misc UI/Frontend
Patch by:

fu
Description: Poms, Canucks and Strines have had intermittent issues with the "states/regions/territories" dropdown menu in profiles. This looks fixed now. (Also, am I the only one who has been around the Internet long enough to do a double-take at the typo "statse"?) Hurrah! Inexpensive yet delicious méthode champenoise from the New World all round.

Bug 4118: Sunday Morning: new themes by rising
Category: Style System
Patch by:

laitaine, Styles by:

rising
Description: For fans of Sunday Morning (as opposed to Sunday morning, which, well, I'm a tenor and a chorister, so I'm rather fond of what I get to do on Sunday mornings, just not the fact that they fall on Sunday Mornings, if you catch my meaning), there are several charming new themes for you, courtesy of

rising.

Bug 3018: Need more flexible listing of privs
Category: Site Administration
Patch by:

kareila
Description: I tell you, darlings, I am all about the flexibility. (Especially when it comes to that Tom Hardy. He is a dishy sort of chap, I don't mind saying.) Privs are the "privileges" that give developers access to various backend functions. (Just in case Tom Hardy is reading, he can have access to my backend functions any time.)

kareila has moved privs "into hooks which can be easily altered or supplemented", which makes changing their various permissions easier. (I'm leaving the bit about hooks well alone. If you're Tom Hardy, feel free to enquire further.)

Bug 4116: Funky Circles: new themes by ninetydegrees
Category: Style System
Patch by:

ninetydegrees
Description: "Please, sir, can I have some more?" "Well, as long as it's themes for the Funky Circles* style, boy, go on then."

*Dreamwidth Studios, LLC, does not guarantee funkiness of circles. Funkiness may not be as described. Funkiness suggestion only. May contain circles. Champagne not included.

Bug 4142: Practicality: custom colors not working
Category: Style System
Patch by:

ninetydegrees
Description: While this fix is deeply, deeply practical, darlings, it's specifically for the Practicality style. Custom colours (note the U, darlings, note the U) now work! Isn't it marvellous? *pop* *froth* *bubble*

Bug 3939: LWPx::ParanoidAgent in repository is old/obsolete
Category: Misc Backend
Patch by: Glitterhoof The Magic Fix Pony, AKA

mark
Description: It's not paranoia if everyone's after you, darlings. And this is another "

mark did something else and it fixed this bug" win. This is just tidying things up after that. Glitterhoof does make a mess of the floors, you know.

Bug 3607: Redesign profile edit page to not be so wide on the main site
Category: Misc UI/Frontend
Patch by:

denise
Description: This one is totally a duplicate of another bug that's already resolved, but I wanted to make a frontend joke.

Bug 4124: FAQs #86/#98/#151: update list of sites you can crosspost to/import from
Category: User documentation
Patch by:

denise
Description: This and the three following bugs are fixing FAQ issues that are self-explanatory, so I shall use the (radio edited) words of Mr Cee-Lo Green to assist. I see you driving around town with the site I love, and I'm like "FAQs for you-u-u".

Bug 4123: FAQ #98/#130: users no longer automatically get success notifications
Category: User documentation
Patch by:

denise
Description: I guess the FAQs on my website weren't enough.

Bug 4053: FAQ #23 should mention the ways you can filter pages by tags
Category: User documentation
Patch by:

denise
Description: And I'm like "FAQs for you-u-u".

Bug 4145: faq update extravaganza
Category: User documentation
Patch by:

denise
Description: And "FAQs for her too."

Bug 4169: add new faqcat for paid accounts
Category: User documentation
Patch by:

denise
Description: Yeah, go run and tell your little boyfriend.

Bug 3321: No option for subscribing/unsubscribing to comments on community posts you make
Category: User documentation
Patch by:

denise
Description: Did you want Dreamwidth to tell you that the subscription to other people replying to your comments in journals that are not your own also includes replies to your community posts? Sorry, but you were plum out of luck. The wording's been fixed now, but no change to how the function works. It was a "bug no-no", as we say in NZ. (You saw what I did there with the lowered New Zealand English vowels? Marvellous. I do like an appreciative audience. More champagne?)

Bug 3434: Document use of CSS reset
Category: User documentation
Patch by:

denise
Description: Darlings, I know that many of you just adore tables. (I do too; I myself am considering the Docksta for the 1960s Wing of my new palatial abode.) But you may not use them on Dreamwidth because it creates an awful hassle for cross-browser compatibility. There's now a FAQ explaining why, and some additional information from

denise if you're deeply curious. She's such a nice girl. (So's her wife. I'm just saying.)

Bug 4036: Journal Entries FAQ revamp
Category: User documentation
Patch by:

silverflight8
Description: Darlings, you know how I said I would be using the delightful Mr Green's lyrical splendour to talk about the FAQ changes? Well, that's before I looked into this one.

silverflight8 is an inestimable treasure for all the work on these FAQs.

denise says this is "a thing of beauty and a joy forever." Champers all round!

Bug 3025: How do modules and sidebars work? -- needs update
Category: User documentation
Patch by:

denise
Description: No, Lady Cholmondeley-Featherstonehaugh, I said modules and sidebars, not nodules and sidecars. What's that, you'd like a Sidecar? Well, all right. It's almost New Year's, after all.

Bug 3335: Username rename FAQ incorrectly states you cannot rename to a community you own
Category: User documentation
Patch by:

denise
Description: tumty tumty FAQs box, tumty tum Atari.

Bug 3585: FAQ for resecuring a broken-into account
Category: User documentation
Patch by:

denise
Description: tumty tumty cos your FAQs ain't cheap.

Bug 3789: Cannot upload communty avatar from url
Category: Communities
Patch by:

fu
Description: Remember, darlings, it's not paranoia if...? No, Mr Bauer, that's wrong. It's not paranoia if, as

fu says, "This particular manifestation fixed by using the .deb of LWPx::ParanoidAgent". Go to the back of the class.

Bug 4167: Comment "Don't autoformat" option cannot be removed upon edit
Category: Journal contents
Patch by:

fu
Description: Darlings, this sounds like when the Dowager Duchess of Dorking came to my country pile "just for a few days" and had to be carted out in a box ten years later. Except with being unable to untick the "don't autoformat" option from comments. I wish I'd had

fu around to get rid of the Dowager Duchess, I tell you that much. Absolutely emptied the wine cellar of Gevrey-Chambertin.

Bug 1846: Include username in community search
Category: Search
Suggested by:

cesy
Patch by:

fu
Description: Well, that seems a sensible thing to be able to do, darlings, doesn't it?

Bug 4144: Browse button not working in comment preview
Category: Misc UI/Frontend
Patch by:

fu
Description: Oh, "comment preview"! That's French for "how preview", darlings. I thought you'd like to know. You know what else is French? Champers. ("champ" is French for "field". Nous sommes les champignons, as the Queen song goes in French. Vive le roi.)

Bug 3764: No FAQ on what happens when you go from paid to free
Category: User documentation
Patch by:

denise
Description: I pity the fool that writes a FAQ for you...

Bug 3845: Styles: consistently use the word 'style' instead of 'layout'
Category: User documentation
Suggested by:

ninetydegrees
Patch by:

denise
Description: Darlings, apparently we "style", we do not "lay it out". I suspect that may be because one has to "bring it" before one can "lay it down", which is a necessary prerequisite for "laying it out". But this colloquial argot is really beyond me. Where's the Bollinger?

Bug 3412: Support journal parameter to addcomment
Category: APIs: RPC/XML/Flat
Patch by:

fu
Description: Do you use a downloaded client for your Dreamwidthing? The fabulous

fu has, in her own words, "let clients using the addcomment protocol add a comment to communities, or other entries on other journals, not just their own." I imagine that would be terribly useful, darlings, don't you?

Bug 4117: Implement getreadpage in the API
Category: APIs: RPC/XML/Flat
Patch by:

fu
Description: Darlings, I'm not entirely certain what this is. But I wish getdrinkchampers would be implemented in my API. Or getlicktomhardy. Either or, really. Perhaps if I ask

fu nicely? (

denise kindly informs me that this "adds a function to the APIs, which can be used by downloaded clients, that will let client authors have access to your reading page, so they'll be able to program a way to read your reading page inside the client." She also tells me that she would like a getlicktomhardy function. So if anybody's in a seasonal regifting mood...)

Bug 2829: In mobile view, display first line of post when subject is empty
Category: Misc UI/Frontend
Suggested by:

jesse_the_k
Patch by:

fu
Description: Oh, that's terribly sensible! Instead of finding (no subject) in the subject line of entries if someone hasn't entered a subject, you now get the first 40 characters of the entry. Chapeau, darlings, chapeau.

Bug 3613: create community import FAQ
Category: User documentation
Patch by:

denise
Description: I see you driving round town with the guy I love, and I'm like "FAQs for you-u-u" (note: I ran out of lyrics. This one is from the Glee cover.)

Bug 4136: diversity statement tweaks
Category: Site Administration
Patch by:

denise
Description: I wish to object that the Diversity Statement does not include the Champagne-guzzling community. If you're curious what's changed with the Diversity Statement (which, darlings, is one of the best things on the Internet, there's a diff page where you can compare.

Bug 4023: Add "Flat" and "Top-level comments only" control links to the bottom of comments pages too.
Category: Misc UI/Frontend
Patch by:

ninetydegrees
Description: Darlings, while "flat" is bad for champagne, and you don't want too much "top level" when charging your glass (top tip: simply tilt the glass to 45 degrees when pouring to avoid the froth, darlings), you do want them on your comment pages for the extra flexibility. I love a good flexible comment page, don't you?

Bug 3913: Account creation refinements
Category: User documentation
Patch by:

pauamma and

denise
Description: Okay, I am officially out of Cee-Lo Green references for FAQ updates. Did you know that, when you do a code tour, "FILL IN" is automatically inserted (hur hur) in each 'Description' slot (hur hur) for you to stick in (hur hur) your own bits (hur hur)? Well, it is. Next time, I want "TOM HARDY" automatically inserted. If you know what I mean. (And I'm rather certain you do.) In a refined way, of course, just like *boom-tish*

pauamma and

denise refinedly refined the "how do I create an account" FAQ.

That's it!

Happy New Year, darlings. May the rest of your 2011 be filled with champagne, sugared violets and lickable people, and may your 2012 not be the end of the whole bloody world. After all, there's lots of champers to drink.