Drew M.C. (![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
dreamatdrew) wrote in ![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png)
dw_dev2011-10-20 06:58 am
dreamatdrew) wrote in dw_dev2011-10-20 06:58 am
Entry tags:
Code Tour for October 12 through October 20 2011
Howdy, Dweeps, I'm dreamatdrew, and I'll be your code-tour bus driver this week. We have 8 brand-spanking-newly patched bugs for your perusal. Please be seated, and keep your various appendages inside the vehicle at all times.
Bug 3729: Non-Apache-specific way to to grab multiple form values
Category: Routing/TT
Patch by:fu
Description: This is an update to the same bug from our last code tour. We loveexor674, but, much like fu, she is not perfect and occasionally misses things. One instance of the Apache-specific way of getting this information, instead of the server-agnostic new version, managed to sneak through under the flat interface. Now it uses the new way.
Bug 1443: English strip cgi-bin/weblib.pl
Category: Misc Backend, Not Actually A bug
Non-Patch by:rb
Description: This might have been a bug at one time, but it's not now, possibly due to other things which have been done to weblib. Herbie (as she is affectionately known) figured this out, and we thank her for it.
Bug 1491: Fix import-schedule so it runs constantly
Category: Importer
Patch by:fu
Description: The importer, wonderful little worker that it is, was being a bit lazy, finishing one import run and then saying "I quit" and going home, which meant it was had to be constantly re-started, which takes a lot compared to simply staying open and starting over. It now runs continuously, which is much more efficient.
Bug 3799: LJ::Poll has non-stripped text.
Category: English-Stripping
Patch by:ninetydegrees
Description: Even more of the "Make Dreamwidth messages easier to change" project. This time, relating to poll anonymity and errors resulting from deleted poll creators. Now, getting someone to change the text of those messages does not mean making them look through the code. YAY compartmentalization.
Bug 3969: remove LJ::did_post from DW::Controller subclasses
Category: Modernization
Patch by:kareila
Description: Getting rid of dependence on BML and making things more modern. This makes the check to see if you sent data for Dreamwidth to work with not depend on BML.
Bug 3975: fix warning in LJ::Session
Category: Misc Backend
Patch by:kareila
Description: Ya know how on fill-in-the-blank forms, sometimes there are blanks that just do not apply? Sometimes this happens within the Session manager, which is not actually a bad thing, and is completely expected and not a problem. The code, however was saying "Wait, there's nothing filled in here!! SOMETHING IS WRONG!!". The code now knows that some things are allowed to be blank, and it can quit filling the logs with problems that are not problems.
Bug 1964: taglists truncated when crossposting
Category: Crossposter
Patch by:rb
Description: There are actually two places where the tags for an entry are stored in the database. One of them can be cut off if it is longer than 254 characters. Unfortunately, the crossposter was using this possibly-shorter version of the list of tags. It now knows to look at the guaranteed full version, and crossposts tags correctly.
Bug 3772: Log out button: clicking on the Log out button in navigation doesn't log you out
Category: Misc UI/Frontend
Patch by:rb
Description: The "Log out" button in the site navigation menu redirects to the actual logout page. This is supposed to serve as a confirmation, and add a layer of 'yes this is actually happening' security, but the page was not making that clear. The text on the logout page has been changed to make it clearer that a confirmation is required.
That's it for this week. Tune in next time, when we'll have even more exciting bug-squishing action for you.
dreamatdrew, and I'll be your code-tour bus driver this week. We have 8 brand-spanking-newly patched bugs for your perusal. Please be seated, and keep your various appendages inside the vehicle at all times. Bug 3729: Non-Apache-specific way to to grab multiple form values
Category: Routing/TT
Patch by:
fuDescription: This is an update to the same bug from our last code tour. We love
exor674, but, much like fu, she is not perfect and occasionally misses things. One instance of the Apache-specific way of getting this information, instead of the server-agnostic new version, managed to sneak through under the flat interface. Now it uses the new way. Bug 1443: English strip cgi-bin/weblib.pl
Category: Misc Backend, Not Actually A bug
Non-Patch by:
rbDescription: This might have been a bug at one time, but it's not now, possibly due to other things which have been done to weblib. Herbie (as she is affectionately known) figured this out, and we thank her for it.
Bug 1491: Fix import-schedule so it runs constantly
Category: Importer
Patch by:
fuDescription: The importer, wonderful little worker that it is, was being a bit lazy, finishing one import run and then saying "I quit" and going home, which meant it was had to be constantly re-started, which takes a lot compared to simply staying open and starting over. It now runs continuously, which is much more efficient.
Bug 3799: LJ::Poll has non-stripped text.
Category: English-Stripping
Patch by:
ninetydegreesDescription: Even more of the "Make Dreamwidth messages easier to change" project. This time, relating to poll anonymity and errors resulting from deleted poll creators. Now, getting someone to change the text of those messages does not mean making them look through the code. YAY compartmentalization.
Bug 3969: remove LJ::did_post from DW::Controller subclasses
Category: Modernization
Patch by:
kareilaDescription: Getting rid of dependence on BML and making things more modern. This makes the check to see if you sent data for Dreamwidth to work with not depend on BML.
Bug 3975: fix warning in LJ::Session
Category: Misc Backend
Patch by:
kareilaDescription: Ya know how on fill-in-the-blank forms, sometimes there are blanks that just do not apply? Sometimes this happens within the Session manager, which is not actually a bad thing, and is completely expected and not a problem. The code, however was saying "Wait, there's nothing filled in here!! SOMETHING IS WRONG!!". The code now knows that some things are allowed to be blank, and it can quit filling the logs with problems that are not problems.
Bug 1964: taglists truncated when crossposting
Category: Crossposter
Patch by:
rbDescription: There are actually two places where the tags for an entry are stored in the database. One of them can be cut off if it is longer than 254 characters. Unfortunately, the crossposter was using this possibly-shorter version of the list of tags. It now knows to look at the guaranteed full version, and crossposts tags correctly.
Bug 3772: Log out button: clicking on the Log out button in navigation doesn't log you out
Category: Misc UI/Frontend
Patch by:
rbDescription: The "Log out" button in the site navigation menu redirects to the actual logout page. This is supposed to serve as a confirmation, and add a layer of 'yes this is actually happening' security, but the page was not making that clear. The text on the logout page has been changed to make it clearer that a confirmation is required.
That's it for this week. Tune in next time, when we'll have even more exciting bug-squishing action for you.
no subject
(I feel obligated to say that on the first bug, that one was all mine, because I was in charge of making sure that nothing like that snuck through!)
no subject