Upstream flag

[denise]

After discussion with tupshin and henrylyne this past week, we've figured out that the best way for us to get patches committed upstream to LJ is to create a new flag in our Bugzilla, which I've done: now, when you upload a patch, you can also set the "Upstream" flag, which will call things to Henry's attention. He's agreed to be our liaison.

This flag should be used when you're uploading a patch that also patches a bug that appears on LJ. It shouldn't be used for new features or for things that patch bugs that only appear on DW.

If you've got things that have already been resolved/fixed that you think should be pulled upstream, comment here and I'll assemble a list for Henry and Tupshin.

Comments

[afuna]

Hmmm. The only thing that comes to mind for the patches I've done is http://bugs.dwscoalition.org/show_bug.cgi?id=613, which is in an LJ-repo, not one of ours (but fixing it means that we can pull the fix downstream and will fix things on our end, too).

I initially submitted it via the lj support board, and just got a reply saying it's now in JIRA, so it may already be on the radar, but no harm in mentioning it in the list?

ETA: I just realized I can upload the patch / flag it upstream, to go through the normal channels! Have done so, please ignore comment :)

[foxfirefey]

This is so freaking exciting.

[kareila]

Where do we go to view the current LJ source, so I can see if any of my patches are applicable?

[afuna]

* http://bugs.dwscoalition.org/show_bug.cgi?id=796 - Don't let "Misc" tab show up if it only contains noui and grouped properties

They can ignore the "grouped" bit, but the logic for "noui" should still be applicable


* http://bugs.dwscoalition.org/show_bug.cgi?id=590 - Editing profile page doesn't print out errors

* http://bugs.dwscoalition.org/show_bug.cgi?id=538 - fix reference to the current page, when the controlstrip is loaded using JavaScript
This doesn't actually cause any problems for LJ now, since they don't have any URLs in the navstrip that depend on the current journal being viewed, but worth looking at the issue, when they get the time, in case that changes in the future? Patch itself won't apply; too different

* http://bugs.dwscoalition.org/show_bug.cgi?id=481 - ljuser getting extra </a></b></a> tags
specifically this patch: http://bugs.dwscoalition.org/attachment.cgi?id=625

ISTR I opened a request, so this may already be in their system.

* http://bugs.dwscoalition.org/show_bug.cgi?id=414 - Text message disclaimer footer gets printed out multiple times (or 0 times)

* http://bugs.dwscoalition.org/show_bug.cgi?id=30 - Entry preview should respect no-custom-comment-pages

[exor674]

http://bugs.dwscoalition.org/show_bug.cgi?id=79
http://bugs.dwscoalition.org/show_bug.cgi?id=531

Both of these have been Upstream?'d, but poking you here too.

[mark]

I don't really like this but can't quite explain it. I don't want us beholden to figure out what is or is not worthy for pushing upstream. They don't tell us what to pull downstream, y'know?

And as mentioned elsewhere, please please please at least do me the courtsey of holding off on making changes to the development process until I get back. Discuss all you like (CC me!!) but stop pulling triggers... kinda frustrating.