foxfirefey (![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
foxfirefey) wrote in ![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png)
dw_dev2011-05-26 02:21 am
foxfirefey) wrote in dw_dev2011-05-26 02:21 am
Entry tags:
Code Tour, 2011-05-19 through 2011-05-25
A bit of review background on some of these bugs: when you see things happening that have to do with jQuery, remember that we're doing it to make it easier to do fun dynamic UI (and much more visually consistent!) things with the site as part of our modernization efforts. You can help us beta test out this conversion by signing up for beta features--some features aren't implemented yet, but the beta features page has a list of what is and isn't yet available.
Bug 3684: Contextual hover menu positioning not always accurate (jquery beta)
Category: Misc UI/Frontend
Patch by:fu
Description: Our journey towards jQuery-fied journals continues. In this case, tooltips used for things like contextual hovers weren't working in Fluid Measure, so Fu tweaked the methods we were using for it.
Bug 3685: Deleted comments by anonymous users shows an error message in the inbox
Category: Inbox/Notifications
Patch by:fu
Description: If you had a comment notification made by an anonymous user, but the comment had been deleted, there was an inscrutable technical error message. Now useful messages display instead.
Bug 3686: Code in error callback duplicated across jquery ajax widgets
Category: Misc UI/Frontend
Patch by:fu
Description: So, when you are coding it is generally a good idea to have bits of code that do the same thing in the same place, instead of having multiple copies in different places. This does that for some error message instances in our jQuery.
Bug 3696: jQuery contexthover - '$parent.attr("href")' [undefined] is not an object.
Category: Modernization
Patch by:fu
Description: Basically, parts of the jQuery used to figure out what username to use for contextual hovers have trouble if, say, the username is in the subject of the post and not linked the same as it would usually be. This fixes the mysterious error that used to result in such an instance.
Bug 3679: Nouveau Oleanders: Vintage Christmas doesn't set a page text/entry text color anywhere
Category: Style System
Patch by:ninetydegrees
Description: Recently I noticed a theme in Nouveau Oleanders that didn't set a color for the page text! That can lead to hijinks if somebody has set a defined color for their browser that doesn't work with the set background, so I filed a bug, andninetydegrees quickly fixed it.
Bug 3693: Compartmentalize: 3 themes
Category: Style System
Patch by:sarken
Description: Hurrah for new Compartmentalize themes! You can see them here.
Bug 1581: Index for /security/
Category: Journal contents
Suggested by:cesy
Patch by:fu
Description: So, there's a nifty filtering thing that will let you view entries with a certain access level on journals or your reading page. Example: http://USERNAME.dreamwidth.org/read/security/public will show only the public entries on your reading page. http://USERNAME.dreamwidth.org/security/public will show only public entries on your journal. However, if you didn't have anything after the security part, you'd get an ugly 404 page. This bug makes this feature more accessible by instead giving you a list of available security filter types you can use.
Bug 3697: Reading Page Subtitle always takes up space
Category: Style System
Patch by:fu
Description: Reading page subtitles would print out in a header tag--even if they had no text, taking up space and being useless! THis makes sure to only print out that subtitle header tag if there's actually a subtitle.
Bug 3684: Contextual hover menu positioning not always accurate (jquery beta)
Category: Misc UI/Frontend
Patch by:
fuDescription: Our journey towards jQuery-fied journals continues. In this case, tooltips used for things like contextual hovers weren't working in Fluid Measure, so Fu tweaked the methods we were using for it.
Bug 3685: Deleted comments by anonymous users shows an error message in the inbox
Category: Inbox/Notifications
Patch by:
fuDescription: If you had a comment notification made by an anonymous user, but the comment had been deleted, there was an inscrutable technical error message. Now useful messages display instead.
Bug 3686: Code in error callback duplicated across jquery ajax widgets
Category: Misc UI/Frontend
Patch by:
fuDescription: So, when you are coding it is generally a good idea to have bits of code that do the same thing in the same place, instead of having multiple copies in different places. This does that for some error message instances in our jQuery.
Bug 3696: jQuery contexthover - '$parent.attr("href")' [undefined] is not an object.
Category: Modernization
Patch by:
fuDescription: Basically, parts of the jQuery used to figure out what username to use for contextual hovers have trouble if, say, the username is in the subject of the post and not linked the same as it would usually be. This fixes the mysterious error that used to result in such an instance.
Bug 3679: Nouveau Oleanders: Vintage Christmas doesn't set a page text/entry text color anywhere
Category: Style System
Patch by:
ninetydegreesDescription: Recently I noticed a theme in Nouveau Oleanders that didn't set a color for the page text! That can lead to hijinks if somebody has set a defined color for their browser that doesn't work with the set background, so I filed a bug, and
ninetydegrees quickly fixed it.Bug 3693: Compartmentalize: 3 themes
Category: Style System
Patch by:
sarkenDescription: Hurrah for new Compartmentalize themes! You can see them here.
Bug 1581: Index for /security/
Category: Journal contents
Suggested by:
cesyPatch by:
fuDescription: So, there's a nifty filtering thing that will let you view entries with a certain access level on journals or your reading page. Example: http://USERNAME.dreamwidth.org/read/security/public will show only the public entries on your reading page. http://USERNAME.dreamwidth.org/security/public will show only public entries on your journal. However, if you didn't have anything after the security part, you'd get an ugly 404 page. This bug makes this feature more accessible by instead giving you a list of available security filter types you can use.
Bug 3697: Reading Page Subtitle always takes up space
Category: Style System
Patch by:
fuDescription: Reading page subtitles would print out in a header tag--even if they had no text, taking up space and being useless! THis makes sure to only print out that subtitle header tag if there's actually a subtitle.