![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png){kind=small}
Entry tags:
S2 Max Recursion and Comment Threads
I understand why the max recursion limit exists, but at the moment it's sort of ugly in its execution with regard to comment threads.
For example, if a comment thread exceeds the limit the layer dies as expected. However, there's no obvious indication beforehand that it's going to happen, so someone doing something as innocent as commenting effectively ruins the remainder of the comment threads on the entry. Now, you can see the rest of the comments if you view the entry in a site scheme, but that's not immediately obvious to Joe User.
I'll be the first to admit that I'm definitely no programming expert so I may be asking the impossible... Can we only kill the function that causes the recursion limit in a way that'll let the remaining comment threads on an entry get printed? It was also mentioned to me that perhaps we could look in to printing the comment threads iteratively rather than recursively? At the least, can/should we prevent people from making the nth comment that'll hit the recursion limit and therefore break the rest of that entry's comments?
For example, if a comment thread exceeds the limit the layer dies as expected. However, there's no obvious indication beforehand that it's going to happen, so someone doing something as innocent as commenting effectively ruins the remainder of the comment threads on the entry. Now, you can see the rest of the comments if you view the entry in a site scheme, but that's not immediately obvious to Joe User.
I'll be the first to admit that I'm definitely no programming expert so I may be asking the impossible... Can we only kill the function that causes the recursion limit in a way that'll let the remaining comment threads on an entry get printed? It was also mentioned to me that perhaps we could look in to printing the comment threads iteratively rather than recursively? At the least, can/should we prevent people from making the nth comment that'll hit the recursion limit and therefore break the rest of that entry's comments?
no subject
It's mostly loading the rows from talktext2 though, since that's potentially a LOT of data off of the disks. If you have 250 comments on the page, all reasonably long (couple kilobytes), you're talking about loading a megabyte of data...
Which is a lot. But, caching! You might mention caching! That should fix this problem, right?
Well, sure, to some extent. There's a compounding problem in popular communities where people are editing and posting new comments a lot, leading to some of the caches getting cleared fairly often.
Of course, counter-argument is: computers have gotten a lot faster since this was instituted a few years ago. We now have so much RAM available that we can, in theory, maintain huge cache hit rates and maybe give people everything they want and a bunny rabbit...
But I dunno. We'll have to play with it over time. I'll be gone for the next month, but I'm amenable to revisiting old LJ performance decisions to see if we can get around them.
no subject