wyntarvox: (Default)
wyntarvox ([personal profile] wyntarvox) wrote in [site community profile] dw_dev2009-05-20 07:20 pm
Entry tags:

S2 Max Recursion and Comment Threads

I understand why the max recursion limit exists, but at the moment it's sort of ugly in its execution with regard to comment threads.

For example, if a comment thread exceeds the limit the layer dies as expected. However, there's no obvious indication beforehand that it's going to happen, so someone doing something as innocent as commenting effectively ruins the remainder of the comment threads on the entry. Now, you can see the rest of the comments if you view the entry in a site scheme, but that's not immediately obvious to Joe User.

I'll be the first to admit that I'm definitely no programming expert so I may be asking the impossible... Can we only kill the function that causes the recursion limit in a way that'll let the remaining comment threads on an entry get printed? It was also mentioned to me that perhaps we could look in to printing the comment threads iteratively rather than recursively? At the least, can/should we prevent people from making the nth comment that'll hit the recursion limit and therefore break the rest of that entry's comments?
animone: Black★Rock Shooter (Default)

[personal profile] animone 2009-05-20 09:12 pm (UTC)(link)
Somewhat related.. I'll go ahead and ask a lot here and outline what I think could be an ideal situation. I'd love to see collapsed threads (yes, I do understand the need for them, especially when they get very long/in-depth) be user-expandable by some ajax-y method. Unnfortunately, I don't see any good way of implementing this across all styles. I'd also like to see the limit at which threads auto-collapse be a user-defineable variable, of course within reason. The default could be left relatively small, with increased ease of expanding them.
afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)

[personal profile] afuna 2009-05-21 01:52 pm (UTC)(link)
Hey, the auto-expand is already implemented, though it only shows up if you're paid, or the journal you're viewing is paid.

For an example, see http://dw-news.dreamwidth.org/6299.html#comments (that one's a site scheme page, but works for styles which are properly coded, too!)