S2 Max Recursion and Comment Threads

[wyntarvox]

I understand why the max recursion limit exists, but at the moment it's sort of ugly in its execution with regard to comment threads.

For example, if a comment thread exceeds the limit the layer dies as expected. However, there's no obvious indication beforehand that it's going to happen, so someone doing something as innocent as commenting effectively ruins the remainder of the comment threads on the entry. Now, you can see the rest of the comments if you view the entry in a site scheme, but that's not immediately obvious to Joe User.

I'll be the first to admit that I'm definitely no programming expert so I may be asking the impossible... Can we only kill the function that causes the recursion limit in a way that'll let the remaining comment threads on an entry get printed? It was also mentioned to me that perhaps we could look in to printing the comment threads iteratively rather than recursively? At the least, can/should we prevent people from making the nth comment that'll hit the recursion limit and therefore break the rest of that entry's comments?

Comments

[pauamma]

IIRC, there's a sitewide limit on thread depth, independent of styles. Like, 150 or so? Maybe we could adjust the recursion limit to rely on that? (Assuming the problem is because it currently uses a lower value.)