Code tour: 2010-11-26 to 2010-12-01

[john]

(To the tune of "Good Morning, Baltimore") Good evening, Wellington! ...wait, nothing rhymes with Wellington. This is a crap song. (Perhaps "Duke Ellington" rhymes? Hmm.)

ANYWAY. It is a gloriously sunny December evening here in the capital of New Zealand. I've just moved here from the UK, and since it's already tomorrow here, I thought I should take you through yesterday's code tour. (Which is today, for those of you to my west. I hate temporal mechanics.)

By the way, all of these patches are HOT LIVE NOW on Dreamwidth, since yesterday's code push. If you have any concerns, or if anything is broken, please feel free to use the usual channels. (Darlings, I have no idea what the usual channels are, but I'm sure they're fabulous. Just comment here if you don't know and I'm sure somebody who knows what they're doing will be right on top of you like jam on a scone at the Ritz. More champagne? I don't mind if I do!)

Bug 2684: Segfault in Unicode::CheckUTF8, if we pass in a non-string to LJ::is_utf8
Category: Misc Backend
Patch by: exor674
Description: So the first bug on the code tour? I have absolutely no idea about. denise tells me that it...actually, I have no idea what she just told me. It has something to do with UTF-8 encoding, which I think is Writing In Foreign, not crashing. Or something. And she's a lovely person, and she has a really hot and clever wife, and she's just bought a house, so why wouldn't you believe her?

Bug 3249: holiday bonus promo
Category: Site Administration
Patch by: fu
Description: 10% extra on all orders made in the month of December! Champagne and caviar all round. Mine's a Bolly, the 2000 if you have any left.

Bug 3152: create Keywords.pm for interest-related code
Category: Misc Backend
Patch by: kareila
Description: Well, this is another one that I have no idea about. denise tells me that this is a cleanup of the subroutine things that deal with interests, bringing them all together to make life easier for devs. I don't know, aren't they all in the EPS conduits in the Jefferies Tubes?

Bug 3284: Funky Circles: remove superfluous !important
Category: Style System
Patch by: ninetydegrees
Description: Are you using the fabulous Funky Circles? I am! This one removes superfluous !important from it. No, darlings, I have no idea what that does, but the bug tells me that superfluous !importants are "bad, bad, bad". So, hurrah for the fix. More Bollinger, please?

Bug 3268: Include navigation options after adding an interest
Category: Site Layout/Navigation
Suggested by: tree
Patch by: ninetydegrees
Description: Oh, this is very clever! After adding an interest, you now have additional options for doing things next. But there doesn't seem to be an option for "pour me another glass of Chateau Lafitte, please". How does one go about raising a bug for that?

Bug 3253: Wrap links in email notifications with spaces
Category: Inbox/Notifications
Suggested by: azurelunatic
Patch by: ninetydegrees
Description: Oh, the Divine Miss Lunatic! Darling, it has been too long, but we will always have the Rocky Horror Picture Show in Pacific Heights. This bug helpfully fixes a horrid little problem where parentheses after a link were turned into part of the link by some email clients. Ghastly. The fix (as with all of these) should be live now, so hopefully that's all done and dusted.

Bug 3265: Link back to support from support notifications page
Category: Site Layout/Navigation
Suggested by: cesy
Patch by: ninetydegrees
Description: Smashing idea! This creates a link back to the support page from the success page after you've changed your support notifications. So, if you do that, this sounds terribly helpful. Chapeau, darlings.

Bug 3312: Timeformat setting showed to communities, where it doesn't actually make sense.
Category: Misc UI/Frontend
Patch by: ninetydegrees
Description: So, this very sensibly stops showing timeformats to communities. I know I hate when that happens. It's like somebody passing the port to the right at a dinner table. Simply ghastly. (The real reason, according to denise, is that your and my individual time settings always override whatever the community's timeformat is when we read. So it's entirely superfluous.) Hurrah!

Bug 3307: remove Beta Helper page
Category: Payments
Patch by: kareila
Description: "Beta Helper" sounds useful, doesn't it, darlings? Alas, it's less helpful than a kazoo attachment for a scuba mask. This is a relic of the olden days when men were men and sheep were scared, before the Dreamwidth payment system was finished, and it let the devs set themselves as paid accounts to test those features. Since we now have a proper, honest-to-goodness, heavens-to-murgatroyd, twenty-four-hours-to-tulsa payment system, this won't work properly, so away it goes.

Bug 3311: unknown8bit entries cannot be edited, and break /editjournal if they exist in the range.
Category: Journal contents
Patch by: exor674
Description: Ah, marvellous! If you, darlings, or your old client or Del.icio.us autoposter or whatnot, were foolish enough to declare the wrong character set, you wouldn't have been able to edit the entry. (Well, I do declare!) This marvellous fix lets you do just that. Although you'll need to fix the characters that display as ?. (Gosh, that sentence sounds Australian? At least it does to me? Feesh and cheeps, innywan?)

Bug 2792: regexp cleanup
Category: Misc Backend
Patch by: kareila
Description: denise tells me that this rewrites our backend code to be faster and more efficient. (Apparently, this week is unusually backend-heavy. Just how I like 'em, hurr hurr. *winning smile*)

Bug 3319: Setting a color to transparent in the layout layer prevents detection of unset variables
Category: S2 Backend
Patch by: fu
Description: Ooh, setting colours to transparent in the layout layer. I don't mind saying that there are some people whose layout layers I'd like to change to transparent, if you know what I mean. Tom Hardy, I'm looking at you. This fixes a reported bug with the code push, where some bits of styles were being set to transparent when they shouldn't have. And if Tom Hardy is reading this, please get in contact so I can set your style to transparent. Thank you.

Well, this has been this week's code tour. Please return your seatbacks to the upright position and lower your armrests. Those of you in our first class cabin should put away the champers now. Yes, sir, that means you. Yes, you in the "I <3 Kittens" shirt. I can see you from here. Well, sir, it could be worse, we could be Qantas.

Comments

[dreamatdrew]

John, I <3 you, you silly tribble.

[sid]

:-D This was very informative! *makes note to pass the port to the left*

[toby]

:))))

<33333

[the_shoshanna]

Wow, was this ever the wrong code tour to read on the morning after the night before. And yet -- hee!

[sporky_rat]

I vote john does the Code Tour at least once a year. We NEED information like this.

[sara]

*cackles* Jesus fuck, John, I still have no idea what the code does but you've certainly filled me with enthusiasm for referring to the Tedious Doing More Graphic Design portion of my morning.

Okay, not really, mostly you've made me want a drink but it's 9:28 a.m. and the sun is quite clearly not over the yardarm (indeed, this being December, it will be roughly four months until we see the sun again, but hey.)

[porta_niveus]

i vote john does the code tour ALWAYS!

[sky]

This is officially my favorite code tour.

[holyschist]

This may be the best code tour ever.

[chris]

Yes, you in the "I <3 Kittens" shirt.

moop?

[dorothy1901]

Bug 3253: Wrap links in email notifications with spaces

Yay! It's been fixed!

Fabulous tour, BTW.

[delight]

This code tour is MARVELOUS.

[catchmyfancy]

\O/

Yay: alcomocol and Fabulous Geek Rant: one adored this, sweetie darling sweetie (and by the way my knowledge of code and similar is along the lines of "he said 'back end' fnar fnar fnar", so I'm all o_O that you made me snarfle my way through this).

AND it made me want to break out the alcomohol almost as much as when I drag out the "Bad Santa" DVD for its yearly viewing.

When you come to Melbun and I will take you to the Gin Palace. Or Vodka Borscht & Tears.

[cesy]

I love this code tour.

[baggyeyes]

♥♥♥

[musyc]

I don't think I've ever enjoyed a code tour more. Hip hip huzzah for john! :D

[azurelunatic]

So we shall, my dear, so we shall!

Did I mention that after our party went its separate ways, that I chanced upon a giggle of virgins? And that they, poor things, were planning to ride home on BART? At 3am? On a weekend? The very day that BART's weekend service went from early to 8am? The last I saw of them, they'd decided to head for a diner to wait for transit to wake up.

[frandroid]

This was fun!