Code tour, October 20th, 2010 to October 29th, 2010

[bookofjude]

This is a code tour, I'm told, and also my first. Please forgive my tendency towards concise summations.

Bug 3150: need a page for siteadmins to be able to initiate renames
Category: Site Administration
Patch by: fu
Description: Creates a front-end for the back-end allowing siteadmins to initiate account renames.

Bug 3151: pop_interests never removed when unpopular
Category: Misc Backend
Patch by: alierak
Description: Resolves an issue where interests that had become popular (more than 400) would never be removed from statistics when dropping below 400.

Bug 3169: "What are interests?" does not acknowledge the different limits.
Category: User documentation
Patch by: denise
Description: FAQ/Documentation updated to properly indicate the number of interests each different type of account can have.

Bug 2030: create/setup.bml sends multiple subscription/access ESN if interests error
Category: Registration
Patch by: kareila
Description: Prevents multiple subscriptions/access grantings to an account by checking to see if it is already subscribed to or granted access to.

Bug 3162: fix Location widget arguments in CreateAccountProfile widget
Category: Misc Backend
Patch by: kareila
Description: Properly passes arguments to Location widget from the CreateAccountProfile widget.

Bug 2981: Styles: loophole in header font strings
Category: Style System
Patch by: ninetydegrees
Description: In styles, let header fonts actually be defined by the CSS, as opposed to letting the browser's default base font overriding it.

Bug 3003: Sunday Morning & Skittlish Dreams: changing the sidebar width fails and/or causes weirdness
Category: Style System
Patch by: ninetydegrees
Description: Allows the sidebar_width to work on the Skittlish Dreams and Sunday Morning styles, whereas it previously caused layout issues.

Bug 3037: Modish: unreadable text in comments in some themes
Category: Style System
Patch by: ninetydegrees
Description: Prevents unreadable comment date, title and title text and IP address in some styles (Grey Scales, Verdigris).

Bug 3078: Styles: refactor the CSS styling of the navlinks module to remove the absolute positioning in some styles
Category: Style System
Patch by: ninetydegrees
Description: Removes absolute positioning of the navigation links module in Basic Boxes, Crossroads, Boxes and Borders and Nouveau Oleanders. Previously, this was necessary, but due to refactoring of source code, it has become redundant.

Bug 3124: Brittle: 4 themes by musyc
Category: Style System
Patch by: ninetydegrees, theme by musyc
Description: Four themes submitted by musyc, and their first contribution to DreamWidth!

Bug 3125: Compartmentalize: 12 themes by musyc and rising
Category: Style System
Patch by: ninetydegrees, themes by musyc, rising
Description: Six themes each created by musyc and rising.

Bug 3145: Crossroads & Practicality: 2 themes by rising
Category: Style System
Patch by: ninetydegrees, theme by rising
Description: Two themes by rising.

Bug 2922: redirect m.dreamwidth.org to dreamwidth.org/mobile
Category: Site Layout/Navigation
Patch by: alierak
Description: As suggested by an anonymous user, m.dreamwidth.org now redirects to dreamwidth.org/mobile.

Bug 3166: Template with no output cause a redirect to /
Category: Routing/TT
Patch by: exor674
Description: Resolves an issue where, if a template has no output and is therefore not rendered, pages are automatically redirected to siteroot.

Bug 1773: multiple layouts hardcode time font color
Category: Style System
Patch by: kareila
Description: Removes instances where multiple layouts hard-code colours (for time, etc) as opposed to using user-controllable variables.

Bug 3040: clean up log messages that appear when global warnings are on
Category: Misc Backend
Patch by: kareila
Description: Resolves instances where global warnings being enabled, various parse and deprecation warnings were reported

Bug 3139: remove "use constants" lines from S2 layer code
Category: S2 Backend
Patch by: kareila
Description: Prevent constants already defined in the base S2 code from being redefined every layer.

Bug 3158: check calls to LJ::ago_text for inappropriate uses of zero
Category: Misc UI/Frontend
Patch by: kareila
Description: Defines a new wrapper function to prevent calls to LJ::ago_text with zero values returning "never" for recent changes. This prevents recently created things from displaying "Never" if they were finished less than a second ago.

Bug 1845: Cumulative layout credits
Category: Style System
Patch by: ninetydegrees
Description: Layouts are now credited cumulatively from all layers. This prevents instances where proper credit is not being given to relevant coders.

Bug 2976: Brittle: use appropriate props for sidebar module colors and entry link colors
Category: Style System
Patch by: ninetydegrees
Description: Previous variable combinations were not flexible enough and thus caused some combinations in themes to be unreadable.

Bug 3008: EasyRead: add custom colors for Reading page option
Category: Style System
Patch by: ninetydegrees
Description: Implements variables for customised colours for the EasyRead style's Reading page.

Bug 3164: Convert /admin/index to TT
Category: Routing/TT
Patch by: exor674
Description: Converts the /admin/index from BML to TT.