S2 constant errors

[kareila]

With global warnings on, some permutation of these lines shows up in the log whenever I hit an S2 page:

Constant subroutine S2::PROPS redefined at /usr/share/perl/5.8/constant.pm line 103.
Constant subroutine S2::STATIC redefined at /usr/share/perl/5.8/constant.pm line 103.
Constant subroutine S2::VTABLE redefined at /usr/share/perl/5.8/constant.pm line 103.

Any ideas as to why this might be happening?

Comments

[kareila]

I am starting to suspect this code in s2/S2/BackendPerl.pm:

$io->writeln("package S2;");
$io->writeln("use strict;");
$io->writeln("use constant VTABLE => 0;");
$io->writeln("use constant STATIC => 1;");
$io->writeln("use constant PROPS => 2;");
$io->writeln("register_layer($this->{'layerID'});");

I think that results in the constants being redefined every time an S2 layer is loaded? Removing the lines had no immediate effect; I think all the layers would have to be recompiled as well?

[andy]

I guess these lines can just be moved to S2.pm, no?

[kareila]

Uh, they're already in S2.pm.

Edit: which is to say, yes, since they're there, I wouldn't see any harm with removing the lines from BackendPerl.pm. But when I tried that, the warnings didn't disappear immediately.

[andy]

You will need to recompile all styles on your dev server, obviously. Issue bin/upgrading/update-db.pl --help and go from there, the appropriate flags would be -f -p, but I'm unsure.

[kareila]

From decoding the GetOptions call, it looks like --forcebuild (not listed in --help). But thanks for the pointer.

So after trying that, I'm still seeing the redefined constants twice per S2 lastn page call and once per every other S2 page call. Since S2.pm is loaded in LJ::S2 and LJ::S2::EntryPage, I think they are still being reloaded by mod_perl every time, even though the files haven't changed.

[kareila]

Hmm, does update-db.pl recompile the user layers as well, or only the system layers? If the existing user layer still tries to redefine the constants, that might also affect what I'm seeing.

[kareila]

alierak executed this SQL query to fix the user layers:

update s2compiled2 set compdata=replace(compdata,'use constant VTABLE => 0;\nuse constant STATIC => 1;\nuse constant PROPS => 2;\n','');

That seems to have done the trick, phew.