S2 constant errors

[kareila]

With global warnings on, some permutation of these lines shows up in the log whenever I hit an S2 page:

Constant subroutine S2::PROPS redefined at /usr/share/perl/5.8/constant.pm line 103.
Constant subroutine S2::STATIC redefined at /usr/share/perl/5.8/constant.pm line 103.
Constant subroutine S2::VTABLE redefined at /usr/share/perl/5.8/constant.pm line 103.

Any ideas as to why this might be happening?

Comments

[kareila]

Is it not possible to avoid redefining the constants in the first place? I mean, if they're constants, we shouldn't be trying to change them. As it is, even if we compress the warnings to one line, that line would still be printed every time we load an S2 page, which is gratuitous even for a dev server.

[alierak]

If I understand fu correctly, they're only defined once in all the code, but an Apache process that stays running for a while may read a new version of the code, containing a new definition of the constants. If that's the case, restarting Apache should make it quit warning you.

[kareila]

I think it's happening when S2 layers are loaded (see my new comment below).

[fu]

I think it's any constants at all, when the file is reloaded (and we could do it one check per set of files to be reloaded in a request, which will make things a lot less verbose)

You can see it if you, e.g., touch $LJHOME/cgi-bin/DW/InviteCodes.pm; when that is reloaded, you get all the warnings about the constants in there.