![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png){kind=small}
Entry tags:
Code tour: 22 Sept - 30 Sept
This week we have 14 bugs resolved, including one by new contributor ![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
jld. None of these fixes are live yet, but they will be after this weekend's code push.
Bug 3044: Tranquility III: Deep Purple by dancing_serpent
Category: Style System
Patch by:dancing_serpent
Description: This adds a new theme, "Deep Purple", for Tranquility III. Check it out here.
Bug 2992: City field does not display for US users
Category: Misc UI/Frontend
Patch by:jld
Description: So, one of the things we inherited from LJ was a thing where you could type in your ZIP code and it would guess at your city and state. Except it was buggy and not very accurate, and when we forked from LJ we didn't have the zip code lookup table, and and and ... far easier to just yank it all out. Whichjld did, for his first accepted patch! Welcome, jld.
Bug 2812: clean up error logs
Category: Misc Backend
Patch by:kareila
Description: Sometimes, code is not as good as it should be, and leaves warnings -- the page will still display, and things work correctly, but there's a little "hey, fix this when you get a chance" type note in the error logs. This can clutter up the error logs and prevent noticing and diagnosing bigger problems, sokareila has been on a mission to find the cause of all the warnings and squash them.
Bug 2624: Misc. Layouts: fix position options of Navigation module
Category: Style System
Patch by:ninetydegrees
Description: Here is where I confess that I know less than nothing about the style system, but thankfully we have people likeninetydegrees to take care of it for me. I'm pretty sure this is a fix for a problem where the Navigation module would only display in the header of layouts, instead of where the user wanted it to be.
Bug 3056: New Style: Practicality by timeasmymeasure
Category: Style System
Patch by:ninetydegrees
Description: This adds an entirely new style to the system, called Practicality. You can see the preview here. (I love this one -- it's pretty and clean.)
Bug 2990: refactor common code in sitescheme files
Category: Modernization
Patch by:kareila
Description:![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
karzilla, Destroyer of Code, strikes again! This changes the way that the site scheme (the site layouts such as Tropospherical Red/Purple, Gradation Horizontal/Vertical, and Celerity) are coded, so that similar code isn't repeated in different files but instead is all grouped together in one file and then called from the 'child' files. This is to the benefit of developers, because it means that you only have to look for it once.
Bug 3010: Stats: "Active in some way" has been frozen at 24288 since 2010-04-29
Category: Configuration
Patch by:mark
Description: As many people noticed, the old stats page had the "Active in some way" count frozen for a long time. This is because a particular nightly job wasn't running. (The new stats, which have some different sections, were correct.) We turned the job back on, and now the stats are correct.
Bug 2793: Cleaning: make all layout.pm files look the same
Category: Style System
Patch by:ninetydegrees
Description: This (and the next one) is an epic bug thatninetydegrees has been working on for-freaking-ever, and the sad thing is, y'all will never notice unless you're doing DW development. It basically takes all the layout files for the site's themes and styles and makes sure that everything is in the same place in all the files, every property is alphabetized, and everything is nice and tidy. It's going to make going forward so much easier.
Bug 2894: Cleaning: make all themes.s2 files look the same
Category: S2 Backend
Patch by:ninetydegrees
Description: See previous bug!
Bug 3020: In some styles, list characters overlap icon
Category: Style System
Patch by:ninetydegrees
Description: This is a CSS fix for several styles, where if you started an entry with an ordered or unordered list, the text would overlap your icon.
Bug 3075: Template Toolkit Plugin needs a js filter
Category: Routing/TT
Patch by:fu
Description: This adds a method for dealing with javascript to our new method of creating/displaying site pages, Template Toolkit. (We are slooooowly moving from the old style, BML, to the new style, Template Toolkit, since BML is very outdated and TT does a lot more that we need it to do. It's slow going, and we keep finding holes in what we need!)
Bug 3076: Style browser doesn't update with new styles immediately after update-db is run
Category: Site Administration
Patch by:fu
Description: This was a problem with the system caching the old value of things, and we changed it so that new styles display immediately instead of when the cache expires.
Bug 3077: Blanket: non-squared userpics are distorted
Category: Style System
Patch by:ninetydegrees
Description: This is a CSS fix for the Blanket layout, where userpics that weren't exactly square were being displayed weirdly.
Bug 3074: Rename email text issues
Category: Misc UI/Frontend
Patch by:fu
Description: Fixes some mistakes with the text of the email sent to people when they rename. (Renames: coming this code push!)
jld. None of these fixes are live yet, but they will be after this weekend's code push.Bug 3044: Tranquility III: Deep Purple by dancing_serpent
Category: Style System
Patch by:
dancing_serpentDescription: This adds a new theme, "Deep Purple", for Tranquility III. Check it out here.
Bug 2992: City field does not display for US users
Category: Misc UI/Frontend
Patch by:
jldDescription: So, one of the things we inherited from LJ was a thing where you could type in your ZIP code and it would guess at your city and state. Except it was buggy and not very accurate, and when we forked from LJ we didn't have the zip code lookup table, and and and ... far easier to just yank it all out. Which
jld did, for his first accepted patch! Welcome, jld.Bug 2812: clean up error logs
Category: Misc Backend
Patch by:
kareilaDescription: Sometimes, code is not as good as it should be, and leaves warnings -- the page will still display, and things work correctly, but there's a little "hey, fix this when you get a chance" type note in the error logs. This can clutter up the error logs and prevent noticing and diagnosing bigger problems, so
kareila has been on a mission to find the cause of all the warnings and squash them.Bug 2624: Misc. Layouts: fix position options of Navigation module
Category: Style System
Patch by:
ninetydegreesDescription: Here is where I confess that I know less than nothing about the style system, but thankfully we have people like
ninetydegrees to take care of it for me. I'm pretty sure this is a fix for a problem where the Navigation module would only display in the header of layouts, instead of where the user wanted it to be.Bug 3056: New Style: Practicality by timeasmymeasure
Category: Style System
Patch by:
ninetydegreesDescription: This adds an entirely new style to the system, called Practicality. You can see the preview here. (I love this one -- it's pretty and clean.)
Bug 2990: refactor common code in sitescheme files
Category: Modernization
Patch by:
kareilaDescription:
karzilla, Destroyer of Code, strikes again! This changes the way that the site scheme (the site layouts such as Tropospherical Red/Purple, Gradation Horizontal/Vertical, and Celerity) are coded, so that similar code isn't repeated in different files but instead is all grouped together in one file and then called from the 'child' files. This is to the benefit of developers, because it means that you only have to look for it once.Bug 3010: Stats: "Active in some way" has been frozen at 24288 since 2010-04-29
Category: Configuration
Patch by:
markDescription: As many people noticed, the old stats page had the "Active in some way" count frozen for a long time. This is because a particular nightly job wasn't running. (The new stats, which have some different sections, were correct.) We turned the job back on, and now the stats are correct.
Bug 2793: Cleaning: make all layout.pm files look the same
Category: Style System
Patch by:
ninetydegreesDescription: This (and the next one) is an epic bug that
ninetydegrees has been working on for-freaking-ever, and the sad thing is, y'all will never notice unless you're doing DW development. It basically takes all the layout files for the site's themes and styles and makes sure that everything is in the same place in all the files, every property is alphabetized, and everything is nice and tidy. It's going to make going forward so much easier.Bug 2894: Cleaning: make all themes.s2 files look the same
Category: S2 Backend
Patch by:
ninetydegreesDescription: See previous bug!
Bug 3020: In some styles, list characters overlap icon
Category: Style System
Patch by:
ninetydegreesDescription: This is a CSS fix for several styles, where if you started an entry with an ordered or unordered list, the text would overlap your icon.
Bug 3075: Template Toolkit Plugin needs a js filter
Category: Routing/TT
Patch by:
fuDescription: This adds a method for dealing with javascript to our new method of creating/displaying site pages, Template Toolkit. (We are slooooowly moving from the old style, BML, to the new style, Template Toolkit, since BML is very outdated and TT does a lot more that we need it to do. It's slow going, and we keep finding holes in what we need!)
Bug 3076: Style browser doesn't update with new styles immediately after update-db is run
Category: Site Administration
Patch by:
fuDescription: This was a problem with the system caching the old value of things, and we changed it so that new styles display immediately instead of when the cache expires.
Bug 3077: Blanket: non-squared userpics are distorted
Category: Style System
Patch by:
ninetydegreesDescription: This is a CSS fix for the Blanket layout, where userpics that weren't exactly square were being displayed weirdly.
Bug 3074: Rename email text issues
Category: Misc UI/Frontend
Patch by:
fuDescription: Fixes some mistakes with the text of the email sent to people when they rename. (Renames: coming this code push!)