![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png){kind=small}
Entry tags:
Code Tour: 9-9 to 15-9
O HAI and welcome to another exciting edition of Code Tour! I am your host, ![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
zarhooie. Today, we have 16 completed bugs, most of which are little things. There are a couple new little features though! Just remember, even though these items have been marked "RESOLVED FIXED" in our bug tracking software, they won't be live on the site until the next codepush.
I am really tired and sort of loopy, so bear with me as we enter... THE CODE TOUR ZONE. (cue music)
Bug 3017: Helper function to create URLs
Category: Misc Backend, attention to detail
Patch by:exor674
Description: This is one of those little things that makes my heart soar. This patch moves all the functions necessary to construct URLs from data into one rfunction, which can be called from anywhere, instead of re-using the same code everywhere (like, for adding ?style=mine, etc). Basically, it makes links work all the same in all places using the same code. It's such a small thing, but it is so wonderful! *pats bug*
Dre akaexor674 sez: would adding a "because the old way to do that ended up pissing Dre off one too many times" be kosher?
Yes Dre, yes it would be. Except I'm not a rabbi. Given that, we'll call it Kat-sher.
Ahem.
Bug 3039: Feed page refers to friends
Category: User documentation, Translation System Sucks
Patch by:![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
denise
Description: Due to a glitch/poor design in the system that makes the site copy (read: words of the site) show up, Denise accidentally grabbed the wrong set of words when she was changing the URL of a static page. Someone noticed it and reported it, and Denise fixed it. Yay Denise!
Bug 787: Clean up of Edit Profile page
Category: Misc UI/Frontend, improvements, a new coat ofpaint code
Patch by:kareila
Description: The edit profile page is getting a makeover with some new user interfaces and some bug fixes. I'm so excited to have an actually-functional edit profile page! YAY!
Bug 2925: Enable warnings globally on dev servers
Category: Modernization, development
Patch by:kareila
Description: This bug enables use warnings on developer servers, and is used by devs to make things go better. In short, *handwavy*.
Bug 2944: entry metadata (currents) should print in sorted field order
Category: Journal contents
Patch by:kareila
Description: This patch will make metadata display in a prettier and more sensible fashion instead of displaying every which way (aka not consistantly).
Bug 2673: No way to get the server-based creation time (logtime) through the protocol
Category: APIs: RPC/XML/Flat, voodoo, useful things
Patch by:murklins
Description: This patch allows people using our API protocol to get their hands on the server-based creation time, which could be useful if you needed to know that ever.
Bug 2958: recent comments page 'delete' doesn't disappear when deleted
Category: Misc UI/Frontend, Reported to Support
Reported by and Patch by:ninetydegrees
Description: This was a bug that came in through Support where if you deleted comments, the recent comments page still displayed the 'delete' link next to them (although they couldn't be deleted anymore).
Bug 3042: Basic Boxes: 5 themes by timeasmymeasure
Category: Style System, Shiny, DW has a magpie infestation
Patch by:sarken, with bonus fu and ninetydegrees
Description: It's a shiny new set of themes for Basic Boxes! I always want to type Basic Boxen though (THANKS BRIAN REGAN).
Bug 2879: Collapse Cut button at end of cut
Category: Journal contents, Suggestions, AWESOMESAUCE
Patch by:fu
Suggested by:hatman
Description: So you know the awesome expand-a-cut arrow that shows up next to cut tags on your rlist? Well, this patch makes there be a close-a-cut tag at the bottom of the cut text area for easy collapsing of that 4,334 word fic you opened on accident. See? AWESOMESAUCE.
Bug 2862: create FAQ on site scheme vs journal layout/style
Category: User documentation, Suggestions
Patch by: TracyMac
Suggested by:msilverstar
Description: This adds a new FAQ to our already-wonderful FAQ system about the difference between site scheme and your own personal journal's scheme/style/layout. Unlike the other bugs in this code tour, this one is actually live on the site! Check it out here.
Bug 2892: remove gratuitous shifts from Comment.pm
Category: Misc Backend
Patch by:kareila
Description: There were some extra shifts in places where shifts don't belong. In the course of clean-up, Kar removed the extra shifts and donated them to the Home for the Shiftless Shifts, where they will get lessons in how to be in the proper places.
Bug 2991: shop-creditcard-charge worker has dw-private header
Category: Payments
Patch by:kareila with an assist from denise for policy
Description: What happened here was the flag that gets put on Dreamwidth-Only code accidentally got put on some code that isn't supposed to be Dreamwidth-Only. Oops!
Bug 1401: "random userpic" option on comments & posts
Category: Misc UI/Frontend, AWESOMESAUCE
Patch by:yvi
Description: So you know how you can hit the "Random Icon" button on entries and it will pick, um, a random icon for you? This patch adds that feature to comments too!
Bug 3033: Unbreak editing comments with deleted parents
Category: Journal contents, codemerge, it's the little things that count
Patch by: written by![[livejournal.com profile]](https://www.dreamwidth.org/img/external/lj-userinfo.gif)
andy and adapted for use on Dreamwidth by yvi
Description: Ok, so if User A commented on a post and User B replied to User A, User B could edit their comment. If User A deleted their comment after User B replied, User B would have issues editing that comment. This codemerge from LiveJournal fixes that behavior.
Bug 3048: Make BML play nice with perl profilers
Category: Misc Backend, The Mysteries of Code
Patch by:exor674
Description: This is a purely code bug and is complicated. It is so complicated that I had to poll IRC to figure out what in the world it is doing. Here's what we came up with:
denise: A side-note that it's one of Dre's bugs and therefore nobody understands it unless they are a Level 50 Perl Programmer ;)
exor674: It's something that makes other developers lives easier. it's magic *g*
zarhooie: VOODOO CODE NEEDS MORE PINS.
gchick: IT FIXES EVERYTHING. How's that?
Dre andsophie finally provided me with the actual bug-fixing-ness description: "It has to do with BML not playing nice with other things that can be used in development. DW code likes to have its eval warnings be informative, so it tells Perl that. Perl profilers, on the other hand, like to do things like turn on debugging. The way it was before meant that DW's decision overrode that of the profiler. This makes it so that they can BOTH have cookies."
Mmmm... cookies.
Bug 3041: Basic Boxes: bottomcomment text is unreadable in several themes
Category: Style System
Patch by:ninetydegrees
Description: There was a bug in some BasicBoxen Boxes themes that caused the some comment text to be unreadable. The fab ninetydegrees fixed it so now it's seeable.
That's it for this week. Thank you SO much to all our developers, especiallymurklins, who has patch #1 for Dreamwidth in this week's Code Tour. Three cheers!
This has been your weekly Code Tour. See you next time, same code time, same code place.
Tiredly,
Kat
zarhooie. Today, we have 16 completed bugs, most of which are little things. There are a couple new little features though! Just remember, even though these items have been marked "RESOLVED FIXED" in our bug tracking software, they won't be live on the site until the next codepush.I am really tired and sort of loopy, so bear with me as we enter... THE CODE TOUR ZONE. (cue music)
Bug 3017: Helper function to create URLs
Category: Misc Backend, attention to detail
Patch by:
exor674Description: This is one of those little things that makes my heart soar. This patch moves all the functions necessary to construct URLs from data into one rfunction, which can be called from anywhere, instead of re-using the same code everywhere (like, for adding ?style=mine, etc). Basically, it makes links work all the same in all places using the same code. It's such a small thing, but it is so wonderful! *pats bug*
Dre aka
exor674 sez: would adding a "because the old way to do that ended up pissing Dre off one too many times" be kosher?Yes Dre, yes it would be. Except I'm not a rabbi. Given that, we'll call it Kat-sher.
Ahem.
Bug 3039: Feed page refers to friends
Category: User documentation, Translation System Sucks
Patch by:
deniseDescription: Due to a glitch/poor design in the system that makes the site copy (read: words of the site) show up, Denise accidentally grabbed the wrong set of words when she was changing the URL of a static page. Someone noticed it and reported it, and Denise fixed it. Yay Denise!
Bug 787: Clean up of Edit Profile page
Category: Misc UI/Frontend, improvements, a new coat of
Patch by:
kareilaDescription: The edit profile page is getting a makeover with some new user interfaces and some bug fixes. I'm so excited to have an actually-functional edit profile page! YAY!
Bug 2925: Enable warnings globally on dev servers
Category: Modernization, development
Patch by:
kareilaDescription: This bug enables use warnings on developer servers, and is used by devs to make things go better. In short, *handwavy*.
Bug 2944: entry metadata (currents) should print in sorted field order
Category: Journal contents
Patch by:
kareilaDescription: This patch will make metadata display in a prettier and more sensible fashion instead of displaying every which way (aka not consistantly).
Bug 2673: No way to get the server-based creation time (logtime) through the protocol
Category: APIs: RPC/XML/Flat, voodoo, useful things
Patch by:
murklinsDescription: This patch allows people using our API protocol to get their hands on the server-based creation time, which could be useful if you needed to know that ever.
Bug 2958: recent comments page 'delete' doesn't disappear when deleted
Category: Misc UI/Frontend, Reported to Support
Reported by and Patch by:
ninetydegreesDescription: This was a bug that came in through Support where if you deleted comments, the recent comments page still displayed the 'delete' link next to them (although they couldn't be deleted anymore).
Bug 3042: Basic Boxes: 5 themes by timeasmymeasure
Category: Style System, Shiny, DW has a magpie infestation
Patch by:
sarken, with bonus fu and ninetydegreesDescription: It's a shiny new set of themes for Basic Boxes! I always want to type Basic Boxen though (THANKS BRIAN REGAN).
Bug 2879: Collapse Cut button at end of cut
Category: Journal contents, Suggestions, AWESOMESAUCE
Patch by:
fuSuggested by:
hatmanDescription: So you know the awesome expand-a-cut arrow that shows up next to cut tags on your rlist? Well, this patch makes there be a close-a-cut tag at the bottom of the cut text area for easy collapsing of that 4,334 word fic you opened on accident. See? AWESOMESAUCE.
Bug 2862: create FAQ on site scheme vs journal layout/style
Category: User documentation, Suggestions
Patch by: TracyMac
Suggested by:
msilverstarDescription: This adds a new FAQ to our already-wonderful FAQ system about the difference between site scheme and your own personal journal's scheme/style/layout. Unlike the other bugs in this code tour, this one is actually live on the site! Check it out here.
Bug 2892: remove gratuitous shifts from Comment.pm
Category: Misc Backend
Patch by:
kareilaDescription: There were some extra shifts in places where shifts don't belong. In the course of clean-up, Kar removed the extra shifts and donated them to the Home for the Shiftless Shifts, where they will get lessons in how to be in the proper places.
Bug 2991: shop-creditcard-charge worker has dw-private header
Category: Payments
Patch by:
kareila with an assist from denise for policyDescription: What happened here was the flag that gets put on Dreamwidth-Only code accidentally got put on some code that isn't supposed to be Dreamwidth-Only. Oops!
Bug 1401: "random userpic" option on comments & posts
Category: Misc UI/Frontend, AWESOMESAUCE
Patch by:
yviDescription: So you know how you can hit the "Random Icon" button on entries and it will pick, um, a random icon for you? This patch adds that feature to comments too!
Bug 3033: Unbreak editing comments with deleted parents
Category: Journal contents, codemerge, it's the little things that count
Patch by: written by
andy and adapted for use on Dreamwidth by yviDescription: Ok, so if User A commented on a post and User B replied to User A, User B could edit their comment. If User A deleted their comment after User B replied, User B would have issues editing that comment. This codemerge from LiveJournal fixes that behavior.
Bug 3048: Make BML play nice with perl profilers
Category: Misc Backend, The Mysteries of Code
Patch by:
exor674Description: This is a purely code bug and is complicated. It is so complicated that I had to poll IRC to figure out what in the world it is doing. Here's what we came up with:
denise: A side-note that it's one of Dre's bugs and therefore nobody understands it unless they are a Level 50 Perl Programmer ;)exor674: It's something that makes other developers lives easier. it's magic *g*zarhooie: VOODOO CODE NEEDS MORE PINS.gchick: IT FIXES EVERYTHING. How's that?Dre and
sophie finally provided me with the actual bug-fixing-ness description: "It has to do with BML not playing nice with other things that can be used in development. DW code likes to have its eval warnings be informative, so it tells Perl that. Perl profilers, on the other hand, like to do things like turn on debugging. The way it was before meant that DW's decision overrode that of the profiler. This makes it so that they can BOTH have cookies."Mmmm... cookies.
Bug 3041: Basic Boxes: bottomcomment text is unreadable in several themes
Category: Style System
Patch by:
ninetydegreesDescription: There was a bug in some Basic
ninetydegrees fixed it so now it's seeable.That's it for this week. Thank you SO much to all our developers, especially
murklins, who has patch #1 for Dreamwidth in this week's Code Tour. Three cheers!This has been your weekly Code Tour. See you next time, same code time, same code place.
Tiredly,
Kat