Code tour, 2010 July 14 to 2010 July 22

[azurelunatic]

The way we keep treating Monday, eventually these things will roll around to actual-Monday once again. While the entirety of the staff is at OSCON learning new and interesting things and occasionally singing, and some of my friends are living it up at the San Diego Comic-Con, the show must go on here at the website! (Well, in between giddy shrieking about Perl and the MythBusters.)


We have 25 resolved bugs this week. This code tour welcomes new developer sarken, who has two resolved bugs to their credit, with 5 themes. kareila and ninetydegrees have tied for most bugs resolved, with six each. dancing_serpent has 4, fu 3, and allen, exor674, liv, and scamper with one each.

There's a glorious bounty of new themes as well: in addition to sarken's, there are also 9 themes from busaikko, 6 from timeasmymeasure, and one from dancing_serpent.

Thanks also to the other people who have assisted, including but not limited to: mark, afuna, ninetydegrees, exor674, zvi, rivkat, denise, sophie, kareila, Rebecca Harlow, Support, the dw_news commenters, and the IRC regulars who look at me weird and tell me to get back to the code tour when I run in screaming about Adam Savage brandishing a pair of hilarious underwear.


With a few exceptions (one only relevant to developers, and one as part of a previously-pushed patch), none of this is live yet. Code pushes are announced in dw_maintenance, and instant offsite updates are always on @Dreamwidth and @dw_alerts.

Bugs and other patches:

Bug 2777: error in DW::Worker::DistributeInvites
Category: Invite codes, fixing what's broke
Patch by: kareila
Description: denise realized that it was probably time to issue some more invite codes. Shortly thereafter, it was bug-filing time: invite codes hadn't been distributed because something broke. On a huge site like LiveJournal, you can't do something like distribute invite codes to all active users real-time; you've got to do it bit by bit in all the nooks and crannies of when the system isn't busy, and we inherited that part of the system. The means by which this was done depended on something that ... actually didn't exist as of a recent upgrade to our database software. Woops. Since we're small enough to get away with it, the DELAYED bit was taken out ... at least for now.

Bug 2791: dw-free branch cleanup
Category: Site Administration, Mercurial
Patch by: kareila
Description: Dreamwidth uses a tool called Mercurial to manage its code for the live site. kareila explains: "The branch system hasn't been used effectively and causes problems whenever cloning a new copy of the repository, so I'm reverting to using the default branch for all development. There shouldn't be any user facing changes from this, except for one change to bootstrap.pl." This change is already live, but should only affect developers. If you are a developer having problems, you can inquire in dw_dev.

Bug 1813: Official styles should support placing icon right or left on entries and comments
Category: Style System
Patch by: ninetydegrees
Description: Ever met a style that would have been perfect, except you wanted the icon on the other side? Soon you can reunite yourself with that now-perfect style.

Bug 67: Add notification: "new top-level comment to entry"
Category: Misc UI/Frontend, comments, notifications
Patch by: fu
Description: Sometimes, when you want notifications for comments somewhere, you realize that you want to hear about new top-level comments to the entry only, and if any specific thread interests you, you can subscribe to that thread individually. Perfect for in-depth technical discussions with a technicolor bikeshed in one thread, or that very interesting comment-fic meme.

Bug 1547: wrap recaptcha calls in LJ::Captcha
Category: Modernization, fetch the code-machetes, refactoring is fun for the whole family
Patch by: fu
Description: At first, it looked like an old CAPTCHA module inherited from LiveJournal could be completely torn out, since Dreamwidth uses reCAPTCHA for its CAPTCHA needs. But then it transpired that actually, there was all this duplicate code lying around... End result, there's a shiny little module that looks like it evolved from the old logic. fu: "... the only place that cares that we use recaptcha should be DW::Captcha itself."

Bug 2147: Ability to see which entries have been crossposted
Category: Journal contents, crossposting, bugs that resolve other bugs are good
Patch by: allen
Description: When looking through your entries, it's nice to be able to see quickly which entry has been crossposted and which entry hasn't. The (already live) patch that displays the crosspost link in the entry's metadata accomplishes this tidily.

Bug 2785: Routing test cleanup ( for later things )
Category: Routing/TT, backend
Patch by: exor674
Description: This is one of those little backend patches that will make some future developer's life easier weeks, months, or years on down the line when dealing with routing tests.

Bug 1054: Links in OpenID comments render inconsistently on site vs. notifications
Category: Inbox/Notifications, general consistency
Patch by: kareila
Description: When anonymous and unverified OpenID users leave links in comments, they're rendered in plain text to reduce the chance of spam. Yet they were being sent out in notifications as the original unaltered HTML. This will send them out as text, just as they are rendered in the displayed comment; if your email client turns them to clickable links in your inbox, that's your email client's issue, rather than Dreamwidth's. :D

Bug 2657: migrate LJ::set_userprop to $u->set_prop
Category: Modernization, we're not LJ, backend
Patch by: kareila
Description: A routine adventure in updating the code got interesting. Head-pounding details ensued.

Bug 2784: Find Similar Interests tool dies when user logged out
Category: Misc UI/Frontend, interests, making things make sense
Patch by: kareila
Description: It's a bit hard to find a user who has interests similar to yours when you've been logged out. This results in an actual error, instead of just silent death because the one part isn't talking to the other part that holds the error.

Bug 2805: fix or remove LJ::Jabber::LastSeen
Category: Misc Backend, fetch the code-machetes, we're not LJ
Patch by: kareila
Description: An inherited bit of code that was supposed to show whether or not someone was online with the locally-hosted Jabber server had been disabled and was also broken. Since if we want to host a Jabber server, we'll want to re-do this, out it went.

Bug 824: Add additional classes to Page::print_wrapper_start
Category: Style System, making things make sense
Patch by: liv
Description: It would really be nice if the style system knew whether the person viewing the page was logged in, the journal owner, a community administrator or moderator, a person with access to the entry, and so forth.

Bug 2636: Sunday Morning: implement one-column and two-columns-right layout
Category: Style System
Patch by: ninetydegrees
Description: "Sunday Morning currently only allows two-cols-left. Implementing one-column and two-cols-right shouldn't be hard," said ninetydegrees. Famous last words. But it's done now!

Bug 2788: custom reply/# of comments text messed up on network page
Category: Style System, making things make sense
Patch by: ninetydegrees
Description: When reading one's Network page, it would make sense to have the text showing you the number of comments consistent with your Reading page, wouldn't it? Instead of the text from your own journal?

Bug 2790: Sunday Morning navigation module wraps poorly
Category: Style System, fixing what's broke
Patch by: ninetydegrees
Description: You've got such a lovely style. It would be a shame if one of the links should ... stack right on top of another link, eh?

Bug 2793: Cleaning: make all layout.pm files look the same
Category: Style System, making things make sense
Patch by: ninetydegrees
Description: Every now and then, someone goes through the files that are supposed to be laid out the same and makes sure that they are, indeed, laid out the same, with the same line spacing and so forth.

Bug 2795: Bases: fix author's name
Category: Style System, credit where credit's due, making things make sense
Patch by: ninetydegrees
Description: Making sure the style author's name shows up properly. Also, alphabetizing things, as a bonus.

Bug 2779: Skittlish Dreams metadata hardcoded to red
Category: Style System, fixing what's broke
Patch by: first-time committer sarken
Description: In an oversight, it was impossible to change the color of the metadata for Skittlish Dreams themes without resorting to user-entered CSS, because there was some red hard-coded in the theme.

Bug 1059: redirect shop.dreamwidth.org to dreamwidth.org/shop/
Category: Configuration, making things make sense
Patch by: scamper
Description: If a user happens to visit http://shop.dreamwidth.org/, they will start being sent to http://www.dreamwidth.org/shop/; they will also wind up at http://www.dreamwidth.org/mobile/ from http://mobile.dreamwidth.org/

Bug 2797: jQuery library needs updating to latest version
Category: Modernization
Patch by: fu
Description: Dreamwidth uses jQuery, a JavaScript library to help keep the JavaScript use on the site as nice as possible. Occasionally, this needs updating.

New Themes:

Bug 2762: Bases: 2 new themes by timeasmymeasure
Category: Style System, pretty shiny themes
Patch by: dancing_serpent
Description: Two new themes for Bases:

Comfort:


Velvet Steel:



Bug 2763: Drifting: 4 new themes by timeasmymeasure
Category: Style System, pretty shiny themes
Patch by: dancing_serpent
Description: Four new themes for Drifting:

Comfort Zone:


Desert Me:


Sweet Possibilities:


Winter Clarity:



Bug 2778: Theme: Mandala (ColorSide)
Category: Style System, pretty shiny themes
Patch and theme by: dancing_serpent
Description: New theme, Mandala, for ColorSide:


A larger look at the mandala.


Bug 2783: Negatives: 9 themes from busaikko
Category: Style System, pretty shiny themes
Patch by: dancing_serpent
Description: New themes for Negatives:

Autumn:


Bridal Bouquet:


Corporate Embrace:


Easy Reader:


Evening:


Spring:


Summer:


Winter:


Yo-zakura:



Bug 2761: Skittlish Dreams: 5 new themes by sarken
Category: Style System, pretty shiny themes
Patch by: sarken
Description: 5 themes for Skittlish Dreams:

Academy:


Desert Cream:


In the Bag:


Like Sunshine:


Snow Cherries:

Comments

[timeasmymeasure]

Thanks for the handy tour :)

Official styles should support placing icon right or left on entries and comments

Oh, this is absolutely exciting!

[azurelunatic]

And bonus, there is a code push tonight, so it may already be live now.

[denise]

Not quite yet, but soon!

[timeasmymeasure]

Soon is good =D

[(Anonymous)]

From bug 1059:

"they will also wind up at http://www.dreamwidth.org/mobile/ from http://mobile.dreamwidth.org/"

Could m.dreamwidth.org also redirect to www.dreamwidth.org/mobile/?

[denise]

Opening a bug for that; ta!