Azure Jane Lunatic (Azz) 🌺 (![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
azurelunatic) wrote in ![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png)
dw_dev2010-07-13 09:33 pm
azurelunatic) wrote in dw_dev2010-07-13 09:33 pm
Entry tags:
Code tour, 2010 July 07 to 2010 July 13
After a refreshing week off, I return to bring this week's code tour! I am greatly looking forward to meeting fu in person later this week, and introducing her to some of our local farmers' markets ... and a road trip!
This week's resolved bugs: 5 (or 6) fromkareila, 2 from fu, 1 and a preview by ninetydegrees, and one each from deborah, foxfirefey, allen, and dancing_serpent. That's 13 resolved: 12 code improvements/bugfixes, and one new theme.
Also of note: Code review and assistance fromfu and exor674, troubleshooting and assistance from ninetydegrees, katieastrophe, wychwood, yvi, zarhooie, and ![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
denise; troubleshooting and helping connect Support to the devs from domtheknight, the dw_suggestions crowd (starring tim this week), and everyone else helping review code, report bugs, cheer, and keep an eye out for trouble before it causes serious problems.
Again, the contents of this code tour won't be live until the next code push. Seedw_maintenance for advance notice of scheduling, and @dreamwidth for up-to-the-minute information if the server has decided to go Lemon Wacky Hello (warning: tvtropes).
Bug 2092: allow premium-paid users to buy regular paid time within window of expiration
Category: Registration, paid accounts
Patch by:fu
Description: A fun fact of life in any system where people pay for stuff is that people will try to get the best possible deal for their money. This sometimes includes stuff that the owners would call "gaming the system". The previous solution was to just not allow premium-paid users to buy (lower-level) regular paid time until their premium-paid time had expired. It took a bit of doing and a bit of overthinking. This will make it possible for them to buy regular paid time within two weeks of their expiration.
Bug 2757: comment count incorrect in summary module for disabled comments
Category: Journal contents, security funtimes, comments
Patch by:kareila
Description: Some styles have a summary module that show various things about the entries on the page. It turns out that when someone disabled comments to an entry, that the count of the comments on that entry still showed up -- which might have been OK had it not been to people who weren't the journal owner. This took a front-end fix so it would stop displaying, and a back-end fix so that wild horses couldn't drag the number out of the system another way.
Bug 930: Need to go over tag cloud for semantics/accessibility
Category: Style System, tag display, less accessibility fail
Patch by:deborah
Description: Most of us are familiar with the concept of a tag cloud, right? Cluster of words or phrases on the page, each word linking to a generated list of entries in the blog that have been labeled with that tag. There are a couple ways to tweak the display of the tag cloud so that it sucks less from an accessibility standpoint -- less inline styling, making any font sizing relative, having printable characters surrounded by spaces between adjacent links. This makes things better.
Bug 2768: Theme: Nightfall (Nouveau Oleanders)
Category: Style System, shiny new themes
Patch by:dancing_serpent, preview by ninetydegrees
Description: New theme for Nouveau Oleanders:
Bug 1207: Investigate using cgi-bin/imageconf.pl instead of scattering image URLs all over the place
Category: Misc Backend, making things make sense
Patch and epic code-trawling by:kareila
Description: When displaying system images, like the little user head graphics, poll images and the like, stuff was scattered all over. This tidies things up and makes it centralized to help make sure that if there's ever another update to all the site images, it's going to be as painless as possible. (This will help sites downstream of us, in case they want different images.) This looked like a TON of work.
Bug 2536: formatting preferences lost post-subscription
Category: Misc UI/Frontend, fixing what's broke, making things make sense
Patch by:kareila
Description: So you've got ?style=mine turned on, and you go to subscribe to comments to this entry you're viewing. When you're returned to the entry after successfully subscribing, the ?style=mine gets lost, which is just a shame.
Bug 751: public but unspecified location display
Category: Misc UI/Frontend, fixing what's broke, harmless but obnoxious
Patch by: Possiblykareila Yay! Troubleshooting from domtheknight, katieastrophe, wychwood, yvi, zarhooie, and denise.
Description: When someone had their location left public on the profile, but didn't list a specific location, either by declining to list a location at all, or by not listing a state/province/etc., "(states/regions/territories)" would display on their profile. Although the effects were obvious, duplicating it was tricky, and fixing it happened as the result of another bug.
Bug 2753: ?replyto pages don't use local timezone
Category: Journal contents, comments, general consistency
Patch by:fu
Description: The ?replyto page was (usually) showing a different time for a comment than was actually on the entry page. It was the UTC time, rather than the local time.
Bug 2138: Friendlier error message when a logged-in user tries to load an inaccessible entry
Category: Misc UI/Frontend, making things make sense
Patch by:allen, suggestion by tim, enthusiastically seconded by just about everybody
Description: Every now and then one runs bang into a locked entry -- while logged out or logged in. If logged out, one would of course want to sign in. If logged in -- if a person happens to have multiple accounts, sometimes the entry in question is accessible to one account but not another. Either way, it's good to have a way to log in (with a regular account or OpenID), or to switch to another account, or to join the community if it's a community with open membership.
Bug 2756: change modify_caps from LJ function to user method
Category: Modernization, we're not LJ, Miscellaneous backend
Patch by:kareila
Description: Moving backend stuff from old methods inherited from LJ to the new version.
Bug 2765: sitefeeds layout should be is_internal
Category: S2 Backend
Patch by:ninetydegrees
Description: The minimalist style for feeds isn't intended to be used by actual users, so it's been marked as internal.
Bug 2775: FOAF points to itself
Category: APIs (RPC, XML, Flat), fixing what's broke, syndicated feeds (incoming)
Patch by:foxfirefey
Description: The FOAF file for feed accounts had a bit that was supposed to point to the feed source, but was pointing at the feed account's FOAF file, not to the feed source. (In case you got lost there, FOAF, "Friend of a Friend", is a standardized format for building a file with basic information about any given internet user on any service, and showing who they list as their friends, et cetera. It was broken and it got fixed.)
Bug 2764: OPML has the case wrong: xmlUrl, not xmlURL
Category: APIs (RPC, XML, Flat), fixing what's broke, syndicated feeds (outgoing)
Patch by:kareila
Description: Dreamwidth (and LJ, and other LJ-descended sites) has an easy way to give your reading list/friends page to your feed reader that accepts OMPL files:
http://www.dreamwidth.org/tools/opml
Some feed readers are stricter than others, and only take the proper capitalization of "xmlUrl". Two incorrectly capital letters can ruin someone's whole day.
fu in person later this week, and introducing her to some of our local farmers' markets ... and a road trip! This week's resolved bugs: 5 (or 6) from
kareila, 2 from fu, 1 and a preview by ninetydegrees, and one each from deborah, foxfirefey, allen, and dancing_serpent. That's 13 resolved: 12 code improvements/bugfixes, and one new theme. Also of note: Code review and assistance from
fu and exor674, troubleshooting and assistance from ninetydegrees, katieastrophe, wychwood, yvi, zarhooie, and denise; troubleshooting and helping connect Support to the devs from domtheknight, the dw_suggestions crowd (starring tim this week), and everyone else helping review code, report bugs, cheer, and keep an eye out for trouble before it causes serious problems. Again, the contents of this code tour won't be live until the next code push. See
dw_maintenance for advance notice of scheduling, and @dreamwidth for up-to-the-minute information if the server has decided to go Lemon Wacky Hello (warning: tvtropes). Bug 2092: allow premium-paid users to buy regular paid time within window of expiration
Category: Registration, paid accounts
Patch by:
fuDescription: A fun fact of life in any system where people pay for stuff is that people will try to get the best possible deal for their money. This sometimes includes stuff that the owners would call "gaming the system". The previous solution was to just not allow premium-paid users to buy (lower-level) regular paid time until their premium-paid time had expired. It took a bit of doing and a bit of overthinking. This will make it possible for them to buy regular paid time within two weeks of their expiration.
Bug 2757: comment count incorrect in summary module for disabled comments
Category: Journal contents, security funtimes, comments
Patch by:
kareilaDescription: Some styles have a summary module that show various things about the entries on the page. It turns out that when someone disabled comments to an entry, that the count of the comments on that entry still showed up -- which might have been OK had it not been to people who weren't the journal owner. This took a front-end fix so it would stop displaying, and a back-end fix so that wild horses couldn't drag the number out of the system another way.
Bug 930: Need to go over tag cloud for semantics/accessibility
Category: Style System, tag display, less accessibility fail
Patch by:
deborahDescription: Most of us are familiar with the concept of a tag cloud, right? Cluster of words or phrases on the page, each word linking to a generated list of entries in the blog that have been labeled with that tag. There are a couple ways to tweak the display of the tag cloud so that it sucks less from an accessibility standpoint -- less inline styling, making any font sizing relative, having printable characters surrounded by spaces between adjacent links. This makes things better.
Bug 2768: Theme: Nightfall (Nouveau Oleanders)
Category: Style System, shiny new themes
Patch by:
dancing_serpent, preview by ninetydegreesDescription: New theme for Nouveau Oleanders:
Bug 1207: Investigate using cgi-bin/imageconf.pl instead of scattering image URLs all over the place
Category: Misc Backend, making things make sense
Patch and epic code-trawling by:
kareilaDescription: When displaying system images, like the little user head graphics, poll images and the like, stuff was scattered all over. This tidies things up and makes it centralized to help make sure that if there's ever another update to all the site images, it's going to be as painless as possible. (This will help sites downstream of us, in case they want different images.) This looked like a TON of work.
Bug 2536: formatting preferences lost post-subscription
Category: Misc UI/Frontend, fixing what's broke, making things make sense
Patch by:
kareilaDescription: So you've got ?style=mine turned on, and you go to subscribe to comments to this entry you're viewing. When you're returned to the entry after successfully subscribing, the ?style=mine gets lost, which is just a shame.
Bug 751: public but unspecified location display
Category: Misc UI/Frontend, fixing what's broke, harmless but obnoxious
Patch by: Possibly
kareila Yay! Troubleshooting from domtheknight, katieastrophe, wychwood, yvi, zarhooie, and denise. Description: When someone had their location left public on the profile, but didn't list a specific location, either by declining to list a location at all, or by not listing a state/province/etc., "(states/regions/territories)" would display on their profile. Although the effects were obvious, duplicating it was tricky, and fixing it happened as the result of another bug.
Bug 2753: ?replyto pages don't use local timezone
Category: Journal contents, comments, general consistency
Patch by:
fuDescription: The ?replyto page was (usually) showing a different time for a comment than was actually on the entry page. It was the UTC time, rather than the local time.
Bug 2138: Friendlier error message when a logged-in user tries to load an inaccessible entry
Category: Misc UI/Frontend, making things make sense
Patch by:
allen, suggestion by tim, enthusiastically seconded by just about everybodyDescription: Every now and then one runs bang into a locked entry -- while logged out or logged in. If logged out, one would of course want to sign in. If logged in -- if a person happens to have multiple accounts, sometimes the entry in question is accessible to one account but not another. Either way, it's good to have a way to log in (with a regular account or OpenID), or to switch to another account, or to join the community if it's a community with open membership.
Bug 2756: change modify_caps from LJ function to user method
Category: Modernization, we're not LJ, Miscellaneous backend
Patch by:
kareilaDescription: Moving backend stuff from old methods inherited from LJ to the new version.
Bug 2765: sitefeeds layout should be is_internal
Category: S2 Backend
Patch by:
ninetydegreesDescription: The minimalist style for feeds isn't intended to be used by actual users, so it's been marked as internal.
Bug 2775: FOAF points to itself
Category: APIs (RPC, XML, Flat), fixing what's broke, syndicated feeds (incoming)
Patch by:
foxfirefeyDescription: The FOAF file for feed accounts had a bit that was supposed to point to the feed source, but was pointing at the feed account's FOAF file, not to the feed source. (In case you got lost there, FOAF, "Friend of a Friend", is a standardized format for building a file with basic information about any given internet user on any service, and showing who they list as their friends, et cetera. It was broken and it got fixed.)
Bug 2764: OPML has the case wrong: xmlUrl, not xmlURL
Category: APIs (RPC, XML, Flat), fixing what's broke, syndicated feeds (outgoing)
Patch by:
kareilaDescription: Dreamwidth (and LJ, and other LJ-descended sites) has an easy way to give your reading list/friends page to your feed reader that accepts OMPL files:
http://www.dreamwidth.org/tools/opml
Some feed readers are stricter than others, and only take the proper capitalization of "xmlUrl". Two incorrectly capital letters can ruin someone's whole day.