Entry tags:
Code Tour, 4/27 - 5/11
Good code tour day, all! This week has been busy: we resolved 38 bugs, thanks especially to ![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
mark's awesome efforts at going through the review queue.
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
yvi, ninetydegrees, and mark totally rocked zilla, with nine, eight, and seven bugs resolved respectively. Much love and thanks to all our contributors this week: ninetydegrees, allen, denise, exor674, fu, kareila, mark, mayank, sophie, yvi. We have some great fixes for you all; some of these are already live, and some will be available by the next code push.
Bug 2576: Makes the default site scheme stick if user has chosen a different one
Category: Misc UI/Frontend
Patch by:exor674
Description: There was an issue which prevented someone who'd selected a different site scheme from switching back to Tropospherical Red. This fixes that.
Bug 2423: Implement new payment system
Category: Site Administration, Shameless Money-Grubbing
Patch by:mark
Description: New payment system, yay! The bulk of the work had been done earlier, but this was left open for the version 2.0 fixes (which included transfer of points). There are still things that can be tweaked, but those can all go into new bugs!
Bug 2568: Replying to entries in sitescheme gives error
Category: Misc UI/Frontend, No Bug for You Dreamwidth
Patch by:yvi
Description: This was a bug where you'd get an error if you tried to reply to an entry on a site-scheme page. We caught this in beta, so no one actually ran into this problem on Dreamwidth. (Yay testing!)
Bug 2321: Support Google Checkout
Category: Misc Backend
Patch by:mark
Description: Oh GCO *sigh* This was the bug where we implemented the shortlived GCO support. Dreamwidth no longer supports GCO, but the code is still available for clone sites who might need it.
Bug 2554: %%url%% only substituted once in crossposting footer preview
Category: Crossposter, What You See Should Be What You Get
Patch by:allen
Description: If you had multiple %%url%% in your crosspost, the preview only worked correctly for the first one. The text that was actually crossposted did work correctly. This makes the behavior of the preview consistent with the actual crossposted text.
Bug 2146: Custom security filters on reading pages
Category: Journal contents, More Ways to Filter Entries
Patch by:exor674
Description: You know how, if you're a paid user, you can do http://exampleusername.dreamwidth.org?security=access/private/public to see all entries with that security on a journal? (Assuming that you could view those entries in the first place!). Well now you can also do http://yourusername.dreamwidth.org/read/?security=access/public/private and see only entries with a particular security -- "private" will also show you admin-locked entries to communities. (This only makes sense on your own read page since you can't see locked entries on other people's read pages).
Bug 2446: Add cookie support to DW::Request
Category: Misc Backend, Modernization, Making Future Coders Happy
Patch by:exor674
Description: We modernized how we implement cookies. Lots of work, to make it easier for us to tweak things without breaking them, in the future!
Bug 2250: Misc BML cleanup
Category: Misc Backend, Making Future Coders Happy
Patch by:mark
Description: Code cleanup! This bug has been hanging around a while -- basically, it's for removing those unused BML files or things that we don't need anymore. Closed, since I think we got all that we might want to for now; we can always open a new one in case more files become obsolete in the future.
Bug 2274: expire carts after 30 days
Category: Site Administration
Patch by:mark
Description: Cart cleanup! If you'd created a cart before, it would hang around forever. So sometimes you might see stuff in your cart that's six months old, gathering mold and ewwww. This makes it so that unchecked-out carts are only valid for thirty days.
Bug 2489: moveucluster framework + purger needs updating
Category: Misc Backend, Oops I Guess We Needed to Update That
Patch by:mark
Description: Updates the scripts that move users from one cluster to another, and that purge deleted users, because they no longer worked with all the changes that we had done to the Dreamwidth code.
Bug 2573: shop points transfer page
Category: Misc Backend, Sharing the Love, Shameless Money-Grubbing
Patch by:mark
Description: You can transfer points from your stash to another user. (Need I say more?)
Bug 2049: Skittlish Dreams: modules incorrectly displayed when moved to footer or header
Category: Style System
Patch by:ninetydegrees
Description: Some modules in Skittlish Dreams look horrible when you move them to either the footer or the hedaer. This makes it so that navlinks can't be put in the footer, and poweredby and time can't be moved to the header.
Bug 2072: Transmogrified: modules incorrectly displayed when moved to header
Category: Style System
Patch by:ninetydegrees
Description: Some modules in Transmogrified look horrible when you move them to the header or footer. This tweaks the CSS so that the module contents look okay no matter where you put them.
Bug 2549: split out tropo css better
Category: Frontend, Making Future Coders Happy
Patch by:ninetydegrees
Description: Code cleanup! Tropospherical Red and Tropospherical Purple are basically the same except for the colors, but have a lot of code duplicated between them. This cleans up the code so that when we need to tweak something, we only need to change it in one place, rather than editing multiple files. Less duplication == less chance of overlooking something when editing one scheme == less work for us. All good.
Bug 2569: htdocs/community/pending.bml uses [[link]] instead of [[aopts]] for "Return to the list" link
Category: Communities
Patch by:ninetydegrees
Description: There was some miscommunication within the translation system. This fixes that.
Bug 2267: add link back to comment & parent on ?replyto=foo in sitescheme
Category: Misc UI/Frontend, Context is Good; Convenience is Good, Links are Good
Patch by:yvi
Description: On sitescheme reply pages, there were no links back to the original context. This adds links to the comment, the parent, and the start of the thread, because they're useful.
Bug 2563: Comment action links on S2 reply pages don't pass style=mine
Category: Style System, Context is Good; Convenience is Good, Links are Good
Patch by:yvi
Description: When using style=mine and viewing a reply page in S2, the various comment links didn't carry over the style=mine. This adds style=mine to the links, to be consistent.
Bug 1096: show=P, etc not always displaying the current view for the navstrip on the read page
Category: Misc UI/Frontend, What You See Should Be What You Get
Patch by:fu
Description: The dropdown in the navstrip lets you choose to show only personal journals, only communities, or only feeds, and the dropdown should reflect whether one of these filters have been chosen. However, in some cases the dropdown was not accurate. Fixed now!
Bug 1579: Warning for Bad Markup
Category: Journal contents, No Bad Code for You
Patch by:fu
Description: Previously, we'd made it so that entries with bad markup would be hidden behind a cut, so that you wouldn't see them on your read page. Now we're taking it one step further, and warn you after you post or edit an entry which contains bad markup, so that you'll be aware of it and fix your entry as soon as possible.
Bug 1757: new community setting: Entry's author and maintainers may add existing tags to an entry
Category: Tags, Community Management
Patch by:fu
Description: Communities can allow the entry's author to tag their own entries, in addition to community administrators, as a middle ground between putting all the burden of handling tags to admins, and opening up tagging to all members in the community.
Bug 1433: sort alpha by keyword on allpics/editpics page
Category: Misc UI/Frontend, A little sorting goes a long way
Patch by:allen
Description: Icons are now sortable by either upload order (the default), or by keyword order. Sorting by keywords on your /icons page makes the icon show up multiple times, once for each keyword. Sorting by keywords on your /editicons page sorts by the very first keyword.
Bug 2361: Links to cross-posted entries
Category: Crossposter, Links are Good
Patch by:allen
Description: This automatically creates links from your entry on Dreamwidth to your crossposted entries. It's a per-account option (so you can choose to link to some, but not all, places you crosspost to). Go to your crosspost settings, and edit each account to "Display Cross Post Links". It will show up for any entry that you post or edit, after you check the checkbox, but not for anything before that. This is disabled by default so we don't spring surprises on you.
Bug 1852: Useful title for Layer Source Page
Category: Style System
Patch by:exor674
Description: This adds the layer's name to the title of the syntax-highlighted layer source, which is useful!
Bug 2605: don't send payment renewal notices to deleted accounts
Category: Site Administration
Patch by:denise
Description: If you're deleted, then you probably don't need to renew your account even if it's expiring. This makes it so.
Bug 2515: clean up duplicated code in userinfo.bml
Category: Misc Backend, Making Future Coders Happy
Patch by:kareila
Description: Code cleanup! This makes the code sleeker and easier to work with.
Bug 479: Add "link to top of thread" to comment email
Category: Misc UI/Frontend, Links are Good, Context is Good; Convenience is Good
Patch by:ninetydegrees
Description: You know how we have a link to the top of the thread in the comment itself? This adds it to the email as well, so you can get to the full thread with one click.
Bug 840: Greyed-out notifications should have an "upgrade to use these" notice
Category: Misc UI/Frontend
Patch by:ninetydegrees
Description: Add helpful text explaining if a notification option is only available to a certain account type (i.e., paid accounts), so you don't get inexplicably grayed out notification options.
Bug 2085: Blanket offers wizard choices it ignores/implements strangely
Category: Style System
Patch by:ninetydegrees
Description: Restrict navigation links position to just fixed, and all other modules to just be in the column.
Bug 1365: Add support for merging tags
Category: Tags, A little organization goes a long way
Patch by:yvi
Description: True tag merging! Merge multiple related tags into one big tag (though be careful, because once you start, you can't undo the process)
Bug 1809: if comm isn't moderated, queue page says 'not a maintainer'
Category: Communities
Patch by:yvi
Description: Tweaks the error messages to be more accurate.
Bug 2372: Add "All Circle Members" to Circle Gifts
Category: Site Administration, Convenience is Good
Patch by:yvi
Description: Sometimes, when wanting to give out gifts, you want to have a list of everyone in your circle, not just the free users or those whose accounts are about to expire. This adds everyone else below the other lists, for convenience.
Bug 2556: Profile linking code for OpenID uses ext_ format
Category: Misc UI/Frontend, Convenience is Good
Patch by:yvi
Description: The module in the profile page with the copy and paste code uses the ext_blah format for OpenID users. Since <user name="blah.example.com"> works and is more intuitive, we've switched the copy-and-paste module to also use that.
Bug 2597: Always show icon thumbnail in hover menu
Category: Misc UI/Frontend
Patch by:yvi
Description: The hover menu doesn't display the icon thumbnail if we're hovering over the default icon. This makes the thumbnail always show up, consistently.
Bug 2603: prefill search query box if provided with url argument, Convenience is Good
Category: Misc UI/Frontend
Patch by:yvi
Description: Going to http://www.dreamwidth.org/search?query=sometext will prefill the search textbox with "sometext", so that search strings can be bookmarkable.
Bug 2610: Missing semicolon in doc/config-local.pl.txt
Category: Site Administration
Patch by:sophie
Description: Syntax error was causing new installations to fail; this fixes the sample config file.
Bug 2572: anniversary promotion
Category: Misc Backend
Patch by:mark
Description: Implementation of the promo, as announced in![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png)
dw_news (And belated happy anniversary, Dreamwidth!)
Bug 2551: Missing 'to' argument in LJ.XMLRPC.sendmessage method returns Error#100 instead of Error#200
Category: APIs (RPC, XML, Flat)
Patch by:mayank
Description: Tweak to the protocol so that we get back a more accurate error message if we did not include a username when sending a message.
Bug 2561: missing href in /support/act?close
Category: Site Administration
Patch by:ninetydegrees
Description: Bad HTML! Fixed now.
mark's awesome efforts at going through the review queue.yvi, ninetydegrees, and mark totally rocked zilla, with nine, eight, and seven bugs resolved respectively. Much love and thanks to all our contributors this week: ninetydegrees, allen, denise, exor674, fu, kareila, mark, mayank, sophie, yvi. We have some great fixes for you all; some of these are already live, and some will be available by the next code push.Bug 2576: Makes the default site scheme stick if user has chosen a different one
Category: Misc UI/Frontend
Patch by:
exor674Description: There was an issue which prevented someone who'd selected a different site scheme from switching back to Tropospherical Red. This fixes that.
Bug 2423: Implement new payment system
Category: Site Administration, Shameless Money-Grubbing
Patch by:
markDescription: New payment system, yay! The bulk of the work had been done earlier, but this was left open for the version 2.0 fixes (which included transfer of points). There are still things that can be tweaked, but those can all go into new bugs!
Bug 2568: Replying to entries in sitescheme gives error
Category: Misc UI/Frontend, No Bug for You Dreamwidth
Patch by:
yviDescription: This was a bug where you'd get an error if you tried to reply to an entry on a site-scheme page. We caught this in beta, so no one actually ran into this problem on Dreamwidth. (Yay testing!)
Bug 2321: Support Google Checkout
Category: Misc Backend
Patch by:
markDescription: Oh GCO *sigh* This was the bug where we implemented the shortlived GCO support. Dreamwidth no longer supports GCO, but the code is still available for clone sites who might need it.
Bug 2554: %%url%% only substituted once in crossposting footer preview
Category: Crossposter, What You See Should Be What You Get
Patch by:
allenDescription: If you had multiple %%url%% in your crosspost, the preview only worked correctly for the first one. The text that was actually crossposted did work correctly. This makes the behavior of the preview consistent with the actual crossposted text.
Bug 2146: Custom security filters on reading pages
Category: Journal contents, More Ways to Filter Entries
Patch by:
exor674Description: You know how, if you're a paid user, you can do http://exampleusername.dreamwidth.org?security=access/private/public to see all entries with that security on a journal? (Assuming that you could view those entries in the first place!). Well now you can also do http://yourusername.dreamwidth.org/read/?security=access/public/private and see only entries with a particular security -- "private" will also show you admin-locked entries to communities. (This only makes sense on your own read page since you can't see locked entries on other people's read pages).
Bug 2446: Add cookie support to DW::Request
Category: Misc Backend, Modernization, Making Future Coders Happy
Patch by:
exor674Description: We modernized how we implement cookies. Lots of work, to make it easier for us to tweak things without breaking them, in the future!
Bug 2250: Misc BML cleanup
Category: Misc Backend, Making Future Coders Happy
Patch by:
markDescription: Code cleanup! This bug has been hanging around a while -- basically, it's for removing those unused BML files or things that we don't need anymore. Closed, since I think we got all that we might want to for now; we can always open a new one in case more files become obsolete in the future.
Bug 2274: expire carts after 30 days
Category: Site Administration
Patch by:
markDescription: Cart cleanup! If you'd created a cart before, it would hang around forever. So sometimes you might see stuff in your cart that's six months old, gathering mold and ewwww. This makes it so that unchecked-out carts are only valid for thirty days.
Bug 2489: moveucluster framework + purger needs updating
Category: Misc Backend, Oops I Guess We Needed to Update That
Patch by:
markDescription: Updates the scripts that move users from one cluster to another, and that purge deleted users, because they no longer worked with all the changes that we had done to the Dreamwidth code.
Bug 2573: shop points transfer page
Category: Misc Backend, Sharing the Love, Shameless Money-Grubbing
Patch by:
markDescription: You can transfer points from your stash to another user. (Need I say more?)
Bug 2049: Skittlish Dreams: modules incorrectly displayed when moved to footer or header
Category: Style System
Patch by:
ninetydegreesDescription: Some modules in Skittlish Dreams look horrible when you move them to either the footer or the hedaer. This makes it so that navlinks can't be put in the footer, and poweredby and time can't be moved to the header.
Bug 2072: Transmogrified: modules incorrectly displayed when moved to header
Category: Style System
Patch by:
ninetydegreesDescription: Some modules in Transmogrified look horrible when you move them to the header or footer. This tweaks the CSS so that the module contents look okay no matter where you put them.
Bug 2549: split out tropo css better
Category: Frontend, Making Future Coders Happy
Patch by:
ninetydegreesDescription: Code cleanup! Tropospherical Red and Tropospherical Purple are basically the same except for the colors, but have a lot of code duplicated between them. This cleans up the code so that when we need to tweak something, we only need to change it in one place, rather than editing multiple files. Less duplication == less chance of overlooking something when editing one scheme == less work for us. All good.
Bug 2569: htdocs/community/pending.bml uses [[link]] instead of [[aopts]] for "Return to the list" link
Category: Communities
Patch by:
ninetydegreesDescription: There was some miscommunication within the translation system. This fixes that.
Bug 2267: add link back to comment & parent on ?replyto=foo in sitescheme
Category: Misc UI/Frontend, Context is Good; Convenience is Good, Links are Good
Patch by:
yviDescription: On sitescheme reply pages, there were no links back to the original context. This adds links to the comment, the parent, and the start of the thread, because they're useful.
Bug 2563: Comment action links on S2 reply pages don't pass style=mine
Category: Style System, Context is Good; Convenience is Good, Links are Good
Patch by:
yviDescription: When using style=mine and viewing a reply page in S2, the various comment links didn't carry over the style=mine. This adds style=mine to the links, to be consistent.
Bug 1096: show=P, etc not always displaying the current view for the navstrip on the read page
Category: Misc UI/Frontend, What You See Should Be What You Get
Patch by:
fuDescription: The dropdown in the navstrip lets you choose to show only personal journals, only communities, or only feeds, and the dropdown should reflect whether one of these filters have been chosen. However, in some cases the dropdown was not accurate. Fixed now!
Bug 1579: Warning for Bad Markup
Category: Journal contents, No Bad Code for You
Patch by:
fuDescription: Previously, we'd made it so that entries with bad markup would be hidden behind a cut, so that you wouldn't see them on your read page. Now we're taking it one step further, and warn you after you post or edit an entry which contains bad markup, so that you'll be aware of it and fix your entry as soon as possible.
Bug 1757: new community setting: Entry's author and maintainers may add existing tags to an entry
Category: Tags, Community Management
Patch by:
fuDescription: Communities can allow the entry's author to tag their own entries, in addition to community administrators, as a middle ground between putting all the burden of handling tags to admins, and opening up tagging to all members in the community.
Bug 1433: sort alpha by keyword on allpics/editpics page
Category: Misc UI/Frontend, A little sorting goes a long way
Patch by:
allenDescription: Icons are now sortable by either upload order (the default), or by keyword order. Sorting by keywords on your /icons page makes the icon show up multiple times, once for each keyword. Sorting by keywords on your /editicons page sorts by the very first keyword.
Bug 2361: Links to cross-posted entries
Category: Crossposter, Links are Good
Patch by:
allenDescription: This automatically creates links from your entry on Dreamwidth to your crossposted entries. It's a per-account option (so you can choose to link to some, but not all, places you crosspost to). Go to your crosspost settings, and edit each account to "Display Cross Post Links". It will show up for any entry that you post or edit, after you check the checkbox, but not for anything before that. This is disabled by default so we don't spring surprises on you.
Bug 1852: Useful title for Layer Source Page
Category: Style System
Patch by:
exor674Description: This adds the layer's name to the title of the syntax-highlighted layer source, which is useful!
Bug 2605: don't send payment renewal notices to deleted accounts
Category: Site Administration
Patch by:
deniseDescription: If you're deleted, then you probably don't need to renew your account even if it's expiring. This makes it so.
Bug 2515: clean up duplicated code in userinfo.bml
Category: Misc Backend, Making Future Coders Happy
Patch by:
kareilaDescription: Code cleanup! This makes the code sleeker and easier to work with.
Bug 479: Add "link to top of thread" to comment email
Category: Misc UI/Frontend, Links are Good, Context is Good; Convenience is Good
Patch by:
ninetydegreesDescription: You know how we have a link to the top of the thread in the comment itself? This adds it to the email as well, so you can get to the full thread with one click.
Bug 840: Greyed-out notifications should have an "upgrade to use these" notice
Category: Misc UI/Frontend
Patch by:
ninetydegreesDescription: Add helpful text explaining if a notification option is only available to a certain account type (i.e., paid accounts), so you don't get inexplicably grayed out notification options.
Bug 2085: Blanket offers wizard choices it ignores/implements strangely
Category: Style System
Patch by:
ninetydegreesDescription: Restrict navigation links position to just fixed, and all other modules to just be in the column.
Bug 1365: Add support for merging tags
Category: Tags, A little organization goes a long way
Patch by:
yviDescription: True tag merging! Merge multiple related tags into one big tag (though be careful, because once you start, you can't undo the process)
Bug 1809: if comm isn't moderated, queue page says 'not a maintainer'
Category: Communities
Patch by:
yviDescription: Tweaks the error messages to be more accurate.
Bug 2372: Add "All Circle Members" to Circle Gifts
Category: Site Administration, Convenience is Good
Patch by:
yviDescription: Sometimes, when wanting to give out gifts, you want to have a list of everyone in your circle, not just the free users or those whose accounts are about to expire. This adds everyone else below the other lists, for convenience.
Bug 2556: Profile linking code for OpenID uses ext_ format
Category: Misc UI/Frontend, Convenience is Good
Patch by:
yviDescription: The module in the profile page with the copy and paste code uses the ext_blah format for OpenID users. Since <user name="blah.example.com"> works and is more intuitive, we've switched the copy-and-paste module to also use that.
Bug 2597: Always show icon thumbnail in hover menu
Category: Misc UI/Frontend
Patch by:
yviDescription: The hover menu doesn't display the icon thumbnail if we're hovering over the default icon. This makes the thumbnail always show up, consistently.
Bug 2603: prefill search query box if provided with url argument, Convenience is Good
Category: Misc UI/Frontend
Patch by:
yviDescription: Going to http://www.dreamwidth.org/search?query=sometext will prefill the search textbox with "sometext", so that search strings can be bookmarkable.
Bug 2610: Missing semicolon in doc/config-local.pl.txt
Category: Site Administration
Patch by:
sophieDescription: Syntax error was causing new installations to fail; this fixes the sample config file.
Bug 2572: anniversary promotion
Category: Misc Backend
Patch by:
markDescription: Implementation of the promo, as announced in
dw_news (And belated happy anniversary, Dreamwidth!)Bug 2551: Missing 'to' argument in LJ.XMLRPC.sendmessage method returns Error#100 instead of Error#200
Category: APIs (RPC, XML, Flat)
Patch by:
mayankDescription: Tweak to the protocol so that we get back a more accurate error message if we did not include a username when sending a message.
Bug 2561: missing href in /support/act?close
Category: Site Administration
Patch by:
ninetydegreesDescription: Bad HTML! Fixed now.