Wiki article on code review

[foxfirefey]

Soooo tonight denise mentioned that mark makes a sad face every time he comes home all ready and rarin' to code only to find a gazillion patches to review. In order to try and spread this burden around, I've attempted to write a guide on the Code Review process so that more people can help with this important chore. I'm posting it for review and discussion, to make sure the instructions in it are sound.

Comments

[foxfirefey]

Okay I am FINALLY getting around to this--

I guess the thing to ask is: what chores of code review would you feel comfortable having verified by others, and how could the system support this? For instance, maybe a Bugzilla tag "prereview" that gets bumped up to "review" or something. Or a "checkcompile" or...something. I'll note that I only meant the code review to apply to bugs that have been accepted as things that are going into the codebase, bug fixes and new features alike.

[zorkian]

Oh, I'm totally cool with someone diving in and doing a full review on anything they're comfortable reviewing. I'm hesitant to have any sort of officially tiered review system as that might slow down reviews in general (or give me an excuse to ignore things that aren't prereview+).

Maybe encourage people to do mini-reviews for functionality and compile checking and such. They can poke at it, and if it looks good, just comment to that effect - else, mark it review- with the problem they found.