Entry tags:
Code tour, 5 Jan - 10 Jan
This week's code tour cuts a day short, so that we can make sure all of what's listed here is live on the site. )With tonight's code push, all of these changes are now live.)
This week we resolved 40 bugs, 39 of which were fixed (one duplicate). One is a security-related bug we decline to describe publicly so other sites running the code can update their code. The remainder are below the cut!
I'm also proud this week of how many of these came through![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png)
dw_suggestions: 9 of this week's patches were for things originally suggested by y'all. As always, if you've got a good idea, we want to hear about it at the Suggestions generator!
Bug 2263: Missing translation string in editjournal.bml
Category: Cleanup
Patch by:![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
denise
Description: This was an error we inherited from LJ: when there's an error in fetching an entry to edit (such as if you try to edit an entry you don't have permission to edit, or in a community you don't have posting access to), the error message had a missing string. Oddly enough, in all the history of LJ and DW, nobody ever noticed that the string wasn't there and never has been! We fixed it and put the text in.
Bug 2262: Checkbox for "Cut Inbox" settings always unchecked; does not reflect the actual value
Category: Bugfix
Patch by:![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
afuna
Description: This fixes a bug with the setting for whether or not to display cut tags in the inbox: due to a minor bug, it always displayed as unchecked no matter whether or not the setting was set.
Bug 2260: Improve error/success for routing / Template Toolkit
Category: Backend/templating conversion
Patch by:foxfirefey
Description: Last week I described our efforts to convert the site to using Template Toolkit: a framework structure that builds the way pages are displayed and replaces BML, which is a custom templating language that Brad created for FreeVote ages ago. (Hands up everyone who knew that Brad created FreeVote before he made LiveJournal!) This is another step in that slow conversion: it adds some commonly-used views such as a "success" page for when you did what you were trying to do, as well as improving the error message page.
Bug 2259: Preview of embedded content in entry does not detect width and height
Category: Cleanup
Patch by:afuna
Description: On entry preview, any embedded content doesn't obey the height and width parameters of the embed, instead using a default setting that may or may not have any bearing on reality. Afuna made the preview code take out the ruler and measure it.
Bug 2256: Unnecessary pending link beside tags when there are pending membership requests
Category: Bugfix
Patch by:afuna
Description: This fixes a bug with the Community Management page: if there were pending members, it would also add "Pending" next to the tag count, which is silly because there's no such thing as a pending tag. It is now fixed!
Bug 2255: Convert nav.bml to Template Toolkit
Category: Backend/templating conversion
Patch by:foxfirefey
Description: This converts the files used to generate the top-level menu pages (if you click on the top menu item, the Create/Organize/Read/Explore/Shop links on the site scheme) into our new templating language.
Bug 2248: Spruce up Gradation Vertical
Category: Display bugfix
Patch by:foxfirefey
Description: A collection of display bugfixes for the Gradation Vertical scheme, which should fix most of the display problems (black-on-black, white-on-white, etc) in lesser-used pages that we didn't notice earlier.foxfirefey is tireless in her rooting out of poor contrast!
Bug 2245: Read page skiplinks not behaving correctly
Category: Bugfix
Patch by:yvi
Description: A little while ago,yvi wrote a patch to improve the way the skip forward/skip back links are handled, which Mark tweaked a bit when he committed it. Unfortunately, the tweak broke things so that the skip forward link always brought you back to the front page of the journal, even when it should've brought you elsewhere (like ?skip=40 instead of the front page). So Yvi got to fix it again. Sorry, Yvi!
Bug 2243: Adult content div box colors hardcoded
Category: Display bugfix
Patch by:foxfirefey
Description: We've been slowly going through and rooting out instances where colors (backgrounds, foregrounds, text colors, standout boxes, etc) are hardcoded in the site code instead of being controlled by the site scheme's CSS. (These were inherited from LJ, which only has one supported sitescheme and even the unsupported ones are all black-on-white, so contrast problems are less likely to be noticed.) This was one of them: now the div box that shows up when a journal or entry is marked as having adult content/being NSFW is controlled by the site scheme instead of being hardcoded.
Bug 2242: Your account has been deleted mail points to wrong FAQ
Category: Site copy
Change by:denise
Description: The email sent out when you delete an account contained a reference to a FAQ from LJ, which doesn't correspond to the same FAQ on Dreamwidth. We changed the email to be a general pointer to Support instead of to a FAQ for now.
Bug 2241: Deleted communities not selectable on manage/settings
Category: Usability
Patch by:yvi
Description: This changes the 'work as user' dropdown so that deleted communities you're an admin of (which don't appear in the drop-down work-as box generally) do appear on the account status page, so you can undelete a community without having to fuss around with the URL and create it manually. Deleted comms will only appear on the page where you can undelete them, to avoid cluttering the dropdown otherwise.
Bug 2239: new priv, suspend:openid
Category: Site administration, spammers must die!
Patch by:denise
Description: This adds a new administrative privilege that we can hand out to allow our antispam team leads to suspend OpenID accounts that are abusing the site, without giving them the ability to suspend user accounts as well. (This functions on the idea of 'least privilege' -- for general security reasons, our policy is to give people the least amount of access they need to do their work.)
Bug 2236: Convert /misc/whereami to TT
Category: Backend/templating conversion
Patch by:mark
Description: This converts the Where Am I page to use our new templating system. (Because Mark is not satisfied with doing things halfway, it also includes a lot of backend fixes and improvements to said templating system.)
Bug 2230: Celerity min height needs increase, overrunning footer
Category: Display bugfix
Patch by:denise, CSS by branchandroot
Description: This fixes up the CSS used in the Celerity site scheme to keep the sidebar from overlapping the footer on short pages.
Bug 2187: Poll section in inbox
Category: Usability
Patch by:afuna
Description: I drooled over this one a little bit earlier! This adds a 'poll responses' section to the inbox: if you subscribe to "someone votes in my poll" events, you can now find them all together under this section of the inbox.
Bug 2173: add a link to the account settings page to the navbar
Category: Usability
Patch by:yvi
Description: For the sake of getting to manage your account more easily, this adds a link to the Account Settings page on the navstrip, saving you a click or two.
Bug 2171: Promote latest page more
Category: Usability, finding cool stuff
Patch by:ninetydegrees
Description: Our Latest Things page needed more love! So this adds a link in both the site map and the Explore menu.
Bug 2167: Don't show entry on first page if it matches the displayed sticky entry
Category: Usability
Patch by:afuna
Description: This changes the display logic so that your sticky entry (settable through the Display tab of the Account Settings page) isn't repeated if the entry should appear on the front page. This is a bit confusing, so let me try again: if you only have 6 entries in your journal, usually it'd display 6-5-4-3-2-1. If you then make entry #3 your sticky entry, prior to this patch it would display 3-6-5-4-3-2-1. Now it displays 3-6-5-4-2-1, not duplicating the sticky entry where it should go in order. (This only applies to the first page: once the entry that has been stuck passes off the first page, it goes back to displaying where it should in order.)
Bug 2157: post-location
Category: Site copy
Patch by:yvi
Description: This adds documentation for the 'post-location' header when posting via email.
Bug 2149: Remove feeds from "Recently Active" on stats page
Category: Cleanup, finding cool stuff
Patch by:yvi
Description: This fixes something that's been annoying me for a while! The Stats page has a section for "recently active", which up until this push included feed accounts, so you couldn't actually find real live people. The Latest Things page has a lot more flexibility than this section, but it's still awesome to have, so Yvi fixed it up so that feed accounts aren't counted in there -- only personal and community accounts.
Bug 2108: Theme: Light On Dark (Funky Circles)
Category: Styles
Patch by:ninetydegrees, theme by cesy
Description: This adds a theme for the Funky Circles style that's light text on a black entry background with an overall purple background to the page.
Bug 2104: new sysban type: spamreport
Category: Backend/administrative
Patch by:afuna
Description: This adds the ability for site admins to block a particular account or community from reporting comments as spam, for accounts that regularly misuse this option.
Bug 2080: fix logic for editing and deleting community entries
Category: Backend/community
Patch by:mark
Description: This is a huge redo of the logic that governs editing and deleting community entries in order to simplify the backend code. You shouldn't notice anything hugely major changing (and if you do, it's probably a bug), but one major change is that OpenID accounts can now edit and delete entries of theirs from the community. This is important, because if we allow community imports in the future en masse (right now we only allow them in special cases), the posters of community entries will need to be able to control them.
Bug 2047: Community and custom group archives not updating
Category: Bugfix
Patch by:afuna
Description: In October, we introduced a bug that was causing community archive pages not to update. We did a quick-and-dirty fix at the time to get that resolved, while this is the permanent fix that's not quite so quick-and-dirty.
Bug 1994: Reply to comments without unscreening
Category: Usability, privacy
Patch by:yvi
Description: This is a major thing that's been frequently requested! It changes the reply-to-a-screened-comment logic so that the (screened) comment you're replying to is not automatically unscreened -- you have to choose to unscreen it. (Assuming you have the ability to unscreen comments, that is.) Previously, replying to a comment would automatically unscreen it.
Bug 1968: Logic for checking format=light/style=mine, etc arguments is duplicated in various places
Category: Code cleanup
Patch by:afuna
Description: This is one of those things that hopefully nobody will notice -- because if you notice it, it means there's a bug -- but which will make things a lot easier for people maintaining the code in the future, because they won't have to update the same code in bunches of places.
Bug 1748: Implement a feature similar to popwithfriends.bml
Category: Fun toys, finding people
Patch by:yvi
Description: This one is just plain cool: paid users can now see popular subscriptions with your circle, aka "people most often read by the people you read". It's broken down into people/communities/feeds, and you have a bunch of different choices of how to calculate 'popular' -- your subscriptions, people with whom you have mutual subscriptions, people you've given access to, people with whom you have mutual access, and your entire circle (access + subscription). It's really beautifully done, and Yvi should be damn proud of it.
Bug 1718: Crossposting footer truncates after unknown amount of time
Category: Bugfix
Patches by:allen & sophie
Description: This was totally a mea culpa: when I coded the custom crosspost footer, I used the wrong field type for the property and then didn't realize it, which was causing anything longer than 256 characters to get cut off after a little while (there is a technical explanation for why it didn't happen immediately, but I will spare those who don't care). Allen fixed my screwup, and then Sophie further refined the patch.
Bug 1531: promo codes admin frontend
Category: Admin tools
Patch by:exor674
Description: A while back, Mark worked up a system where we could give out one invite code to a bunch of people, for handing out easy-to-remember codes at conferences and the like and for moving over communities as a whole. It was a quick addition, though -- Mark literally pushed the code a few hours before the conference we were attending -- and he didn't have the time to make a pretty frontend for it, so the only way to do it was to tickle the database directly. Andrea gave me a nice pretty frontend so I don't have to bug Mark every time I want to hand out a promo code!
Bug 1369: add an inbox area for "Unread items"
Category: Usability
Patch by:afuna and foxfirefey
Description: This is a suggestion so old that it comes from the days before we had a suggestions post generator! It adds a link to the sidebar of the inbox that will let you filter to only the unread items left in your inbox. (It's also a great example of two people working together! Fey did the initial patch, then didn't have the time to finish it, so Afuna took it the last 30% or so of the way.)
Bug 1295: update console command for setting tag security
Category: Backend cleanup
Patch by:kareila
Description: This cleans up some more usages of 'friends'.
Bug 1227: Crossposter fails when cut text attribute contains certain HTML entities
Category: Bugfix
Patch by:allen
Description: This fixes a bug with the crossposter where having certain characters in cut text would cause the crosspost to fail.
Bug 920: Ensure all get_link functions have text that can be changed in core2
Category: Styles backend
Patch by:afuna
Description: Okay, so, I'll confess that our style system is deep voodoo to me, and for all I know this patch could be the secret to summoning the Elder Gods to rise from their torpor. But what I think it does is let people change some more of the text that's displayed in journals to be their own custom text. I think. (Ia! Ia!)
Bug 843: URLs in entry subject lines force subject lines to appear as text, not entry hyperlinks
Category: Display bugfix
Patch by:afuna
Description: This fixes a problem where links in the subject of a post would override the subject-as-link (which in some cases, like an entry with disabled comments, was the easiest way to click through to the post itself if you wanted to view it in single-entry mode). This caused problems in some browsers, because of the double-linking. Now the system will munch links out of subjects everywhere but on the single-entry view, so that the subject will be a link to the single-entry view for that entry everywhere else, but the link in the subject will still be there in the single-entry view. (If that made no sense to you, you are not the only one. It makes sense when you see it; it's just really hard to describe.)
Bug 826: change feedback when last invite code has been used
Category: Usability
Patch by:yvi
Description: This is a small touch for usability: if you're sending out your last unused invite code, the message it shows afterwards won't ask you if you'd like to invite someone else, since you don't have the invite code to send.
Bug 395: Increase syn feed size limits
Category: Interoperability
Patch by:denise
Description: This increases the maximum allowable feed acount limit like whoa: it used to be 300kb, after which the site would display a "feed is too large" error, and now it's 3MB. (And if that's not enough, we can increase it to 6MB in special cases.) That should cover just about anything: any feed larger than that is likely some sort of technical error!
Bug 355: tags miscounted on filtered posts
Category: Backend bugfix
Patch by:kareila
Description: A while back we fixed the site so that if you used a tag on a single entry that was filtered to multiple groups, it would only count the tag as one use, not multiple. (That was an old design choice that we inherited from LJ.) Subsequent commits accidentally reverted the change, so this patch re-does it (and runs the database updates to fix it). Older entries that were miscounted like that will still make incorrect tag counts show on your tag page and your tag management page, but anything from here on out will be counted properly. Unless we accidentally revert it again. Oops.
Bug 154: On comment reply pages, add a link back to parent comment and its parent comment
Category: Usability
Path by:grimsniffer
Description: I get so ridiculously excited every time we close a bug with a number this low! This changes the ?replyto=blah page you get when you click to reply to a comment so that it includes links back to the comment you're replying to. Right now it only functions in custom comment pages, but it should help people out in keeping up with the conversation.
This week we resolved 40 bugs, 39 of which were fixed (one duplicate). One is a security-related bug we decline to describe publicly so other sites running the code can update their code. The remainder are below the cut!
I'm also proud this week of how many of these came through
dw_suggestions: 9 of this week's patches were for things originally suggested by y'all. As always, if you've got a good idea, we want to hear about it at the Suggestions generator!Bug 2263: Missing translation string in editjournal.bml
Category: Cleanup
Patch by:
deniseDescription: This was an error we inherited from LJ: when there's an error in fetching an entry to edit (such as if you try to edit an entry you don't have permission to edit, or in a community you don't have posting access to), the error message had a missing string. Oddly enough, in all the history of LJ and DW, nobody ever noticed that the string wasn't there and never has been! We fixed it and put the text in.
Bug 2262: Checkbox for "Cut Inbox" settings always unchecked; does not reflect the actual value
Category: Bugfix
Patch by:
afunaDescription: This fixes a bug with the setting for whether or not to display cut tags in the inbox: due to a minor bug, it always displayed as unchecked no matter whether or not the setting was set.
Bug 2260: Improve error/success for routing / Template Toolkit
Category: Backend/templating conversion
Patch by:
foxfirefeyDescription: Last week I described our efforts to convert the site to using Template Toolkit: a framework structure that builds the way pages are displayed and replaces BML, which is a custom templating language that Brad created for FreeVote ages ago. (Hands up everyone who knew that Brad created FreeVote before he made LiveJournal!) This is another step in that slow conversion: it adds some commonly-used views such as a "success" page for when you did what you were trying to do, as well as improving the error message page.
Bug 2259: Preview of embedded content in entry does not detect width and height
Category: Cleanup
Patch by:
afunaDescription: On entry preview, any embedded content doesn't obey the height and width parameters of the embed, instead using a default setting that may or may not have any bearing on reality. Afuna made the preview code take out the ruler and measure it.
Bug 2256: Unnecessary pending link beside tags when there are pending membership requests
Category: Bugfix
Patch by:
afunaDescription: This fixes a bug with the Community Management page: if there were pending members, it would also add "Pending" next to the tag count, which is silly because there's no such thing as a pending tag. It is now fixed!
Bug 2255: Convert nav.bml to Template Toolkit
Category: Backend/templating conversion
Patch by:
foxfirefeyDescription: This converts the files used to generate the top-level menu pages (if you click on the top menu item, the Create/Organize/Read/Explore/Shop links on the site scheme) into our new templating language.
Bug 2248: Spruce up Gradation Vertical
Category: Display bugfix
Patch by:
foxfirefeyDescription: A collection of display bugfixes for the Gradation Vertical scheme, which should fix most of the display problems (black-on-black, white-on-white, etc) in lesser-used pages that we didn't notice earlier.
foxfirefey is tireless in her rooting out of poor contrast!Bug 2245: Read page skiplinks not behaving correctly
Category: Bugfix
Patch by:
yviDescription: A little while ago,
yvi wrote a patch to improve the way the skip forward/skip back links are handled, which Mark tweaked a bit when he committed it. Unfortunately, the tweak broke things so that the skip forward link always brought you back to the front page of the journal, even when it should've brought you elsewhere (like ?skip=40 instead of the front page). So Yvi got to fix it again. Sorry, Yvi!Bug 2243: Adult content div box colors hardcoded
Category: Display bugfix
Patch by:
foxfirefeyDescription: We've been slowly going through and rooting out instances where colors (backgrounds, foregrounds, text colors, standout boxes, etc) are hardcoded in the site code instead of being controlled by the site scheme's CSS. (These were inherited from LJ, which only has one supported sitescheme and even the unsupported ones are all black-on-white, so contrast problems are less likely to be noticed.) This was one of them: now the div box that shows up when a journal or entry is marked as having adult content/being NSFW is controlled by the site scheme instead of being hardcoded.
Bug 2242: Your account has been deleted mail points to wrong FAQ
Category: Site copy
Change by:
deniseDescription: The email sent out when you delete an account contained a reference to a FAQ from LJ, which doesn't correspond to the same FAQ on Dreamwidth. We changed the email to be a general pointer to Support instead of to a FAQ for now.
Bug 2241: Deleted communities not selectable on manage/settings
Category: Usability
Patch by:
yviDescription: This changes the 'work as user' dropdown so that deleted communities you're an admin of (which don't appear in the drop-down work-as box generally) do appear on the account status page, so you can undelete a community without having to fuss around with the URL and create it manually. Deleted comms will only appear on the page where you can undelete them, to avoid cluttering the dropdown otherwise.
Bug 2239: new priv, suspend:openid
Category: Site administration, spammers must die!
Patch by:
deniseDescription: This adds a new administrative privilege that we can hand out to allow our antispam team leads to suspend OpenID accounts that are abusing the site, without giving them the ability to suspend user accounts as well. (This functions on the idea of 'least privilege' -- for general security reasons, our policy is to give people the least amount of access they need to do their work.)
Bug 2236: Convert /misc/whereami to TT
Category: Backend/templating conversion
Patch by:
markDescription: This converts the Where Am I page to use our new templating system. (Because Mark is not satisfied with doing things halfway, it also includes a lot of backend fixes and improvements to said templating system.)
Bug 2230: Celerity min height needs increase, overrunning footer
Category: Display bugfix
Patch by:
denise, CSS by branchandrootDescription: This fixes up the CSS used in the Celerity site scheme to keep the sidebar from overlapping the footer on short pages.
Bug 2187: Poll section in inbox
Category: Usability
Patch by:
afunaDescription: I drooled over this one a little bit earlier! This adds a 'poll responses' section to the inbox: if you subscribe to "someone votes in my poll" events, you can now find them all together under this section of the inbox.
Bug 2173: add a link to the account settings page to the navbar
Category: Usability
Patch by:
yviDescription: For the sake of getting to manage your account more easily, this adds a link to the Account Settings page on the navstrip, saving you a click or two.
Bug 2171: Promote latest page more
Category: Usability, finding cool stuff
Patch by:
ninetydegreesDescription: Our Latest Things page needed more love! So this adds a link in both the site map and the Explore menu.
Bug 2167: Don't show entry on first page if it matches the displayed sticky entry
Category: Usability
Patch by:
afunaDescription: This changes the display logic so that your sticky entry (settable through the Display tab of the Account Settings page) isn't repeated if the entry should appear on the front page. This is a bit confusing, so let me try again: if you only have 6 entries in your journal, usually it'd display 6-5-4-3-2-1. If you then make entry #3 your sticky entry, prior to this patch it would display 3-6-5-4-3-2-1. Now it displays 3-6-5-4-2-1, not duplicating the sticky entry where it should go in order. (This only applies to the first page: once the entry that has been stuck passes off the first page, it goes back to displaying where it should in order.)
Bug 2157: post-location
Category: Site copy
Patch by:
yviDescription: This adds documentation for the 'post-location' header when posting via email.
Bug 2149: Remove feeds from "Recently Active" on stats page
Category: Cleanup, finding cool stuff
Patch by:
yviDescription: This fixes something that's been annoying me for a while! The Stats page has a section for "recently active", which up until this push included feed accounts, so you couldn't actually find real live people. The Latest Things page has a lot more flexibility than this section, but it's still awesome to have, so Yvi fixed it up so that feed accounts aren't counted in there -- only personal and community accounts.
Bug 2108: Theme: Light On Dark (Funky Circles)
Category: Styles
Patch by:
ninetydegrees, theme by cesyDescription: This adds a theme for the Funky Circles style that's light text on a black entry background with an overall purple background to the page.
Bug 2104: new sysban type: spamreport
Category: Backend/administrative
Patch by:
afunaDescription: This adds the ability for site admins to block a particular account or community from reporting comments as spam, for accounts that regularly misuse this option.
Bug 2080: fix logic for editing and deleting community entries
Category: Backend/community
Patch by:
markDescription: This is a huge redo of the logic that governs editing and deleting community entries in order to simplify the backend code. You shouldn't notice anything hugely major changing (and if you do, it's probably a bug), but one major change is that OpenID accounts can now edit and delete entries of theirs from the community. This is important, because if we allow community imports in the future en masse (right now we only allow them in special cases), the posters of community entries will need to be able to control them.
Bug 2047: Community and custom group archives not updating
Category: Bugfix
Patch by:
afunaDescription: In October, we introduced a bug that was causing community archive pages not to update. We did a quick-and-dirty fix at the time to get that resolved, while this is the permanent fix that's not quite so quick-and-dirty.
Bug 1994: Reply to comments without unscreening
Category: Usability, privacy
Patch by:
yviDescription: This is a major thing that's been frequently requested! It changes the reply-to-a-screened-comment logic so that the (screened) comment you're replying to is not automatically unscreened -- you have to choose to unscreen it. (Assuming you have the ability to unscreen comments, that is.) Previously, replying to a comment would automatically unscreen it.
Bug 1968: Logic for checking format=light/style=mine, etc arguments is duplicated in various places
Category: Code cleanup
Patch by:
afunaDescription: This is one of those things that hopefully nobody will notice -- because if you notice it, it means there's a bug -- but which will make things a lot easier for people maintaining the code in the future, because they won't have to update the same code in bunches of places.
Bug 1748: Implement a feature similar to popwithfriends.bml
Category: Fun toys, finding people
Patch by:
yviDescription: This one is just plain cool: paid users can now see popular subscriptions with your circle, aka "people most often read by the people you read". It's broken down into people/communities/feeds, and you have a bunch of different choices of how to calculate 'popular' -- your subscriptions, people with whom you have mutual subscriptions, people you've given access to, people with whom you have mutual access, and your entire circle (access + subscription). It's really beautifully done, and Yvi should be damn proud of it.
Bug 1718: Crossposting footer truncates after unknown amount of time
Category: Bugfix
Patches by:
allen & sophieDescription: This was totally a mea culpa: when I coded the custom crosspost footer, I used the wrong field type for the property and then didn't realize it, which was causing anything longer than 256 characters to get cut off after a little while (there is a technical explanation for why it didn't happen immediately, but I will spare those who don't care). Allen fixed my screwup, and then Sophie further refined the patch.
Bug 1531: promo codes admin frontend
Category: Admin tools
Patch by:
exor674Description: A while back, Mark worked up a system where we could give out one invite code to a bunch of people, for handing out easy-to-remember codes at conferences and the like and for moving over communities as a whole. It was a quick addition, though -- Mark literally pushed the code a few hours before the conference we were attending -- and he didn't have the time to make a pretty frontend for it, so the only way to do it was to tickle the database directly. Andrea gave me a nice pretty frontend so I don't have to bug Mark every time I want to hand out a promo code!
Bug 1369: add an inbox area for "Unread items"
Category: Usability
Patch by:
afuna and foxfirefeyDescription: This is a suggestion so old that it comes from the days before we had a suggestions post generator! It adds a link to the sidebar of the inbox that will let you filter to only the unread items left in your inbox. (It's also a great example of two people working together! Fey did the initial patch, then didn't have the time to finish it, so Afuna took it the last 30% or so of the way.)
Bug 1295: update console command for setting tag security
Category: Backend cleanup
Patch by:
kareilaDescription: This cleans up some more usages of 'friends'.
Bug 1227: Crossposter fails when cut text attribute contains certain HTML entities
Category: Bugfix
Patch by:
allenDescription: This fixes a bug with the crossposter where having certain characters in cut text would cause the crosspost to fail.
Bug 920: Ensure all get_link functions have text that can be changed in core2
Category: Styles backend
Patch by:
afunaDescription: Okay, so, I'll confess that our style system is deep voodoo to me, and for all I know this patch could be the secret to summoning the Elder Gods to rise from their torpor. But what I think it does is let people change some more of the text that's displayed in journals to be their own custom text. I think. (Ia! Ia!)
Bug 843: URLs in entry subject lines force subject lines to appear as text, not entry hyperlinks
Category: Display bugfix
Patch by:
afunaDescription: This fixes a problem where links in the subject of a post would override the subject-as-link (which in some cases, like an entry with disabled comments, was the easiest way to click through to the post itself if you wanted to view it in single-entry mode). This caused problems in some browsers, because of the double-linking. Now the system will munch links out of subjects everywhere but on the single-entry view, so that the subject will be a link to the single-entry view for that entry everywhere else, but the link in the subject will still be there in the single-entry view. (If that made no sense to you, you are not the only one. It makes sense when you see it; it's just really hard to describe.)
Bug 826: change feedback when last invite code has been used
Category: Usability
Patch by:
yviDescription: This is a small touch for usability: if you're sending out your last unused invite code, the message it shows afterwards won't ask you if you'd like to invite someone else, since you don't have the invite code to send.
Bug 395: Increase syn feed size limits
Category: Interoperability
Patch by:
deniseDescription: This increases the maximum allowable feed acount limit like whoa: it used to be 300kb, after which the site would display a "feed is too large" error, and now it's 3MB. (And if that's not enough, we can increase it to 6MB in special cases.) That should cover just about anything: any feed larger than that is likely some sort of technical error!
Bug 355: tags miscounted on filtered posts
Category: Backend bugfix
Patch by:
kareilaDescription: A while back we fixed the site so that if you used a tag on a single entry that was filtered to multiple groups, it would only count the tag as one use, not multiple. (That was an old design choice that we inherited from LJ.) Subsequent commits accidentally reverted the change, so this patch re-does it (and runs the database updates to fix it). Older entries that were miscounted like that will still make incorrect tag counts show on your tag page and your tag management page, but anything from here on out will be counted properly. Unless we accidentally revert it again. Oops.
Bug 154: On comment reply pages, add a link back to parent comment and its parent comment
Category: Usability
Path by:
grimsnifferDescription: I get so ridiculously excited every time we close a bug with a number this low! This changes the ?replyto=blah page you get when you click to reply to a comment so that it includes links back to the comment you're replying to. Right now it only functions in custom comment pages, but it should help people out in keeping up with the conversation.