Code Tour: 8 December - 14 December

[dreamatdrew]

Hola, and welcome to Dreamwidth's Code Tour. I'm Drew, your host for this week. Lets get to the heart of the matter, shall we?

This week we have 15 bugs, and 4 new style options for your perusal. All of these patches are live, thanks to tonight's code push. Yet again, afuna  is our front-runner, with contributions from mark , denise , and gchick  .
Here we go.


Bug 48: Respect lj-cut in the Inbox, as a user-defined parameter
Category: User Default, User Interface
Patch by: afuna
Description: This will let you set it so that posts which get routed to your site inbox show up as they do on your reading page, putting the cut behind a link to the full entry. The current setting is only in the console, and has been added to the que of things to be moved from there Real Soon Now.

Bug 1145: don't-email-comments setting should still email replies to your comments
Category: Consistancy
Patch by: afuna
Description: On posts where you have "don't email comments" option checked, you were not getting replies to comments you posted on that post. This changes the behavior so that it respects the account-level notification setting for those comment replies.

Bug 1879: Option to add a reason when editing comments
Category: Suggestions, Make It Pretty
Patch by: afuna
Description: This lets you specify the reason you edited a commet on a post, which gets displayed in addition to the comment. No more having to edit an edit to say why you edited it.

Bug 2106: Stick entry doesn't alternate properly
Category: User Interface, Make It Pretty, bugfix
Patch by: afuna
Description: With styles that alternate colors for entries on your journal page, sticky entries were not marked to get the proper coloration, causing two entries with the same coloration in a row. This fixes that.

Bug 2111: OPML ?show=P / show=C also includes feed accounts
Category: User Interface, Syndication, bugfix
Patch by: afuna
Description: This removes feed accounts from the ?show=P and ?show=C filters of OPML file (which is an automated file that allows you to reconstruct your reading list elsewhere).

Bug 2158: Enable sending PMs to OpenID display names
Category: Suggestions, Inbox, bugfix
Patch by: denise
Description: Geeky Explanation Time: The name you see for OpenID users is not how Dreamwidth keeps track of them internally; they actually have an accont with a name like "ext_XXXX", where XXXX is a number. This makes it so that the PM system sees an OpenID account and automagically translates it to the ext_ name behind the scenes, so all you ever have to worry about is the displayed username.

Bug 2184: Amend help-language in Style Wizard
Category: Styles, User Interface, Code does not get to be rude
Patch by: afuna
Description: This is a minor edit of the display strings for the Style Wizard.

Bug 2203: Paid time gift promotion
Category: Shameless Money Grubbing/Holiday Cheer
Patch by: mark
Description: For the month of December, buying six months of paid time or premium paid time for another account gets you two months of paid/premium paid time for your own account. Twelve months gets you four. This is showing up as a second item in your shopping cart, which you cant remove. Yay freebies!

Bug 2205: change translation strings used by Tropo Red/Purple
Category: Code Cleanup, OOPS we missed something
Patch by: gchick
Description: This changes the Tropo Sitescheme variants to use generic sitescheme strings instead of its own very special variations which were exactly the same. Tropo is special, but not quite that special.

Bug 2210: Active entries module in odd place in Transmogrified, Sunday Morning, Brittle
Category: Styles, User Interface, Make It Pretty
Patch by: afuna
Description: The active entries module was showing up in the wrong place no those three styles. This puts them where they theoretically were supposed to be in the first place.

Bug 2211: style parameters no longer persist for expand links
Category: User Interface
Patch by: afuna
Description: Expanded comments were showing up in the scheme from the journal you were reading. This fixes it so that the expand links pay attention to style=blah from the url used to get to the page, and respect that choice.

Bug 2212: After marking everything read, inbox count in menu has empty parentheses
Category: bugfix, even afuna makes a goof now and then
Patch by: afuna
Description: If you were on the inbox page, and marked everything as read, the inbox link from the site menu displayed "Inbox ()", which was not what it was supposed to show. Now the "()" will go away when apropos.

Bug 2219: Fix userpic rename worker to pass compile test
Category: Backend, Cleanup, Code does not get to be rude
Patch by: mark
Description: The code for the rename worker was not quite perfect, and the compiler did not like this. Now the compiler is silent, and all is well.

Bug 2225: Selecting a username before pressing the user-tag button in the RTE causes a JS error
Category: bugfix, RTE
Patch by: afuna
Description: The username-ifier in the Rich Text Editor did not quite understand how to take the selected text and turn it into a username. Now it does.

Bug 2233: mass privacy tool not working
Category: Backend, bugfix
Patch by: mark
Description: The mass privacy tool thought it worked, but it did not have something it needed to do its job. Mark fixed it. Yay mark.


And in our special expanded "Make It Pretty" catagory, we have 7 new themes, and a new sitescheme.


Bug 1891: New Sitescheme: Gradation Vertical
Patch by: original sitescheme by branchandroot, color-shifted DW logo by truelove, site scheme adapted to DW by denise
Description: A very nice no-eye-stressing Grey and white sitescheme. Personally, I'd have named it Nebari-style.

Bug 1904: Theme: Plastic Grass (Modish)
Patch by: zvi


Bug 2129: Themes: Marble I & II (Fluid Measure)
Patch by: dancing_serpent

Bug 2131: Themes: 5 themes (Boxes and Borders)
Patch by: branchandroot
Description: Five new themes for Boxes and Borders: Bittersweet, Grass, On Fire, Pink After Dark, and Rainy Day


I'll be honest, I have not a lot to say about these except "pretty".

And that's it for this weeks Code Tour. Check out our Bug Tour for more Dreamwidth Development goodies.