Assigned-bugs hackathon!

[denise]

I checked tonight, and we've got 571 open bugs. That's a lot! 146 of them are assigned with no patch, and if we could make some inroads on that number, we'd be able to knock down the total open number a hell of a lot.

So, here's my hackathon challenge! If you've got assigned bugs, let's do whatever we can this week to get that number down. I'll start; I have 8 bugs assigned to me without a patch, and while some of them are waiting on other things to get resolved first, some of them are things I've just been putting off because I don't know exactly how to do them or was running into problems.

I've already yelled for help on what I'm stuck on, so I'll turn to y'all: what can I help you with on stuff you're stuck on? And if not me, who else can help you? A bunch of the existing assigned stuff is really complex, so let's all work together and see how much we can improve things.

Ideally, I'd like to get that "open" number down below 500 by Sunday night, and double ideally, the "all unassigned" number (currently at 386) down under 300.

*salutes you all*

Comments

[cesy]

I need to arrange a time with sophie to attack 1581. She has the code knowledge and I have the design knowledge.

For 581, I need some help figuring out how to add things to the tags box when you click on a link. yvi said I could use Edit Tags, but I'm going to need someone to talk me through it, I think.

And 1877 just needs me to get around to it.

Prod me next time I'm in IRC, maybe? Theoretically I could do one of those tonight.

[denise]

*salute* Yes'm!

[afuna]

*checks her bugs* Hmm, I've got six bugs assigned, two are awaiting review and Bug 1839 is waiting for someone else's CLA before it can be committed.

I need to write Bug 153 from scratch, but mark and exor674 gave me a good approach for it. Bug 1706 is half-done, and Bug 1496 is about four-fifths done! I guess I should finish up the ones that I can :D

[cesy]

Oh, 153 is going to be so handy. *cheers you on*
And yay for more styles and fixing caching problems.

[afuna]

I should review patches too! *___*

[afuna]

For 581, it looks like it requires JavaScript. I... kinda wrote a Greasemonkey script that implemented something similar for LJ. It can't be used here directly, because the bulk of it is irrelevant (also you can use jQuery, which I promise will make life better :)), but I'd be happy to bounce ideas around for your implementation.

[cesy]

Can I use jQuery? I was thinking probably not, because of all the stuff already on the update page. There was some discussion at http://dw-dev-training.dreamwidth.org/10580.html before.

[afuna]

Oh, hm. Yeah, you're right. In that case, the code gets longer and uglier, but not necessarily that much more complicated (e.g., lots more explicitly setting the values, instead of convenience methods). So scratch what I said about jQuery then. Oops.

[yvi]

Did you get my comment about one of your bugs having the wrong patch uploaded?

My currently assigned bugs:

http://bugs.dwscoalition.org/show_bug.cgi?id=312 has patch

http://bugs.dwscoalition.org/show_bug.cgi?id=1365 is way too huge to tackle in one week

http://bugs.dwscoalition.org/show_bug.cgi?id=1574 waiting for another patch

http://bugs.dwscoalition.org/show_bug.cgi?id=1670 has patch and is the one blocking 1574

http://bugs.dwscoalition.org/show_bug.cgi?id=1685 I'll try to tackle that :) However, I have no idea how to because the preview code is confusing me.

http://bugs.dwscoalition.org/show_bug.cgi?id=1748 has a patch

http://bugs.dwscoalition.org/show_bug.cgi?id=1850 is only open because there might be new styles

http://bugs.dwscoalition.org/show_bug.cgi?id=1878 will tackle that one tonight and woule like help for making it pretty

http://bugs.dwscoalition.org/show_bug.cgi?id=1881 patch rejected, will re-upload

So I might be able to finish a few :)

[yvi]

Um, yeah, I kind of failed to see that you have to use JavaScript there, which I am really rubbish at.

[denise]

Well, I know I got the comment, but I probably didn't associate it with one of my patches. *G* Will look into it.

[cesy]

Ooh, 1685 will be useful. 1574 is going to be so cool. Yay for 1748 and 312.

For 1878, two columns was suggested as a solution. Would that work for the pretty, or did you need more detail or another idea?

Also, much yay for subscription filters that work now. Thank you!

[yvi]

Would that work for the pretty, or did you need more detail or another idea?

Mainly I am wondering because right now it says

Optional: Include in one or more access filters. You must grant access to this account by selecting the first box above in order to add them to any access filters.

and then come the boxes. So I could either have two columns and title the other one with

Optional: Include in one or more reading filters. You must subscribe to this account by selecting the second box above in order to add them to any reading filters.

Easy, but boring. I was wondering if there might be anything shiny-er :)

[cesy]

Hmm. How about hiding the filters unless the box is ticked, for both types?

[kareila]

I need some S2 advice on 1773. Everything else I have assigned either has a patch awaiting review or just needs me to sit down and do a lot of work.

[gchick]

I've got a couple of things that have been hanging around too long - count me in!

[yvi]

Like the color chooser? Would require JavaScript, which I seriously suck at...

[cesy]

Mmm. Could be shiny, though.

[yvi]

Yes!

If anyone with JS knowledge wants to take it, just give shout. I am not sure I want to learn JS for this :) But I can also implement a non-shiny version first, in the interest of having the functionality.

[pauamma]

Of the ones assigned to me:
- 566 is ready to either commit or close WONTFIX (since FAQng will likely make it irrelevant).
- 405 - is it still happening? (*looks at rho*)
- 86 - I need to figure out a test case that breaks the backed-out patch. (I have one that breaks the current code, but that's not the same thing.)
- 124 - I'm plugging at it piecemeal, but that will likely be a drawn-out process.

So 566 (and maybe 405) may be closable soon, but the other 2 will have to remain open for now.

[rho]

405 is still happening, yes. Happened to me a couple of days ago. It's probably not worth investingtoo much effort into though, since we're redesigning.

[ninetydegrees]

I'm only working on the simple stuff but all but one the bugs assigned to me have a patch or depends on other patches to get reviewed and committed first. I have the patch ready for the bug I can work on but I'm waiting for a reply from one of the Bases theme makers as it changes the display of her theme and I'm not sure it's what she intended.
The other unassigned bugs are far beyond my skills except #1415 so I'll assign this one to myself.

[denise]

Did I mention how happy I am that you're developing with us? 'Cause I am!

[ninetydegrees]

:) You can thank Afuna because she held my hand through the whole thing. I'm not sure I truly understand what I'm doing - PuTTY and MQs are still quite a mystery - but it mostly does what I want it to do so...

[cesy]

Notes on bug 581, if anyone's free to help:

I have scalar %$tags which tells me the number of items in $tags, so I can construct appropriate if statements, and values %$tags gets the actual values. How can I get the values of only the first 10 items? Is there syntax to say "get the nth item from this array"? The relevant line is currently:
$out .= LJ::ehtml(join ', ', sort map { $_->{name} } values %$tags);
which gets all the items in the array.