Code tour: 2018-04-30 to 2018-07-15

[kaberett]

This code tour largely brought to you by cesy piling a bunch of us on a sofa and feeding us pizza and occasionally taking us for walks. Thank you, cesy! (And also by "whoops a code push, better make sure people know what's in it...")

Issue 2014: Syntax error from PR 2312 (pull request)
Category:
Patch by: alierak
Description: Whoops! The fix for community membership settings not saving had a typo. Now, in time for the code push, it doesn't.

Issue 2189: imzy shutting down at end of june (pull request)
Category:
Patch by: kaberett
Description: Er. That would be June 2017. HOWEVER, it's now no longer a profile field, but user tags still work.

Issue 2209: Better wording for 'no html allowed' on support request page (pull request)
Category:
Patch by: kaberett
Description: ... because what it means is "HTML will be automatically escaped, you don't gotta worry about escaping it when giving us example code", but this wasn't... obvious, at all, and confused people. I tweaked it.

Issue 2210: Allow embeds from Funny or Die (pull request)
Issue 2307: New Whitelist site requests: mixstep.co, audiomack.com, chirb.it (pull request)
Issue 2310: whitelist iframes of facebook
Issue 2317: Whitelist embeds from box.com (pull request)
Issue 2335: Whitelist embeds from lichess
Issue 2338: Whitelist embeds from Яндекс.Музыка
Issue 2339: Whitelist embeds from MSNBC
Category:
Patch by: kaberett
Description: The deal here is that, in order to be confident that embedded media is safe (that is, it won't hijack your browser or infect you with malware if you view it), Dreamwidth only allows embeds from whitelisted sites -- ones it knows it can clean up well enough to ensure nothing nasty gets through and then trodden into the carpet. Which means that if you want to embed from somewhere, and it's not on the whitelist yet, someone needs to check over the code and then... add it to the whitelist. rshatch did last code tour's batch; I did this one.

Issue 2262: Enforce new "no commas in trust group names" rule (pull request)
Category:
Patch by: chrisboyle
Description: In order to make it possible to (straightforwardly) post to multiple access filters when posting by e-mail (I'd apologise for still hyphening but I am fundamentally a reactionary luddite, so -- no, seriously, I still refuse to understand how the TV remote works), access filter names shouldn't, going forward, contain commas. This means that if you e.g. want to post something to your filters "party" and "contact" you now get syntax to do that, by sticking a comma between group names, rather than just being able to post to one access filter at once. Aaaaand I need to update the relevant FAQ once I wake up. (Trials and tribulations of being the most active volunteer in this timezone: when the site goes down on Boxing Day it's my job to call mark at 4am his local time, and also I... don't stay up for code pushes. Somewhere along the line I... grew up and got a sleep cycle? I'm deeply suspicious, and also it's past my bedtime as I type this, in case you couldn't tell.)

Issue 2304: Make the email spellcheck test a soft reject/hint instead of the hard reject it is currently. (pull request)
Category:
Patch by: chrisboyle
Description: IT'S A REALLY BAD IDEA TO REFUSE TO ACCEPT E-MAIL ADDRESSES THAT MIGHT BE CONTAIN TYPOS IN THE DOMAIN NAME WHEN THEY'RE ACTUALLY REAL E-MAIL PROVIDERS, WHOOPS. Somehow there has not, to my knowledge, been a single solitary support request about this issue since 2009? But, er, expanding the spellcheck to pick up more common typos meant we... fell face-first into this, as was very kindly pointed out in comments on a previous code tour. THANK YOU FOR READING YOU'RE ALL GREAT YOU KEEP DREAMWIDTH WORKING.

Issue 2319: Add LJ to "Other Sites" on profile? (pull request)
Category:
Patch by: kaberett
Description: In conclusion: yes. You can now (well, after the code push I'm sleeping through) add your LJ name to your profile in the dedicated Other Sites section.

Issue 2323: Beta update page userpic widget appears blank/confusing with no userpics (pull request)
Category:
Patch by: kaberett
Description: ... which is awkward and confusing, so I stared very hard at Template Toolkit and tried to remind myself how postfix conditionals work (do this UNLESS condition, rather than IF condition do this) and I thiiiiiiink I haven't broken anything? Please yell if I've broken everything. I did test and it did seem to work.

14 total issues resolved
Contributors: alierak, chrisboyle, kaberett