where to put functions

[yvi]

So, I am currently in the first stages of working on http://bugs.dwscoalition.org/show_bug.cgi?id=1574 ( "Last active entries" module) and it's actually going quite nicely :)

However, I am a bit stumped on where to put a function I need. Namely, I need a function that, depending on what journal the module is in and who is viewing it, returns the last x active entries in that journal (maybe not the full Entry objects, though, still working on that).

My first thought was cgi-bin/LJ/User.pm , as it would be good to have $u->get_recent_active($remote) or something like that. But now I am leaning more towards putting it in cgi-bin/DW/Logic/LogItems.pm , which has the functions $u->watch_items and $u->recent_items . However, my idea only semi-fits the module description.

Or maybe it should be in cgi-bin/LJ/S2.pm?

Yes, I am still confused by where to put stuff. Any ideas?

Comments

[yvi]

Okay, I have further questions (and I might comment here occasionally, if that is fine for you?):

SELECT DISTINCT * FROM talk2 WHERE journalid = ? AND state <> 'D' and state <> 'S' ORDER BY jtalkid DESC LIMIT 5;

does the trick, thank you. But only if all entries are public or the user has access to all 5 entries will all of those later show up in the list, as I will obviously discard ones that can't be viewed at a later step. So the list might come up very short for partially locked journals if we start from 5. Anyway, going through all is obviously data-base intensive, so we don't want to do that.

But, as a compromise, would it be possible to either a) pull out ten instead, or b) pull out 5 if the user is owner/maintainer and 10 if the user isn't and then narrow it down to no more than 5 later? I hope you get what I mean here. I'd just hate to see that module only come up with one entry regularly because I do think it's shiny :) [And if I had a biggish community it would totally be a reason to buy a paid community for it]

We can also do it with 5 first, though, and maybe talk about this a while after implementation again?

(You also have to make sure that whenever someone comments on an entry, you delete the 'recently_commented_posts' memcache key for the journal they're commenting on. Otherwise, the person viewing the site won't see 'live' data on that box...)

Okay, that needs to be done manually in talkpost then? memcache is a big mystery for me and I can't test it...

Yvi, lost in code and thought.

[mark]

Sure, 10 is fine.

AND state <> 'D' and state <> 'S'

Prefer AND state NOT IN ('D', 'S')

Why can't you test memcache?

[yvi]

10 it is then :)

Prefer AND state NOT IN ('D', 'S')

Oh, new syntax, shiny :) Will use.

Why can't you test memcache?

I thought it wasn't set up on the Dreamhacks?

*searches on the Wiki* Oh, I can set it up. Cool. Will contact sophie about it then.

[mark]

Yep, and memcache is pretty easy. I'll try to write up a post for dw_dev_training about how it works, how to use it, when to use it, etc. :)