Question thread #28

[pauamma]

It's time for another question thread!

The rules:

- You may ask any dev-related question you have in a comment. (It doesn't even need to be about Dreamwidth, although if it involves a language/library/framework/database Dreamwidth doesn't use, you will probably get answers pointing that out and suggesting a better place to ask.)
- You may also answer any question, using the guidelines given in To Answer, Or Not To Answer and in this comment thread.

Comments

Debugging help?

[quartzpebble]

I'm working on bug 659: https://github.com/dreamwidth/dw-free/issues/659

I added what I thought ought to be a simple extra set of conditionals to check for whether there is in fact a parent comment and whether its author is the journal owner: https://github.com/fhocutt/dw-free/blob/bug659-screened-comment-incorrect-text/htdocs/talkpost_do.bml#L237

I get the following errors on /talkpost_do on my dreamhack when I try to respond to a screened comment left by somebody else:
[Error: /dreamhack/home/8274-quartzpebble/dw/htdocs/talkpost_do.bml.text:81: Bogus format. at /dreamhack/home/8274-quartzpebble/dw/cgi-bin/LJ/Lang.pm line 592. ]

[Error: syntax error at /dreamhack/home/8274-quartzpebble/dw/htdocs/talkpost_do.bml line 227, near ") {" syntax error at /dreamhack/home/8274-quartzpebble/dw/htdocs/talkpost_do.bml line 230, near "} elsif" Global symbol "$commentu" requires explicit package name at /dreamhack/home/8274-quartzpebble/dw/htdocs/talkpost_do.bml line 230. Global symbol "$commentu" requires explicit package name at /dreamhack/home/8274-quartzpebble/dw/htdocs/talkpost_do.bml line 230. syntax error at /dreamhack/home/8274-quartzpebble/dw/htdocs/talkpost_do.bml line 232, near "} else" syntax error at /dreamhack/home/8274-quartzpebble/dw/htdocs/talkpost_do.bml line 235, near "} }" syntax error at /dreamhack/home/8274-quartzpebble/dw/htdocs/talkpost_do.bml line 280, near "; }" @ newhack.dreamwidth.net]

Google suggests that the "requires explicit package name" usually shows up when one doesn't use my, but it looks to me like $commentu is. Am I missing anything obvious?

Re: Debugging help?

[fu]

This line of code has a syntax error (unbalanced parentheses):

if ( $parentu && !($parentu->equals ( $journalu )) {

The other error messages may be red herrings -- that is, the syntax error prevents the next lines from being able to be read correctly, so they throw out misleading errors.

Re: Debugging help?

[quartzpebble]

Yay, thank you!

Some of them were; others were complaining about tabs that had snuck into talkpost_do.bml.text somehow (I really don't know what was up with that, but they're out now).

Now I get:
Post Comment
Success
on talkpost_do for a screened comment, but no message body.

Is anything else obvious here?

Re: Debugging help?

[denise]

Maybe a bit too obvious, but: have you tried running texttool.pl and restarting Apache?

Re: Debugging help?

[fu]

Lost this line!

$ret .= “<?p " . BML::ml($mlcode, {'aopts' => "href='$commentlink'"}) . " p?>”;

Re: Debugging help?

[quartzpebble]

Yay, thank you! Now I can debug the logic itself...

Re: Debugging help?

[fu]

Awesome. Good luck!