Entry tags:
Code tour, week of 7/28-8/3
Code tour!
This week we resolved 36 bugs. 3 were duplicates/invalid; the remaining 33 were fixed. All of these fixes will be live with the next code push.
Bug 420: Add separate 'email address to display on profile'
Category: Bugfix
Patch by:![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
denise
Description: The last code push added this function, but when I coded it, I forgot to update one of the text strings it was using. This was causing errors in development environments, and would've caused errors on Dreamwidth itself if not for the fact that we had the old string floating around. This patch reopened the bug and fixed it to use the proper text string.
Bug 1129: Creating a custom mood theme only allows urls of up to 101 characters
Category: Bugfix
Patch by:![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
yvi
Description: This patch extends the length for custom mood theme URLs from 101 characters to 200 characters, which should cover just about everything.
Bug 1140: Remove sysban types
Category: Code cleanup
Patch by:denise
Description: This patch removes some more unused backend code.
Bug 1340: Show FAQs without category on /admin/faq/
Category: Admin tools
Patch by:exor674
Description: This patche fixes up the admin tool that allows FAQ editors to find and edit the FAQs. Previously, any FAQ without a category wouldn't appear on the FAQ editing page (you had to go to the URL to edit it manually or go to the FAQ and pick the edit option from there); this adds category-less FAQs to the editing page.
Bug 1346: Install Perlbal XS module
Category: Sysadmin tools
Patch by:alierak
Description: This patch makes our install of Perlbal, our load balancing software, more efficient.
Bug 1384: migrate journaltype checks to use abstracted functions instead
Category: Code cleanup
Patch by:denise
Description: This patch updates a lot of code (a lot of code) to use the preferred method for checking what type a journal is (user, community, etc) and what status the journal's in (deleted, visible, suspended, etc) instead of the old way of doing it. You guys shouldn't notice any differences (and if you do, it means there's a bug, and there's bound to be some), but it makes maintaining the code easier in the future.
Bug 1388: Single-journal search
Category: Features
Patch by:mark
Description: The actual search feature went in last week, but we resolved the bug for it this week! (We forgot to resolve the bug when we pushed the code.)
Bug 1434: moderated comms UI quickfixes
Category: Bugfix
Patch by:denise
Description: This patched a bug with my UI changes from last week (it was linking to the wrong destination in the navstrip), as well as adding the moderation queue count to the navstrip.
Bug 1457: need "moderation queue" function
Category: Backend
Patch by:kareila
Description: This patch documents a new function that was added last week.
Bug 1460: Site redirects you to /login the first time you visit a page after your session expires.
Category: Bugfix
Patch by:exor674
Description: This fixes a bug where if your login session expired, but you still had a Dreamwidth cookie present in your browser, you would be redirected to /login.bml even if you were visiting a page that didn't require login.
Bug 1465: allow account creation with "promotional" codes
Category: Site administration
Patch by:janinedog
Description: This patch allows us to create 'promo' invite codes, for conferences and stuff, and then hand out that promo code instead of having to write a freaking long code with possibly-confusing letter/number combos on the back of our business cards to hand out.
Bug 1478: Misleading error message when the userproplist table contains no rows
Category: Backend cleanup
Patch by:kareila
Description: This patch gives better error messages/warnings for people who are installing the code for the first time, making it less scary.
Bug 1482: Community Management widget for the front page
Category: Usability
Patch by:afuna
Description: This patch adds a community management widget onto the front page, so we can display things like pending members, moderation queues, etc, to people who maintain communities.
Bug 1488: Tag cloud widget on front page is hard to read
Category: Usability
Patch by:afuna
Description: Changes the font color/contrast for the tag cloud on the front page.
Bug 1493: Drifting Layout Tweaks
Category: Styles
Patch by:av8rmike
Description: Fixes some of the CSS styling for the Drifting layout, in particular the list formatting on the sidebar.
Bug 1497: Reading list summary doesn't show a number when there's 0
Category: Bugfix
Patch by:kareila
Description: Fixes a bug with the front page where the reading list summary module was blank instead of showing 0 if you weren't reading any accounts of that type.
Bug 1498: "entries" does not always show plural correctly on homepage
Category: Bugfix
Patch by:afuna
Description: Fixes a pluralization problem on the homepage.
Bug 1502: Drifting has the wrong page setup on journal selection
Category: Styles bugfix
Patch by:av8rmike
Description: Fixes the Customize Journal page so that the Drifting layout displays the right layout type (2 column, left sidebar)
Bug 1503: fix code load order
Category: Backend bugfix
Patch by:kareila
Description: This fixes the order in which some libraries are loaded, which prevents a couple of errors.
Bug 1505: Add "has-navstrip" class to body tag
Category: Styles backend
Patch by:foxfirefey
Description: This patch adds a new CSS class to the <body> tag if the user viewing the journal has the navstrip turned on.
Bug 1506: Comment expansion broken on all core2 styles
Category: Bugfix
Patch by:afuna
Description: This patch corrects the Javascript used to expand collapsed comments so that it will work again.
Bug 1509: Multilevel tags function in core2 inserts many blank lines in page source
Category: Styles backend
Patch by:kaisa
Description: This patch fixes the source of individual journal pages to remove excess blank lines.
Bug 1512: Number of invite codes on "invite someone" page
Category: Usability
Patch by:denise
Description: As suggested in![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png)
dw_suggestions, this patch adds the total count of invite codes you have available to the page you see when you go to invite someone.
Bug 1518: Option to get notified by email when you send a message
Category: Usability
Patch by:denise
Description: Also viadw_suggestions, this patch adds a checkbox to the private message compose page that allows you to receive a copy of your own messages.
Bug 1519: Drifting is missing custom text input
Category: Styles backend
Patch by:av8rmike
Description: This patch adds the custom text module to Drifting.
Bug 1520: Filter List Order Not Maintained When Posting and Editing Entries
Category: Bugfix
Patch by:kareila
Description: Fixes the display of custom posting filters on the Update and Edit Entries pages so that they show in the order the user categorized them.
Bug 1522: number of participants in poll question
Category: Usability
Patch by: LiveJournal, packaged for DW byyvi
Description: This merges in LJ's addition of "number of people who have answered this poll".
Bug 1523: Customtext text options do not appear under the right heading
Category: Styles backend
Patch by:av8rmike
Description: This patch puts the custom text options of the Customize Journal page in the correct tab.
Bug 1524: Entry in edittags.bml doesn't wrap
Category: Display bugfix
Patch by:kareila
Description: Fixes a display issue on the Edit Tags page.
Bug 1534: remove LJ::alldatepart_s1
Category: Backend code cleanup
Patch by:kareila
Description: Removes unused code.
Bug 1535: Remove S1 documentation from docbook
Category: Code cleanup
Patch by:denise
Description: Removes unused code.
Bug 1536: remove "lj-replace first post"
Category: Code cleanup
Patch by:kareila
Description: Removes unused code.
Bug 1537: add more dev process info to site/opensource.bml
Category: Documentation
Patch by:denise
Description: This patch adds more information to our Open Source page (linked on the site footer) for people who are interested in Dreamwidth development.
This week we resolved 36 bugs. 3 were duplicates/invalid; the remaining 33 were fixed. All of these fixes will be live with the next code push.
Bug 420: Add separate 'email address to display on profile'
Category: Bugfix
Patch by:
deniseDescription: The last code push added this function, but when I coded it, I forgot to update one of the text strings it was using. This was causing errors in development environments, and would've caused errors on Dreamwidth itself if not for the fact that we had the old string floating around. This patch reopened the bug and fixed it to use the proper text string.
Bug 1129: Creating a custom mood theme only allows urls of up to 101 characters
Category: Bugfix
Patch by:
yviDescription: This patch extends the length for custom mood theme URLs from 101 characters to 200 characters, which should cover just about everything.
Bug 1140: Remove sysban types
Category: Code cleanup
Patch by:
deniseDescription: This patch removes some more unused backend code.
Bug 1340: Show FAQs without category on /admin/faq/
Category: Admin tools
Patch by:
exor674Description: This patche fixes up the admin tool that allows FAQ editors to find and edit the FAQs. Previously, any FAQ without a category wouldn't appear on the FAQ editing page (you had to go to the URL to edit it manually or go to the FAQ and pick the edit option from there); this adds category-less FAQs to the editing page.
Bug 1346: Install Perlbal XS module
Category: Sysadmin tools
Patch by:
alierakDescription: This patch makes our install of Perlbal, our load balancing software, more efficient.
Bug 1384: migrate journaltype checks to use abstracted functions instead
Category: Code cleanup
Patch by:
deniseDescription: This patch updates a lot of code (a lot of code) to use the preferred method for checking what type a journal is (user, community, etc) and what status the journal's in (deleted, visible, suspended, etc) instead of the old way of doing it. You guys shouldn't notice any differences (and if you do, it means there's a bug, and there's bound to be some), but it makes maintaining the code easier in the future.
Bug 1388: Single-journal search
Category: Features
Patch by:
markDescription: The actual search feature went in last week, but we resolved the bug for it this week! (We forgot to resolve the bug when we pushed the code.)
Bug 1434: moderated comms UI quickfixes
Category: Bugfix
Patch by:
deniseDescription: This patched a bug with my UI changes from last week (it was linking to the wrong destination in the navstrip), as well as adding the moderation queue count to the navstrip.
Bug 1457: need "moderation queue" function
Category: Backend
Patch by:
kareilaDescription: This patch documents a new function that was added last week.
Bug 1460: Site redirects you to /login the first time you visit a page after your session expires.
Category: Bugfix
Patch by:
exor674Description: This fixes a bug where if your login session expired, but you still had a Dreamwidth cookie present in your browser, you would be redirected to /login.bml even if you were visiting a page that didn't require login.
Bug 1465: allow account creation with "promotional" codes
Category: Site administration
Patch by:
janinedogDescription: This patch allows us to create 'promo' invite codes, for conferences and stuff, and then hand out that promo code instead of having to write a freaking long code with possibly-confusing letter/number combos on the back of our business cards to hand out.
Bug 1478: Misleading error message when the userproplist table contains no rows
Category: Backend cleanup
Patch by:
kareilaDescription: This patch gives better error messages/warnings for people who are installing the code for the first time, making it less scary.
Bug 1482: Community Management widget for the front page
Category: Usability
Patch by:
afunaDescription: This patch adds a community management widget onto the front page, so we can display things like pending members, moderation queues, etc, to people who maintain communities.
Bug 1488: Tag cloud widget on front page is hard to read
Category: Usability
Patch by:
afunaDescription: Changes the font color/contrast for the tag cloud on the front page.
Bug 1493: Drifting Layout Tweaks
Category: Styles
Patch by:
av8rmikeDescription: Fixes some of the CSS styling for the Drifting layout, in particular the list formatting on the sidebar.
Bug 1497: Reading list summary doesn't show a number when there's 0
Category: Bugfix
Patch by:
kareilaDescription: Fixes a bug with the front page where the reading list summary module was blank instead of showing 0 if you weren't reading any accounts of that type.
Bug 1498: "entries" does not always show plural correctly on homepage
Category: Bugfix
Patch by:
afunaDescription: Fixes a pluralization problem on the homepage.
Bug 1502: Drifting has the wrong page setup on journal selection
Category: Styles bugfix
Patch by:
av8rmikeDescription: Fixes the Customize Journal page so that the Drifting layout displays the right layout type (2 column, left sidebar)
Bug 1503: fix code load order
Category: Backend bugfix
Patch by:
kareilaDescription: This fixes the order in which some libraries are loaded, which prevents a couple of errors.
Bug 1505: Add "has-navstrip" class to body tag
Category: Styles backend
Patch by:
foxfirefeyDescription: This patch adds a new CSS class to the <body> tag if the user viewing the journal has the navstrip turned on.
Bug 1506: Comment expansion broken on all core2 styles
Category: Bugfix
Patch by:
afunaDescription: This patch corrects the Javascript used to expand collapsed comments so that it will work again.
Bug 1509: Multilevel tags function in core2 inserts many blank lines in page source
Category: Styles backend
Patch by:
kaisaDescription: This patch fixes the source of individual journal pages to remove excess blank lines.
Bug 1512: Number of invite codes on "invite someone" page
Category: Usability
Patch by:
deniseDescription: As suggested in
dw_suggestions, this patch adds the total count of invite codes you have available to the page you see when you go to invite someone.Bug 1518: Option to get notified by email when you send a message
Category: Usability
Patch by:
deniseDescription: Also via
dw_suggestions, this patch adds a checkbox to the private message compose page that allows you to receive a copy of your own messages.Bug 1519: Drifting is missing custom text input
Category: Styles backend
Patch by:
av8rmikeDescription: This patch adds the custom text module to Drifting.
Bug 1520: Filter List Order Not Maintained When Posting and Editing Entries
Category: Bugfix
Patch by:
kareilaDescription: Fixes the display of custom posting filters on the Update and Edit Entries pages so that they show in the order the user categorized them.
Bug 1522: number of participants in poll question
Category: Usability
Patch by: LiveJournal, packaged for DW by
yviDescription: This merges in LJ's addition of "number of people who have answered this poll".
Bug 1523: Customtext text options do not appear under the right heading
Category: Styles backend
Patch by:
av8rmikeDescription: This patch puts the custom text options of the Customize Journal page in the correct tab.
Bug 1524: Entry in edittags.bml doesn't wrap
Category: Display bugfix
Patch by:
kareilaDescription: Fixes a display issue on the Edit Tags page.
Bug 1534: remove LJ::alldatepart_s1
Category: Backend code cleanup
Patch by:
kareilaDescription: Removes unused code.
Bug 1535: Remove S1 documentation from docbook
Category: Code cleanup
Patch by:
deniseDescription: Removes unused code.
Bug 1536: remove "lj-replace first post"
Category: Code cleanup
Patch by:
kareilaDescription: Removes unused code.
Bug 1537: add more dev process info to site/opensource.bml
Category: Documentation
Patch by:
deniseDescription: This patch adds more information to our Open Source page (linked on the site footer) for people who are interested in Dreamwidth development.
no subject
Ouups ;)
(no subject)