yvi: Dreamsheep in Germany's national colors (Dreamsheep - Germany)
yvi ([personal profile] yvi) wrote in [site community profile] dw_dev2009-08-02 12:07 pm
Entry tags:

The return of the fix-it marathon

So, at the end of June, [staff profile] denise called for a fix-it marathon.

http://dw-dev.dreamwidth.org/11183.html

Let's have another one.

But let's make it two-fold:

First layer: blocking-launch

http://tinyurl.com/cjw9wk currently has 48 bugs: 21 assigned and 27 new. Let's try to bring that number down. A lot of these look scary, and some of them are not effort-minor, so I'm thinking of a bit of a low goal: by August 15, have the number of unassigned ones in there down to 15, which means 12 newly assigned. And by that time, have only 30 of the bugs left, which means 18 bugs fixed in 13 days.

(Edit: That's 'blocking-launch+', not 'blocking-launch??' or 'Target Milestone: Launch'. I am not sure which of these are the best indicators...)

I have two blocking-launch bugs assigned to me now. Who's with me?

Second layer: babydev

You're new to this whole thing? blocking-launch bugs are way over your head (and if you think that I am pretty much with you :)) by this point? But you're interested in tackling something, you just don't know what?

If you don't already have one, get yourself a Dreamhack.

The effort-minor keyword currently has 180 open, unassigned bugs. There are still a few left on my recent babydev bait post. If you want to do something and can't find anything in that list or don't know how to start, comment here or join #dw_kindergarten and I am sure there are people there including me who can help you find a bug to tackle and then tackling it.

And remember, this is just a suggestion. No-one is under any obligation to do any of this. I just thought it would be nice to get some of these bugs out of the way. :)
foxfirefey: A fox colored like flame over an ornately framed globe (Default)

[personal profile] foxfirefey 2009-08-02 05:32 pm (UTC)(link)
If you don't want to go through all the trouble of setting up a Dreamhack and whatnot, which is kind of overkill for the bug we're talking about, you can just make the changes that are necessary in the S2 layer and give it to me and I'll generate a patch for you to submit. (But if you *want* a Dreamhack and all that jazz, feel free to do that, too.)

(Of course, the above is all assuming you know where to go from there, ie, copy the public layout layer and go to town and whatnot, but if you need more instructions, you just let me know.)
Edited 2009-08-02 17:36 (UTC)
ninetydegrees: Art: self-portrait (Default)

[personal profile] ninetydegrees 2009-08-02 05:45 pm (UTC)(link)
I don't know if I want one because I don't know exactly what's it's for and I don't know if I'll need it to try to fix other bugs and whether I'll be able to, anyway.

Fixing this depends on how the designer intended their layout to look like. You could either change the link colors which would be changing:

set color_footer_text = "#ffeba6";
set color_footer_link = "#ffffff";


or change the background color of the footer module which would be adding:

.module-section-three .module {
background-color: $*color_footer_background;
}

to function print_stylesheet. I think the latter is what was originally intended.
sophie: A cartoon-like representation of a girl standing on a hill, with brown hair, blue eyes, a flowery top, and blue skirt. ☀ (Default)

[personal profile] sophie 2009-08-02 05:55 pm (UTC)(link)
I don't know if I want one because I don't know exactly what's it's for...

More reasons to have a better wiki page! Okay, I'll explain.

A Dreamhack is essentially your own private installation of Dreamwidth. It's intended for development use - so you shouldn't use it to start your own journalling site, for example - but it includes everything you need to run it already in the package. In fact, after you get a Dreamhack, you can start it up just by typing one command in its SSH console: 'start-apache'. Everything else - the setup of libraries, etc - has all been done for you, leaving you able to concentrate on hacking on the code itself.

Does that help?
Edited 2009-08-02 17:56 (UTC)
foxfirefey: A fox colored like flame over an ornately framed globe (Default)

[personal profile] foxfirefey 2009-08-02 06:03 pm (UTC)(link)
But does she really need an entire Dreamhack just to work with S2? S2 changes and tests can be made on DW.org itself, or anybody else's Dreamhack one has an account on with style privileges.

She may/may not know about SSH, but I can tell you that a lot of the people wanting to work in styles with S2 or CSS won't, and trying to learn how to use a Dreamhack is the kind of thing that might only be appetizing after one is doing enough developing to make all that learning worth the investment. And it's not just learning how to use SSH, a person has to learn how to keep a Dreamhack updated, and sometimes that can run into interesting issues. (See: recent perlbal repository change.)
ninetydegrees: Art: self-portrait (Default)

[personal profile] ninetydegrees 2009-08-02 08:01 pm (UTC)(link)
Would a Dreamhack allow me to avoid the s2id stuff to work on styles? And to easily switch from logged in/logged out view? Or from personal journal to community to other account types?

Also, I don't know if I 'just' want to work with S2. I'm willing to learn anything but I have no idea if I could be able to.

foxfirefey: A fox colored like flame over an ornately framed globe (Default)

[personal profile] foxfirefey 2009-08-02 05:57 pm (UTC)(link)
So, if we added a color_footer_background, which I think is a good idea, what default would that be?

And what would you want those link colors change to?
ninetydegrees: Art: self-portrait (Default)

[personal profile] ninetydegrees 2009-08-02 06:46 pm (UTC)(link)
$*color_footer_background already exists. It's the orange color.

I don't know if the link colors should be changed because I don't know how much contrast is needed. The current colors which are used are yellow for text and white for links. The yellow color is the same which is used for the links of the navigation menu. Nobody remarked on this being hard to read so... The only possible issue I can think of is that the footer uses the reversed scheme: yellow for text, white for links as I said. Having yellow for links in the top menu and for text in the footer menu may be confusing. Or not.
av8rmike: (styles)

[personal profile] av8rmike 2009-08-03 02:21 am (UTC)(link)
Having a Dreamhack to work on styles stuff isn't necessary. I don't have one, but what I *do* have is a local copy of our "s2team" repository, to which I can commit patches. All you really need is Mercurial and a copy of one of the repositories so that you can generate patch files.
av8rmike: Text: Dreamwidth volunteer (dw_volunteer)

[personal profile] av8rmike 2009-08-03 04:12 pm (UTC)(link)
I could after I figure out how to get it working myself! ;) However, Afuna and I were just talking last night about how to re-structure the s2team Dreamhack and maybe discontinue committing to our own repository to better unify our workflows.
ninetydegrees: Art: self-portrait (Default)

[personal profile] ninetydegrees 2009-08-03 08:38 am (UTC)(link)
Maybe you can answer my questions then.

The words you speak are English and yet I didn't understand any of them. :)
av8rmike: Futurama's Bender in Jeffries tube, text: I'm done reconfoobling the energymotron (energymotron)

[personal profile] av8rmike 2009-08-03 04:27 pm (UTC)(link)
I don't know if I can satisfactorily answer those questions, but I suspect the answer to all three is "no". The reason being: you can't do any of those things on the main DW site, and a Dreamhack is just your own personal "sandbox" copy of the DW code.
The advantage to using a Dreamhack is that you won't be messing with your main journal style or have to make gibberish entries in your main journal-- you can just make your test entries there where no one but you has to see them. Am I making sense? You can feel free to e-mail me if you have more questions if you prefer not to take up more comment space here.
ninetydegrees: Art: self-portrait (Default)

[personal profile] ninetydegrees 2009-08-03 05:03 pm (UTC)(link)
I see what you mean. It's exactly what LJ had at some point and lots of layout makers used then. That's one big advantage.

I do have more questions as you didn't explain what you mentioned in your previous comments. I have no problem with commenting here but maybe you do since you suggested it. Y/N?
afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)

[personal profile] afuna 2009-08-03 05:07 pm (UTC)(link)
Hm, actually for dreamhacks you can append an ?as=user to be logged in as that user. Compare:

http://www.afuna.dreamhack.afunamatata.com/
http://www.afuna.dreamhack.afunamatata.com/?as=commandline

There are a few other things, but I think most of the rest don't affect styles testing.
afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)

[personal profile] afuna 2009-08-03 05:11 pm (UTC)(link)
There's also http://www.afuna.dreamhack.afunamatata.com/?as=

to force being a logged out user

(It doesn't work after you do a form post, but for everytihng else...!)

(no subject)

[personal profile] afuna - 2009-08-03 17:16 (UTC) - Expand
afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)

[personal profile] afuna 2009-08-03 05:08 pm (UTC)(link)
Oh, if it's just CSS stylesheets though, there's the [personal profile] style_kit (but I think that fey's probably already pointed you to that resource!)
ninetydegrees: Art: self-portrait (Default)

[personal profile] ninetydegrees 2009-08-03 05:22 pm (UTC)(link)
You mean the_style_kit?
ninetydegrees: Art: self-portrait (Default)

[personal profile] ninetydegrees 2009-08-03 05:31 pm (UTC)(link)
That wouldn't have really helped with the 'bug' I was talking about, I think. Well, it could but it seems to me it would be a convoluted way of finding a solution to something which is very simple and can be tested with a few lines in a layer.
av8rmike: (watching elljay comments)

[personal profile] av8rmike 2009-08-03 05:23 pm (UTC)(link)
(And see, I was partially wrong with my other answers!)
I just didn't want to add to thread/comment bloat, since we're getting kind of off topic, but ask away!
ninetydegrees: Art: self-portrait (Default)

[personal profile] ninetydegrees 2009-08-03 05:28 pm (UTC)(link)
Is there a better comm to ask these questions?

As I said, I didn't understand what you meant when you said: "I don't have one, but what I *do* have is a local copy of our "s2team" repository, to which I can commit patches. All you really need is Mercurial and a copy of one of the repositories so that you can generate patch files."
av8rmike: Dalek with text: EXPLAIN EXPLAIN (explain)

[personal profile] av8rmike 2009-08-03 07:16 pm (UTC)(link)
I'd have suggested [site community profile] dw_styles, but since that comm has limited posting access, here we are.

Anyway, Mercurial is the version control system Dreamwidth is using. There's a page on the Wiki that provides a little more information about it, but it's basically a distributed system with multiple repositories instead of just one (like LJ uses). About six months ago, [personal profile] afuna set up a Dreamhack for the Styles team to use, complete with its own repository. This made sense because there were 6-8 of us on the team working with different components of Core2, so we all needed commit access. We could all kick stuff around without disrupting the "main" repository.
However, there aren't as many of us doing active S2 development now, so we're not really using the s2team repository any more. As I mentioned up-thread to [personal profile] yvi, I'll probably need to try setting up a development environment and follow the established workflow for generating patch files. Am I making sense?
ninetydegrees: Art: self-portrait (Default)

[personal profile] ninetydegrees 2009-08-03 10:19 pm (UTC)(link)
You mean like this? I never noticed the name of the software DW uses. My apologies.
You are. Thanks for the explanation.