Azure Jane Lunatic (Azz) 🌺 (![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
azurelunatic) wrote in ![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png)
dw_dev2013-11-24 03:19 pm
azurelunatic) wrote in dw_dev2013-11-24 03:19 pm
Entry tags:
Code tour: October 16 to November 24, 2013 (no seriously, it was just 2012 and now we're nearly '14)
There's a code push coming up in just under 6 hours tonight!
9 patches in this code tour! (So far, unless Momiji sneaks one in under the wire.) 10! 10 patches!
Executive summary: Themes for 3 styles, a fix for that random profile-collapsed-sections thing, a fix for the seriously long comment hierarchy indicators not wrapping, and some miscellaneous non-journal-area (inbox, recent comments, and site pages) tweaks.
Patches frommomijizukamori, hotlevel4, and fu, themes from dancing_serpent, forests_of_fire, and timeasmymeasure, and guest starring suggestions and miscellaneous bugwork from ninetyd, misskat, ladyasul, cesy, ![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
denise, and chronologically last but certainly never least, exor674. PLUS exor674'S LAST-MINUTE PATCH WHEE
Bug 5271: Strata: new themes
Category: Style System
Patch by:momijizukamori
Theme by:dancing_serpent
Description: New themes! Get your new themes here! We've got Strata!
Bug 5273: Crisped: new themes
Category: Style System
Patch by:momijizukamori
Theme by:forests_of_fire
Description: We've got Crisped! So many new themes!
Bug 5274: Patsy: new themes
Category: Style System
Patch by:momijizukamori
Theme by:timeasmymeasure
Description:momijizukamori: YOU GET A THEME, AND *YOU* GET A THEME, AND EVERYONE GETS A THEME!
Bug 4866: Profiles: collapse feature broken and/or inconsistent
Category: Misc UI/Frontend
Patch by:momijizukamori
Description: So people were reporting that their preferences for which profile sections to leave collapsed were not sticking, in inconsistent and weird ways. It turned out that the information on which sections to collapse were being held in a data structure that was 255 characters long. A keen observer of profiles may observe that the names of the various sections of the profile together add up to more than 255 characters. Thus the information loss and the weird inconsistency. The data structure has been replaced with something nicely larger (blobchar, for those who care). Unfortunately this means that everybody's collapsed settings are going to be lost one final time when the code push goes live, but AFTER THAT, once you get the profile's expanded/collapsed state to your liking, it should stick.
Bug 4960: group comment hierarchy numbers into batches, adding spaces
Category: Misc UI/Frontend
Suggested by:ladyasul
Patch by:hotlevel4
Description: So a common problem with threaded comments is that it can be really hard to tell what's in reply to what. Most solutions depend on visual displays. Dreamwidth's solution to this problem is a little hierarchial numbering thing you can turn on if you like that sort of thing. But in seriously long threads, a 326 character comment hierarchy indicator can cause side-scrolling or even truly and sincerely break a style. Using spaces to bust it up into 10-character chunks should make things a lot more readable if and when threads do get that deep. (WE NEED TO GO DEEPER!)
Bug 4257: Show number of flagged items
Category: Inbox/Notifications
Suggested by:cesy
Patch by:hotlevel4
Description: The inbox didn't show the number of unread flagged items despite having numbers for a lot of other different unread stuff. Now it will.
Bug 5284: Terms of Service has lost DMCA policy link
Category: Site Administration
Patch by:fu
Description: It's fun to do the DMCA! It's fun to do the -- actually, no, the YMCA is a lot more fun, plus it's pretty hard to do the D thing quickly enough with your arms. But the Terms of Service page does need a link to the page with the details on what happens when Dreamwidth does have to interact with a Digital Millennium Copyright Act complaint.
Bug 3395: Split up recent comments page to allow more comments
Category: Misc UI/Frontend
Suggested by:cesy
Patch by:hotlevel4
Description: The Recent Comments page can be really useful. If you select the maximum number (150 for premium-paid), though, the page can get really big really fast especially with Dreamwidth's generous comment size limits, which is a potentially big problem on a mobile device. Splitting it into separate tabs for comments received and comments posted will ease the strain on mobile, and help people get to what they were looking for faster. Win all around.
Bug 5287: JavaScript on inbox page broken
Category: Misc UI/Frontend
Catch by:exor674
Patch reverted by:fu
Description: One of Fu's recent changes to the JavaScript in the inbox proved to screw things up royally. There was just too much to try and figure out, so the wisest thing to do was just put it back the way it was before it was fixed.
Bug 5280: LWPx::ParanoidAgent will not read https:// data
Category: Misc Backend
Patch by:exor674
Description: Dreamwidth uses some external bits of code for stuff, although the original copyright was by![[livejournal.com profile]](https://www.dreamwidth.org/img/external/lj-userinfo.gif)
brad in '05. This bit deals with https:// stuff. Anyway, stuff was going wrong when attempting to create feed accounts from https:// sources, and the problem was traced to a bug in the external code. So Dre did stuff, both on our end and as a bug report to their end, and now it should be all good again, on both fronts.
Executive summary: Themes for 3 styles, a fix for that random profile-collapsed-sections thing, a fix for the seriously long comment hierarchy indicators not wrapping, and some miscellaneous non-journal-area (inbox, recent comments, and site pages) tweaks.
Patches from
momijizukamori, hotlevel4, and fu, themes from dancing_serpent, forests_of_fire, and timeasmymeasure, and guest starring suggestions and miscellaneous bugwork from ninetyd, misskat, ladyasul, cesy, denise, and chronologically last but certainly never least, exor674. PLUS exor674'S LAST-MINUTE PATCH WHEEBug 5271: Strata: new themes
Category: Style System
Patch by:
momijizukamoriTheme by:
dancing_serpentDescription: New themes! Get your new themes here! We've got Strata!
Bug 5273: Crisped: new themes
Category: Style System
Patch by:
momijizukamoriTheme by:
forests_of_fireDescription: We've got Crisped! So many new themes!
Bug 5274: Patsy: new themes
Category: Style System
Patch by:
momijizukamoriTheme by:
timeasmymeasureDescription:
momijizukamori: YOU GET A THEME, AND *YOU* GET A THEME, AND EVERYONE GETS A THEME!Bug 4866: Profiles: collapse feature broken and/or inconsistent
Category: Misc UI/Frontend
Patch by:
momijizukamoriDescription: So people were reporting that their preferences for which profile sections to leave collapsed were not sticking, in inconsistent and weird ways. It turned out that the information on which sections to collapse were being held in a data structure that was 255 characters long. A keen observer of profiles may observe that the names of the various sections of the profile together add up to more than 255 characters. Thus the information loss and the weird inconsistency. The data structure has been replaced with something nicely larger (blobchar, for those who care). Unfortunately this means that everybody's collapsed settings are going to be lost one final time when the code push goes live, but AFTER THAT, once you get the profile's expanded/collapsed state to your liking, it should stick.
Bug 4960: group comment hierarchy numbers into batches, adding spaces
Category: Misc UI/Frontend
Suggested by:
ladyasulPatch by:
hotlevel4Description: So a common problem with threaded comments is that it can be really hard to tell what's in reply to what. Most solutions depend on visual displays. Dreamwidth's solution to this problem is a little hierarchial numbering thing you can turn on if you like that sort of thing. But in seriously long threads, a 326 character comment hierarchy indicator can cause side-scrolling or even truly and sincerely break a style. Using spaces to bust it up into 10-character chunks should make things a lot more readable if and when threads do get that deep. (WE NEED TO GO DEEPER!)
Bug 4257: Show number of flagged items
Category: Inbox/Notifications
Suggested by:
cesyPatch by:
hotlevel4Description: The inbox didn't show the number of unread flagged items despite having numbers for a lot of other different unread stuff. Now it will.
Bug 5284: Terms of Service has lost DMCA policy link
Category: Site Administration
Patch by:
fuDescription: It's fun to do the DMCA! It's fun to do the -- actually, no, the YMCA is a lot more fun, plus it's pretty hard to do the D thing quickly enough with your arms. But the Terms of Service page does need a link to the page with the details on what happens when Dreamwidth does have to interact with a Digital Millennium Copyright Act complaint.
Bug 3395: Split up recent comments page to allow more comments
Category: Misc UI/Frontend
Suggested by:
cesyPatch by:
hotlevel4Description: The Recent Comments page can be really useful. If you select the maximum number (150 for premium-paid), though, the page can get really big really fast especially with Dreamwidth's generous comment size limits, which is a potentially big problem on a mobile device. Splitting it into separate tabs for comments received and comments posted will ease the strain on mobile, and help people get to what they were looking for faster. Win all around.
Bug 5287: JavaScript on inbox page broken
Category: Misc UI/Frontend
Catch by:
exor674Patch reverted by:
fuDescription: One of Fu's recent changes to the JavaScript in the inbox proved to screw things up royally. There was just too much to try and figure out, so the wisest thing to do was just put it back the way it was before it was fixed.
Bug 5280: LWPx::ParanoidAgent will not read https:// data
Category: Misc Backend
Patch by:
exor674Description: Dreamwidth uses some external bits of code for stuff, although the original copyright was by
brad in '05. This bit deals with https:// stuff. Anyway, stuff was going wrong when attempting to create feed accounts from https:// sources, and the problem was traced to a bug in the external code. So Dre did stuff, both on our end and as a bug report to their end, and now it should be all good again, on both fronts.