Code Tour: July 19 - August 24

[meludame]

Howdy folks, this is your code tour operator speaking. Please fasten your seat belts and stay safe during lift off. For entertainment during our flight you have access to 33 different patches by mark (3), ninetyd (8), kareila (3), exor674 (8), misskat (1), momijizukamori (3), meludame (2), deborah (1), hotlevel4 (3) and fu (1).

Bug 1036: maintenance on should have maint page in journalspace too
Category: Misc Backend
Patch by: mark
Description: Before, we the site went into maintenance mode for code pushes visiting example.dw.org would give a generic error page, while visiting www.dw.org would give a more informative "site down temporarily for maintenance". That has since been fixed!

Bug 5160: remove old unreferenced beta from pre-fork
Category: Misc Backend
Patch by: ninetyd
Description: A few pages made references to an old, outdated, LJ beta. ninetyd took the code machete and pruned those references from the code.

Bug 5212: can't do basic Perl compile check due to implied dependencies
Category: Misc Backend
Patch by: kareila
Description: A portion of the code didn't explicitly call the Perl modules it required to work properly. It got away with it because other bits of the DW code base already loaded those modules. Now it does load those modules itself and we don't run the risk of it failing because it's been called from an unexpected place.

Bug 110: Mod hat
Category: Misc UI/Frontend
Patch by: exor674
Description: Community admins and moderators can now use a ticky to don their lovely top hats whenever posting as the ultimate (local) authority. Very dapper, don't you think?

Bug 5218: FeedCanonicalizer does not handle http://users.livejournal.com/ correctly
Category: Feeds
Patch by: exor674
Description: In some rare cases the Feed handler would attribute the wrong token to a feed causing incorrect matches to be made for those feeds. exor674 fixed it :)

Bug 5219: speed up 00-compile.t
Category: Testing
Patch by: kareila
Description: We were using a very slow way to test for the presence of Perl modules. Instead now we have a very fast way of doing it!

Bug 5224: Update feed token generator for Twitter's removal of feeds
Category: Feeds
Patch by: exor674
Description: Earlier this year Twitter removed the RSS feeds from its site so exor674 grabbed the code machete and pruned off the bit of code that handled those feeds since it wasn't needed anymore.

Bug 5208: Mobility: background images differ notably from original submission
Category: Style System
Patch by: ninetyd
Description: The background images of two Mobilty themes were off compared to the original submission. ninetyd re-uploaded those so that they matched the originals.

Bug 5228: Compile styles/theme checklist
Category: Wiki documentation
Patch by: misskat
Description: Our lovely misskat compiled a list of things to check for (resources attribution, display in all style views, correct use of properties, and more...) at the attention of styles and theme patchers, to make their work easier. Thanks misskat!

Bug 5127: Bannering: more userpic overlapping
Category: Style System
Patch by: momijizukamori
Description: In Bannering sometimes the userpic overlapped the usernames in the comment section. momijizukamori has now fixed the issue :)

Bug 5206: Check modhat styling in all styles
Category: Style System
Patch by: momijizukamori
Description: momijizukamori tweaked the modhat feature further, giving it its own CSS class for independant styling and moved it inside the .poster span to group it with the poster's username.

Bug 5229: Tectonic comment-poster needs left padding
Category: Style System
Patch by: momijizukamori
Description: In Tectonic when no icon were selected for a comment the poster's username would come glue itself to the left side of the container, momijizukamori modified the style's CSS so that it wouldn't happen anymore.

Bug 5210: Summertime/Fresh Air: use correct bkg color
Category: Style System
Patch by: ninetyd
Description: In Summertime, the Fresh Air theme had the wrong color for the page's background. ninetyd changed it to the correct color.

Bug 5215: Mobility: various fixes
Category: Style System
Patch by: ninetyd
Description: Mobility needed some more tweaking to make it look like it should. ninetyd rose to the occasion and made it so :)

Bug 5231: Make the 'api' role a proper routing role.
Category: Routing/TT
Patch by: exor674
Description: As exor674 puts it:

Okay, so mark did a *thing*, except he did it in a quick and hacky way that wasn't really in line with how the routing system was supposed to work.
So I made it better!

Bug 4942: Summertime: new themes
Category: Style System
Patch by: ninetyd
Description: This patch adds 12 new themes for the Summertime style.

Bug 5235: Mobility: set module-jump-link color & move props to propgroup
Category: Style System
Patch by: ninetyd
Description: Some of Mobility properties weren't where they should have been, so ninetyd moved them and made sure the description used more standard phrasing. She also set the jump link color in order for those to be readable.

Bug 5234: Core2: hiding navigation when empty means noentries text isn't printed
Category: Style System
Patch by: ninetyd
Description: Hiding the navigation jump-links (previous/next X posts) on a journal page prevented the "no entries" message to be displayed when there was no entries to print. This patch makes sure that message is printed regardless of the jump-links presence.

Bug 5103: Pass final URL into token generator for fuzzy feed matching
Category: Feeds
Patch by: exor674
Description: When someone adds a new RSS feed to Dreamwidth the feed handler does a check for duplicates. The check was not quite complet so exor674added in what was missing. Less feed duplicates, hurray!

Bug 5135: image resizing
Category: Misc UI/Frontend
Patch by: mark
Description: that does image resizing for the sake of image uploads via the web browser. It means when you upload an image, youl'l be able to get it in multiple sizes automatically.

Bug 5138: Add metadata for media
Category: Misc Backend
Patch by: mark
Description: This patch adds the ability to store metadata such as size, description, alt text, credit information,... about the media (just images for now) uploaded for posts.

Bug 5175: Not all layouts display journal subtitle
Category: Style System
Patch by: meludame
Description: Some of the older styles didn't display the journal's subtitle (and sometimes not even the title) even though the option seemed to be here on the customize page. This has now been fixed!

Bug 1706: New Style: Snakes & Boxes
Category: Style System
Patch by: ninetyd
Description: A new style with 6 themes.

Bug 2977: Brittle: some borders in #tertiary bigger than container
Category: Style System
Patch by: meludame
Description: Three of the footer modules in Brittle broke out of the footer a little. This has now been corrected and now those modules will keep themselves inside the footer as they should.

Bug 5173: no alt text on dreamwidth logo
Category: Misc UI/Frontend
Patch by: deborah
Description: The Dreamwidth logo had no alt-text. Now, thanks to deborah it does.

Bug 5239: Manage Subscriptions page broken, undefined value
Category: Importer
Patch by: exor674
Description: Two of exor674's previous patches disagreed with each other and broke the manage subscription pag. exor674 went back in the fray and forced them to behave.

Bug 5147: Move legacy comment notifications to ESN
Category: Inbox/Notifications
Patch by: exor674
Description: The ESN (short for Event/Subscription/Notification), also known as the bit of code that handle sending the notifications to either your email inbox, your Dreamwidth inbox or both, has been expanded to handle entries posted in communities as well as any comments. Once this is live you'll be able to decide where you want those notifications to end up \o/

Bug 5205: admin/mod-hat posts/comments should be indicated in notification emails
Category: Inbox/Notifications
Patch by: exor674
Description: Notifications of "mod-hat" comments and posts will be labelled appropriately to mark them as such.

Bug 5241: TOS assumes that invite codes are required
Category: Invite codes
Patch by: kareila
Description: Now that invite codes are longer required to created an account the TOS have been updated to reflect that change.

Bug 5238: Manage Logins has stopped working
Category: Misc UI/Frontend
Patch by: fu
Description: The manage logins page was no longer working, fu fixed it :)

Bug 5243: double header on support/stock_answers.bml
Category: Site Administration
Patch by: hotlevel4
Description: Support has some stock answers for really common issues that had two sections of header text. Since that was one header too many, the code machete was wielded to remove one of the extraneous headers.

Bug 5181: Calling "prop" on undefined value
Category: Misc UI/Frontend
Patch by: hotlevel4
Description: The contextual hover, when hovering over a deleted journal would silently fail to display the reason of deletion when it wasn't defined. Now it tests whether a reason exists and displays "no reason given" if not.

Bug 4750: Tag-count overrun produces confusing error message when adding tags to entry.
Category: Tags
Patch by: hotlevel4
Description: Sometimes running the importer makes it possible to import tags over one's account limit. When this happened, trying to add new tags would result in a confusing error message. This patch rewords the error message into something clearer to avoid the confusion.


This concludes our code tour, thank you for flying Air Dreamwidth, we hope you have enjoyed your flight ;-)

Comments

[kaberett]

Congrats on (a) the code tour, and (b) having bugs in it! :D

& congrats also to hotlevel4, who I believe is a first-timer on the code tour :-)

[cesy]

Hooray for alt text and more work towards image hosting and more ESN! :)

[marahmarie]

When do these bugfixes go live? Still getting 5238 just as I originally reported - with error message, "Sorry, there was a problem".

[denise]

Next code push, whenever that winds up being. It'll be announced in dw_maintenance, as usual.

[marahmarie]

Could there possibly be clearer delineation in the future between the two? Maybe I'm assuming, but I tend to think maybe I'm not the only one who associates Code Tour with Code Push on some sort of subconscious level. When I see "Code Tour" I tend to wonder if the changes have already gone live without something in the Code Tour post to warn us they have not.

(Also, I have a vested interest in seeing this bugfix go live because 90 is, as far as I know, awaiting credit on the Support ticket I filed for it, which I'm not closing until I know the problem is fixed.)