How to request code review

[swaldman]

The new feature that I've been working on (tweeting about new entries) is ready for initial code review. However, it is definitely not ready to be landed into develop yet. How should I request this review?

I haven't created a pull request, because it's not ready to land.
I can't flag it as needs-review on bugzilla, because there is no attachment - I could put it into an attachment, but I imagine that commenting on the commit on github is easier for all concerned...

Any ideas or preferences? :-)

Comments

[alierak]

Not really a preference, but I can see one possible kludge: put the commit URL in a bugzilla attachment and flag that?

ETA: The thing is, I'm not sure if anyone is looking at that flag in Bugzilla anymore. Committers will definitely do code review before merging a pull request though.

[fu]

Hmm, no I don't any longer. There's old stuff there that I need to clear out, but it's been taking a pretty low priority, and I'm not likely to notice any new things in there.

[mark]

Do a pull request and just specify in it "this is not ready to land".

That is the review process. :)

[fu]

Yup, agreed!

[swaldman]

OK!
Will do this later today :-)