foxfirefey: A picture of GIR. (gir)
foxfirefey ([personal profile] foxfirefey) wrote in [site community profile] dw_dev2012-11-09 03:08 pm
Entry tags:

Best way to review pull requests

So, as far as I can tell from my researching over the past few days, the only real way to get a pull request to review it is to:

* Manually add the submitter's dw-* repo as a remote in the repo on your hack (or Github I suppose, but there is no GUI advantage here).
* Manually pull the branch in question

Is there a better way to do this? Am I missing something? This seems really, well, annoying, with manually crafting URLs and whatnot, and not very user friendly. (I'm trying to make some documents on reviewing pull requests for people who are not [personal profile] fu, since we need to try and spread out that work a little.)
cdybedahl: (Default)

[personal profile] cdybedahl 2012-11-10 10:01 am (UTC)(link)
You don't have to add the URL of the repo with the pull request in it as a remote. It's enough to give it on the command line when doing "git pull". If you get the announce emails that GitHub sends out when a pull request is made, there is a line in there that you can cut-n-paste and run locally to get the suggested changes into a local repo of your own.