Reminder: when making changes to Core2 check all styles please

[ninetydegrees]

If you make any change to Core2 --frontend but also backend, please check whether this also affects any of our official styles and open a bug for them if you don't want to update them as part of your own bug. It's the only way to make sure everything stays up-to-date and functional, and only requires a simple 'grep -ril'. :)

Comments

[swaldman]

oops.
*looks sheepish*
*hopes it wasn't him breaking something that prompted this* ;-)

[momijizukamori]

If it makes you feel better I thought the same thing *g* 'Shit, did I do something?'

[swaldman]

*grin* well, it did make me look at a pull request that I had in and realise that I was *about* to break something (at least, fix something in core and leave Database behind). So the post was worthwhile!

[ninetydegrees]

Yeah, that was the spirit of my post! It's not so much about breaking things but about not leaving styles behind as you said. Any change related to S2 can potentially affect 40 styles and over 1,000 themes and tracking changes becomes much harder as time passes and they pile on.