Entry tags:
Code tour: September 6 to September 25, 2011
It's time for another code tour! This one stretches the past 19 days and contains 31 bugs, with patches from
ninetydegrees,
rb,
kareila,
fu,
sophie,
allen,
pauamma,
skakri and
emclaughlin.
None of these patches are live yet except for bug 3923, which affected the create flow.
Bug 3849: Poll creator: use the word "response" instead of "option"
Category: Journal contents
Suggested by:
ninetydegrees
Patch by:
ninetydegrees
Description: When creating a poll with the Poll Creator and using radio buttons or check boxes, it refers to the possible answers as "options". That's a bit confusing, especially when it asks you things like "Minimum options required". This bug fixes that and calls them "responses" instead!
Bug 3887: user tag should alias archiveofourown.org to ao3.org
Category: Misc UI/Frontend
Suggested by:
niqaeli
Patch by:
rb
Description: archiveofourown.org, while a wonderful site, is a pretty long name to type for the site="" parameter in a <user> tag. Since they also have the ao3.org domain, it was suggested that we should allow that name instead, so now we can. :D
Bug 2866: Attach a note when transferring points
Category: Payments
Suggested by:
yvi
Patch by:
kareila
Description: Dreamwidth uses a 'points' system for buying paid accounts and such in the shop, which makes it possible to buy points and transfer them to other people. Trouble is, there was no way to actually tell the recipient why they were getting the points. Now you can supply some text on the transfer screen which will be sent to the recipient in the email notification!
Bug 3921: Reply links still shown on comment pages, even when we've hit maxcomments
Category: Journal contents
Patch by:
fu
Description: When you look at an entry that has the maximum number of comments allowed on it (which I believe is 5000 comments), you're not supposed to see the Reply link because there wouldn't be any point in replying. This was working for the Recent Entries page on a journal, but not when you linked to an entry directly. Now it works for both cases. :)
Bug 3923: Account creation page title not displaying correctly
Category: Registration
Patch by:
fu
Description: When we forked Dreamwidth from LiveJournal, we didn't carry over the create account process; instead, we created our own version. However, in doing so we started using a string that LiveJournal had decided to drop in their own create process and had marked as a 'dead phrase', which resulted in our Create page not having a title. We resurrected it and pushed it live.
Bug 3893: RTE uses LJ-style userhead instead of DW-style userhead
Category: Misc UI/Frontend
Suggested by:
beatrice_otter
Patch by:
sophie
Description: The button in the RTE to make a link to another user had an LJ userhead in its icon instead of the DW one. Since we aren't LiveJournal, we replaced it with an icon that was a bit more fitting.
Bug 1474: Add view=flat to comment pages
Category: Misc UI/Frontend
Suggested by:
hahnsrockstar
Patch by:
allen
Description: There's a little-known method you can use to view the comments on a post in strict chronological order without threading, which involves adding "?view=flat" or "&view=flat" to an entry URL. It's a useful thing to be able to do, so
allen added a link to it above where the comments normally print. Actually, he did a lot more than that, because...
Bug 1872: Collapse comments
Category: Journal contents
Suggested by:
susanreads
Patch by:
allen
Description: ...he also added an option to let you hide comment subthreads that you'd previously expanded with the "Expand" link! Actually, he added this ability for all comment subthreads; you don't need to have expanded them first. I understand that's a bit confusing, so I'll try to explain it a bit better. Comments that have been replied to will now have an link to hide those replies (or show them if they were previously hidden), which will also hide/show any further subthreads on those, etc. While there isn't a specific "Collapse" link for expanded subthreads (so you can't re-collapse an expanded subthread), you will be able to click on the link in the comment to hide the replies completely.
allen did both of these bugs in the same patch as...
Bug 3298: Option to view top level comments only
Category: Journal contents
Suggested by:
lightgetsin
Patch by:
allen
Description: ...this bug, which utilises the aforementioned reply-hiding functionality to allow people to view just the top-level comments on any entry. This will show up as a link next to the one made for the ?view=flat mode above the comments (see two bugs up to bug 1474), and to view the replies to a comment you'll need to click the link on the comment to show the replies. This should prove quite handy for things like friending memes and such!
Bug 2838: Pruning deleted/purged accounts from communities
Category: Communities
Suggested by:
jecook
Patch by:
kareila
Description: When an account is deleted, it can be undeleted for a guaranteed time of up to 30 days. After that time, it's subject to purging, which removes their journal entries from the database, although the account remains so that other comments are identified as belonging to the right username. However, it can be odd to see a community that has members whose accounts have been purged by account deletion! This patch adds a button that community admins can click on to quickly review the purged users in their community and remove their membership. (This doesn't affect users who are in 'deleted' status but have not yet been purged.)
Bug 939: allow people to choose whether or not to be notified on crosspost
Category: Crossposter
Patch by:
kareila
Description: Those of us who crosspost their entries to other sites get a notification in our site Inbox every single time we post to say so, even if it worked properly. This patch allows us to turn off the notification of successful crossposts, thereby saving our inboxes. (Failures will still be sent regardless.) The bug also sets this as the default behaviour, so new accounts won't have to turn it off themselves.
Bug 2215: member list page: "jump to account" does not jump to username
Category: Communities
Patch by:
kareila
Description: The "Jump to account" box on a community admin's member list page for a community didn't work quite as advertised - it would find you the *page* that an account was on, but didn't get any more specific than that. Since each page can have up to 100 members on it, this was less than optimal.
kareila changed it to a "Search for account" box instead, thereby making it a lot easier to use.
Bug 3935: apply new member list "jump to" logic to sentinvites.bml
Category: Communities
Patch by:
kareila
Description: The problem that occurred in the previous bug also occurred in the community admin "sent invites" page (which is unrelated to the invite code system; this is for inviting people who are already on Dreamwidth to join a community). The same
kareila applied the same fix, and now it works just like the members list.
Bug 3934: Add Business::CreditCard to checkconfig.pl
Category: Site Administration
Patch by:
sophie
Description: Testing payment-related bugs can be difficult if you don't have the relevant Perl modules. In this case we were using a module in the code that wasn't checked for by the script used to tell site owners if their configuration is okay. As a result, the Dreamhack machines didn't have the module on them. Oops. I installed the module and added a check to the code so that future developers wouldn't fall into the same trap.
Bug 3937: Fix pasto in DW::Controller::EventOutput header
Category: Misc Backend
Patch by:
pauamma
Description: One of the files in our codebase had comments saying it was a different file. While we fully support diversity here at Dreamwidth, we were pretty sure that this was a copy-and-paste error rather than a truly different identity. We fixed the comment and updated the copyright notice to include this year while we were at it.
Bug 3932: remove htdocs/settings/index.bml
Category: Misc Backend
Patch by:
kareila
Description: When we forked from LJ, the settings pages were all over the place. Brad's solution to this was to create a page with a 'tag cloud' of settings.Our solution was to clean up the settings pages and bring them all into a coherent whole. [edited: Actually, LJ made that change first, not us - we pulled it in later. They still had the separate tag cloud page, though.] As a result, the tag cloud page was left to bitrot. Having discovered some non-working items in it recently, and since we now have an organised Settings page and don't need the tag cloud any more, we decided to nuke it. (The page now redirects to our main Settings page.)
Bug 3928: create new promo code should have 'active' box checked
Category: Site Administration
Patch by:
rb
Description: While most of us only get one-time-use invite codes,
denise and
mark have the ability to create "promo codes" which can be used over and over again, making them easier to hand out at conferences, to give to community admins to migrate their communities, and so on. Trouble is, when they create new promo codes, they have to specifically remember to activate them, or else they won't work. This patch makes it so the "Active" box is ticked by default when creating promo codes, so that our co-owners don't have to go back and activate the codes if they forget to tick it.
Bug 2836: Prevent OpenID relationships from cluttering profile pages
Category: Circle/Relationships
Suggested by:
martzin
Patch by:
kareila
Description: Because OpenID names are based on URLs, they tend to be longer than most Dreamwidth usernames, and they can crowd out the access lists on profile pages. This patch will,if there are more than 3 OpenID accounts in the access lists on the profile, separate out the OpenID accounts into another part and also display them in a shorter fashion, if possible, grouped by service. [edit: The patch that went in will do this regardless of how many OpenID accounts there are. Sorry, I misread the bug!]
Bug 1461: English-strip cgi-bin/LJ/Support.pm
Category: English-Stripping
Patch by:
ninetydegrees
Description: Hardcoded English text in the codebase is a bad thing, because it means that our site copy team can't change the text easily to suit the site, and it also makes it harder for any other Dreamwidth-based sites to use any languages other than English. This patch strips the hardcoded text from one of our files.
Bug 3931: unused page: htdocs/community/transfer
Category: Modernization
Patch by:
fu
Description: Waaaay back in the day, long before Dreamwidth was even a twinkle in the founders' eyes, community accounts on LiveJournal used to have passwords, and you could log into them just like any other account. When LJ switched to having community maintainers, they had a page that you could use if you had the community's password, which would transfer the community to your control, set your account as a maintainer, and then remove the community password. Fast-foward to today, and it turns out we still had that page in our code repository, even though it did precisely nothing (because it's a guarantee that none of our communities have passwords). So we nuked it. B'bye.
Bug 3930: remove unused translation files
Category: Modernization
Patch by:
kareila
Description: Remember up there in bug 3923 with the Create page title and the 'dead phrase'? Well, this is kind of the other way round. This time, we had some unused strings which weren't in use any more, so we removed them and added them as 'dead phrases'.
Bug 3941: uninitialized values in LJ::S2Theme
Category: Misc Backend
Patch by:
kareila
Description:
karzilla NOTICE UNINITIALISED VARIABLE WARNING. WARNINGS BAD.
karzilla SMASH.
Bug 3943: Relative urls for privacy tool
Category: Journal contents
Patch by:
skakri
Description: When we forked from LJ, we worked hard to clean up any hardcoded references to LJ in any output that would be seen by people using the site. Turns out we accidentally included a hardcoded reference to DW of our own in one case, which would have resulted in other sites having to clean up our own mess. Oops! Fixed.
Bug 3942: Fix "unitialized value" warning in LJ::Sysban
Category: Misc Backend
Patch by:
pauamma
Description: PAUZILLA NOTICE UNINITIALISED VARIABLE WARNING... ohh wait, wrong bug. Same idea, though!
Bug 1580: Visibility of information and who can view information on profile page
Category: Misc UI/Frontend
Suggested by:
elizabeth_rice
Patch by:
kareila and
emclaughlin
Description: Although you can set certain information on your profile to be viewable by registered users only or friends only, it wasn't signified on the profile page what those settings were, so people looking at it might accidentally spread the information to someone who wasn't supposed to have access to that. Now the profile page sports nifty little icons (with appropriate alt text, of course) to say what the security level is for profile information which allow for different security levels.
Bug 3947: Spellcheck causes segfaults when used within a controller
Category: Routing/TT
Patch by:
fu
Description: While continuing work on getting the new Update page ready for primetime,
fu discovered a problem with the way spellchecks were carried out which would have meant that they wouldn't work properly on the new page. With this patch, though, it's no longer a problem!
Bug 3948: Styles: 'Header image' is misleading: it's header background image
Category: Style System
Patch by:
ninetydegrees
Description: When a "header image" doesn't push the text down and instead lets the text go over it, it's not a header image at all; it's a header background image. Unfortunately, we were calling it a header image in our style customisation wizard. This patch updates it to use the proper terminology.
Bug 3927: add number of month to name of month on cc field
Category: Payments
Patch by:
rb
Description: Springing out of a discussion in dw_accessibility, the expiration dates on credit cards are almost always printed using two digits each for the month and the year, but we were using month names in our credit card payment page, forcing people to have to convert the number on their card into a name. This patch modifies the list so that instead of "January", "February", and so on, the list displays "January - 01", "February - 02", and so on. (The name still comes first so that people can use the keyboard to type the first letter and go to the appropriate month.)
Bug 1202: Images with undefined sizes setting causes a placeholder even when placeholder setting is for "nothing"
Category: Misc UI/Frontend
Patch by:
rb
Description: If you had set the options in the Image Placeholders section of the Display settings tab to display all images but to treat undefined-size images as large, then Dreamwidth would erroneously replace undefined-size images with a placeholder, even though you had selected not to see any. This fixes the problem.
Bug 3905: In-page text refers to "Reading List" instead of "Reading Page" at several points.
Category: Misc UI/Frontend
Patch by:
rb
Description: In various places around the site, we were using the term "reading list" when we meant "reading page". In some cases, these could even be simplified further; "Add <username> to your reading list" is better expressed as "Subscribe to <username>", for example. This patch fixes up all of these issues!
Bug 3856: Site-styled entry pages: turn subject into clean link
Category: Journal contents
Suggested by:
ninetydegrees
Patch by:
fu
Description: When displaying an entry in the site skin (as opposed to a journal style), the title of the entry wasn't linked to go back to the entry itself, making it more difficult to share entries with others. This patch adds the link and makes sure it has no URL parameters on it, allowing for easy copying and pasting.
And... that's it for another code tour! Please ride again with us soon :)
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
None of these patches are live yet except for bug 3923, which affected the create flow.
Bug 3849: Poll creator: use the word "response" instead of "option"
Category: Journal contents
Suggested by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: When creating a poll with the Poll Creator and using radio buttons or check boxes, it refers to the possible answers as "options". That's a bit confusing, especially when it asks you things like "Minimum options required". This bug fixes that and calls them "responses" instead!
Bug 3887: user tag should alias archiveofourown.org to ao3.org
Category: Misc UI/Frontend
Suggested by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: archiveofourown.org, while a wonderful site, is a pretty long name to type for the site="" parameter in a <user> tag. Since they also have the ao3.org domain, it was suggested that we should allow that name instead, so now we can. :D
Bug 2866: Attach a note when transferring points
Category: Payments
Suggested by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Dreamwidth uses a 'points' system for buying paid accounts and such in the shop, which makes it possible to buy points and transfer them to other people. Trouble is, there was no way to actually tell the recipient why they were getting the points. Now you can supply some text on the transfer screen which will be sent to the recipient in the email notification!
Bug 3921: Reply links still shown on comment pages, even when we've hit maxcomments
Category: Journal contents
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: When you look at an entry that has the maximum number of comments allowed on it (which I believe is 5000 comments), you're not supposed to see the Reply link because there wouldn't be any point in replying. This was working for the Recent Entries page on a journal, but not when you linked to an entry directly. Now it works for both cases. :)
Bug 3923: Account creation page title not displaying correctly
Category: Registration
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: When we forked Dreamwidth from LiveJournal, we didn't carry over the create account process; instead, we created our own version. However, in doing so we started using a string that LiveJournal had decided to drop in their own create process and had marked as a 'dead phrase', which resulted in our Create page not having a title. We resurrected it and pushed it live.
Bug 3893: RTE uses LJ-style userhead instead of DW-style userhead
Category: Misc UI/Frontend
Suggested by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: The button in the RTE to make a link to another user had an LJ userhead in its icon instead of the DW one. Since we aren't LiveJournal, we replaced it with an icon that was a bit more fitting.
Bug 1474: Add view=flat to comment pages
Category: Misc UI/Frontend
Suggested by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: There's a little-known method you can use to view the comments on a post in strict chronological order without threading, which involves adding "?view=flat" or "&view=flat" to an entry URL. It's a useful thing to be able to do, so
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Bug 1872: Collapse comments
Category: Journal contents
Suggested by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: ...he also added an option to let you hide comment subthreads that you'd previously expanded with the "Expand" link! Actually, he added this ability for all comment subthreads; you don't need to have expanded them first. I understand that's a bit confusing, so I'll try to explain it a bit better. Comments that have been replied to will now have an link to hide those replies (or show them if they were previously hidden), which will also hide/show any further subthreads on those, etc. While there isn't a specific "Collapse" link for expanded subthreads (so you can't re-collapse an expanded subthread), you will be able to click on the link in the comment to hide the replies completely.
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Bug 3298: Option to view top level comments only
Category: Journal contents
Suggested by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: ...this bug, which utilises the aforementioned reply-hiding functionality to allow people to view just the top-level comments on any entry. This will show up as a link next to the one made for the ?view=flat mode above the comments (see two bugs up to bug 1474), and to view the replies to a comment you'll need to click the link on the comment to show the replies. This should prove quite handy for things like friending memes and such!
Bug 2838: Pruning deleted/purged accounts from communities
Category: Communities
Suggested by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: When an account is deleted, it can be undeleted for a guaranteed time of up to 30 days. After that time, it's subject to purging, which removes their journal entries from the database, although the account remains so that other comments are identified as belonging to the right username. However, it can be odd to see a community that has members whose accounts have been purged by account deletion! This patch adds a button that community admins can click on to quickly review the purged users in their community and remove their membership. (This doesn't affect users who are in 'deleted' status but have not yet been purged.)
Bug 939: allow people to choose whether or not to be notified on crosspost
Category: Crossposter
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Those of us who crosspost their entries to other sites get a notification in our site Inbox every single time we post to say so, even if it worked properly. This patch allows us to turn off the notification of successful crossposts, thereby saving our inboxes. (Failures will still be sent regardless.) The bug also sets this as the default behaviour, so new accounts won't have to turn it off themselves.
Bug 2215: member list page: "jump to account" does not jump to username
Category: Communities
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: The "Jump to account" box on a community admin's member list page for a community didn't work quite as advertised - it would find you the *page* that an account was on, but didn't get any more specific than that. Since each page can have up to 100 members on it, this was less than optimal.
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Bug 3935: apply new member list "jump to" logic to sentinvites.bml
Category: Communities
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: The problem that occurred in the previous bug also occurred in the community admin "sent invites" page (which is unrelated to the invite code system; this is for inviting people who are already on Dreamwidth to join a community). The same
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Bug 3934: Add Business::CreditCard to checkconfig.pl
Category: Site Administration
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Testing payment-related bugs can be difficult if you don't have the relevant Perl modules. In this case we were using a module in the code that wasn't checked for by the script used to tell site owners if their configuration is okay. As a result, the Dreamhack machines didn't have the module on them. Oops. I installed the module and added a check to the code so that future developers wouldn't fall into the same trap.
Bug 3937: Fix pasto in DW::Controller::EventOutput header
Category: Misc Backend
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: One of the files in our codebase had comments saying it was a different file. While we fully support diversity here at Dreamwidth, we were pretty sure that this was a copy-and-paste error rather than a truly different identity. We fixed the comment and updated the copyright notice to include this year while we were at it.
Bug 3932: remove htdocs/settings/index.bml
Category: Misc Backend
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: When we forked from LJ, the settings pages were all over the place. Brad's solution to this was to create a page with a 'tag cloud' of settings.
Bug 3928: create new promo code should have 'active' box checked
Category: Site Administration
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: While most of us only get one-time-use invite codes,
![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
Bug 2836: Prevent OpenID relationships from cluttering profile pages
Category: Circle/Relationships
Suggested by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Because OpenID names are based on URLs, they tend to be longer than most Dreamwidth usernames, and they can crowd out the access lists on profile pages. This patch will,
Bug 1461: English-strip cgi-bin/LJ/Support.pm
Category: English-Stripping
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Hardcoded English text in the codebase is a bad thing, because it means that our site copy team can't change the text easily to suit the site, and it also makes it harder for any other Dreamwidth-based sites to use any languages other than English. This patch strips the hardcoded text from one of our files.
Bug 3931: unused page: htdocs/community/transfer
Category: Modernization
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Waaaay back in the day, long before Dreamwidth was even a twinkle in the founders' eyes, community accounts on LiveJournal used to have passwords, and you could log into them just like any other account. When LJ switched to having community maintainers, they had a page that you could use if you had the community's password, which would transfer the community to your control, set your account as a maintainer, and then remove the community password. Fast-foward to today, and it turns out we still had that page in our code repository, even though it did precisely nothing (because it's a guarantee that none of our communities have passwords). So we nuked it. B'bye.
Bug 3930: remove unused translation files
Category: Modernization
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Remember up there in bug 3923 with the Create page title and the 'dead phrase'? Well, this is kind of the other way round. This time, we had some unused strings which weren't in use any more, so we removed them and added them as 'dead phrases'.
Bug 3941: uninitialized values in LJ::S2Theme
Category: Misc Backend
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description:
![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
Bug 3943: Relative urls for privacy tool
Category: Journal contents
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: When we forked from LJ, we worked hard to clean up any hardcoded references to LJ in any output that would be seen by people using the site. Turns out we accidentally included a hardcoded reference to DW of our own in one case, which would have resulted in other sites having to clean up our own mess. Oops! Fixed.
Bug 3942: Fix "unitialized value" warning in LJ::Sysban
Category: Misc Backend
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: PAUZILLA NOTICE UNINITIALISED VARIABLE WARNING... ohh wait, wrong bug. Same idea, though!
Bug 1580: Visibility of information and who can view information on profile page
Category: Misc UI/Frontend
Suggested by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Although you can set certain information on your profile to be viewable by registered users only or friends only, it wasn't signified on the profile page what those settings were, so people looking at it might accidentally spread the information to someone who wasn't supposed to have access to that. Now the profile page sports nifty little icons (with appropriate alt text, of course) to say what the security level is for profile information which allow for different security levels.
Bug 3947: Spellcheck causes segfaults when used within a controller
Category: Routing/TT
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: While continuing work on getting the new Update page ready for primetime,
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Bug 3948: Styles: 'Header image' is misleading: it's header background image
Category: Style System
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: When a "header image" doesn't push the text down and instead lets the text go over it, it's not a header image at all; it's a header background image. Unfortunately, we were calling it a header image in our style customisation wizard. This patch updates it to use the proper terminology.
Bug 3927: add number of month to name of month on cc field
Category: Payments
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Springing out of a discussion in dw_accessibility, the expiration dates on credit cards are almost always printed using two digits each for the month and the year, but we were using month names in our credit card payment page, forcing people to have to convert the number on their card into a name. This patch modifies the list so that instead of "January", "February", and so on, the list displays "January - 01", "February - 02", and so on. (The name still comes first so that people can use the keyboard to type the first letter and go to the appropriate month.)
Bug 1202: Images with undefined sizes setting causes a placeholder even when placeholder setting is for "nothing"
Category: Misc UI/Frontend
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: If you had set the options in the Image Placeholders section of the Display settings tab to display all images but to treat undefined-size images as large, then Dreamwidth would erroneously replace undefined-size images with a placeholder, even though you had selected not to see any. This fixes the problem.
Bug 3905: In-page text refers to "Reading List" instead of "Reading Page" at several points.
Category: Misc UI/Frontend
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: In various places around the site, we were using the term "reading list" when we meant "reading page". In some cases, these could even be simplified further; "Add <username> to your reading list" is better expressed as "Subscribe to <username>", for example. This patch fixes up all of these issues!
Bug 3856: Site-styled entry pages: turn subject into clean link
Category: Journal contents
Suggested by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: When displaying an entry in the site skin (as opposed to a journal style), the title of the entry wasn't linked to go back to the entry itself, making it more difficult to share entries with others. This patch adds the link and makes sure it has no URL parameters on it, allowing for easy copying and pasting.
And... that's it for another code tour! Please ride again with us soon :)
no subject
OH THANK YOU. I always have to check that address a dozen times to make sure it's right. This will go so much more smoothly.
Lots of awesome patches in this update! Yay!
no subject
It is always really kind of awesome to see a suggestion of yours get implemented. I love Dreamwidth so much.
no subject
Not that it will now, but at least it won't pretend that it will any more! :D
no subject
no subject
no subject
no subject