Drew M.C. (![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
dreamatdrew) wrote in ![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png)
dw_dev2011-02-17 03:31 am
dreamatdrew) wrote in dw_dev2011-02-17 03:31 am
Entry tags:
Code Tour: Feb 06, 2011 - Feb 17, 2011
Hola, and welcome to the Dreamwidth code tour! We have 17 bugs marked resolved since 2011-02-06, including a first-time contrib from mmmpork. (Seems like just a couple tours ago she was leading us. Oh how quickly we move on.) At any rate, saddle up, lets get movin...
Bug 852: Atom Publishing Protocol Implementation Out of Date
Category: APIs: Atom, Keeping up with all of the kids
Patch by:fu
Description: Back in the day, LiveJournal wrote their own Atom feed builder. Sadly, it wasn't actually building legal Atom for the API anymore. (They were writing a draft version that doesn't work anymore.) The custom implementation has been ganked and we're now using a standard Atom builder, which makes this problem go buhbie, and you can once again use AtomAPI to update your journal.
Bug 2294: Move /interface/atom into DW::Routing
Category: Orginization-fu
Patch by:fu
Description: The instructions the server was using to figure out what you mean when asking for an Atom feed were not where the instructions for what you mean when you ask for anything else. The instructions were moved, and now more stuff is where it should be. (Also,fu gets the "Two bugs with one patch" Achievement for this one. Just, you know, as an aside.)
Bug 3418: Allow iframe tags for YouTube embed
Category: Journal contents
Patch by:fu
Description: Youtube changed what you have to do to embed videos. Unfortunately, it uses iframes, a potential security risk which was being stripped from entries. This patch lets iframes that come from youtube survive the stripping process. (fu also gets the "Above and Beyond" Achievement for putting in place a way we can allow this from other places without having to dig through too much code. Gogo Gadget Fu.)
Bug 2304: Add ability for Template Toolkit site-schemes to DW::Template
Category: DIE BML DIE!
Patch by:exor674
Description: In a continuation of the efforts to get rid of BML, site-schemes can now use Template Toolkit instead. Which is shiny.
Bug 60: Update bin/checkconfig.pl
Category: Site Administration/Installation
Patch by:mmmpork
Description: Inmmmpork's first time on the code tour, it's kind of apropos that she be making sure checkconfig.pl, which is what one uses when installing or upgrading the code base, checks to make sure that everything you need to actually use the code is in place. (Welcome to the club, Auggy!)
Bug 2018: Enhancements to "find users with similar interests"
Category: Search
Suggested by:yvi
Patch by:kareila
Description: Lots of enhancements to the "find users with similar interests" page, including not having deleted users show up, excluding people you already are subscribed to, and separating accounts by type (user, OpenID, and community).
Bug 1608: red text hardcoded into tropo-purple headings on community settings page
Category: Site Layout/Navigation; Bugfix
Patch by:wychwood
Description: Tropospherical Purple and Celerity were using the wrong colors on the community settings page for headings. Said headers have been re-dyed, and now match.
Bug 1951: Border colors in Select Journal Style (/customize) don't match theme
Category: Misc UI/Frontend
Patch by: The Server Elves
Description: This was actually fixed a while ago, but nobody realized till now. See, it's true what they say about good news traveling slowly. (Yes, this is a handwave, we aren't sure how it got fixed either, but it did, and that's the important part...)
Bug 3506: 'xpost_accounts' CAP missing in config.pl for permanent level
Category: Misc Backend/Configuration
Patch by:fu
Description: This little flag sets how many accounts you can crosspost to. For some reason, it was not set in the default configuration. Now it is. (Note: this doesn't actually affect Dreamwidth.org. It has been set here since crossposting went live, so sayeth the![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
denise.)
Bug 3509: "published" time in single-item atom feed is incorrect
Category: Feeds
Patch by:fu
Description: More Atom hijinks: when you retrieved the Atom version of a single entry, the timestamp was from the future. Since our servers are not on Gallefry, that is not possible. Fu taught the Atom code how to tell time.
Bug 3510: /data/userpics throwing a 500 error
Category: Feeds
Patch by:fu
Description: More cleanup of Atom. When the Atom generator got changed, some things were still expecting the old way, and got confused. We have explained the change, and now they work happily.
Bug 3511: Duplicate xmlns attributes in atom feeds
Category: Feeds
Patch by:fu
Description: Even more cleanup of Atom. This time, things got shifted out of order when Fu did her thing, which again caused confusion, and broke the parser. Fu explained what was going on, and it got better.
Bug 3443: Funky Circles: some updates needed due to recent changes
Category: Style System
Patch by:ninetydegrees
Description: Recent changes made Funky Circles not look quite like it was supposed to. So,ninetydegrees re-worked it to make it look right again.
Bug 3508: Front page needs text for when $LJ::USE_ACCT_CODES is off
Category: Frontend/Promotional Stuff
Patch by:sophie
Description: This replaces the information about needing an invite code with a message explaining that you don't need one for the moment, and a adds a switch to turn it on and off. It's for the Invite-Free Week promotion thingamabob coming up.
Bug 3512: [Error: Undefined custom element 'SEARCHCSS'] when viewing FAQs
Category: Misc UI/Frontend
Patch by:fu
Description: Fu is great. We love Fu. But she's not perfect, and she missed something during a "clean ALL the CSS" run. Sophie caught it, Fu fixed it, and all is well.
Bug 3445: editjournal.bml: missing UL on success page when entry's crossposted
Category: Misc UI/Frontend
Patch by:ninetydegrees
Description: When an entry's been crossposted there's an additional message on the success page of edit entry. This message was displaying weirdly. Fixed now.
Bug 3120: Styles: 8 NaNoWriMo themes
Category: Styles
Description: Actually, this is kinda old news. These styles have been live for a while, this was just housekeeping in bugzilla. (So sayeth thefu.)
That's it for this round. Everything in this list aside from Bug 3445 should be live now.
mmmpork. (Seems like just a couple tours ago she was leading us. Oh how quickly we move on.) At any rate, saddle up, lets get movin...Bug 852: Atom Publishing Protocol Implementation Out of Date
Category: APIs: Atom, Keeping up with all of the kids
Patch by:
fuDescription: Back in the day, LiveJournal wrote their own Atom feed builder. Sadly, it wasn't actually building legal Atom for the API anymore. (They were writing a draft version that doesn't work anymore.) The custom implementation has been ganked and we're now using a standard Atom builder, which makes this problem go buhbie, and you can once again use AtomAPI to update your journal.
Bug 2294: Move /interface/atom into DW::Routing
Category: Orginization-fu
Patch by:
fuDescription: The instructions the server was using to figure out what you mean when asking for an Atom feed were not where the instructions for what you mean when you ask for anything else. The instructions were moved, and now more stuff is where it should be. (Also,
fu gets the "Two bugs with one patch" Achievement for this one. Just, you know, as an aside.)Bug 3418: Allow iframe tags for YouTube embed
Category: Journal contents
Patch by:
fuDescription: Youtube changed what you have to do to embed videos. Unfortunately, it uses iframes, a potential security risk which was being stripped from entries. This patch lets iframes that come from youtube survive the stripping process. (
fu also gets the "Above and Beyond" Achievement for putting in place a way we can allow this from other places without having to dig through too much code. Gogo Gadget Fu.)Bug 2304: Add ability for Template Toolkit site-schemes to DW::Template
Category: DIE BML DIE!
Patch by:
exor674Description: In a continuation of the efforts to get rid of BML, site-schemes can now use Template Toolkit instead. Which is shiny.
Bug 60: Update bin/checkconfig.pl
Category: Site Administration/Installation
Patch by:
mmmporkDescription: In
mmmpork's first time on the code tour, it's kind of apropos that she be making sure checkconfig.pl, which is what one uses when installing or upgrading the code base, checks to make sure that everything you need to actually use the code is in place. (Welcome to the club, Auggy!)Bug 2018: Enhancements to "find users with similar interests"
Category: Search
Suggested by:
yviPatch by:
kareilaDescription: Lots of enhancements to the "find users with similar interests" page, including not having deleted users show up, excluding people you already are subscribed to, and separating accounts by type (user, OpenID, and community).
Bug 1608: red text hardcoded into tropo-purple headings on community settings page
Category: Site Layout/Navigation; Bugfix
Patch by:
wychwoodDescription: Tropospherical Purple and Celerity were using the wrong colors on the community settings page for headings. Said headers have been re-dyed, and now match.
Bug 1951: Border colors in Select Journal Style (/customize) don't match theme
Category: Misc UI/Frontend
Patch by: The Server Elves
Description: This was actually fixed a while ago, but nobody realized till now. See, it's true what they say about good news traveling slowly. (Yes, this is a handwave, we aren't sure how it got fixed either, but it did, and that's the important part...)
Bug 3506: 'xpost_accounts' CAP missing in config.pl for permanent level
Category: Misc Backend/Configuration
Patch by:
fuDescription: This little flag sets how many accounts you can crosspost to. For some reason, it was not set in the default configuration. Now it is. (Note: this doesn't actually affect Dreamwidth.org. It has been set here since crossposting went live, so sayeth the
denise.)Bug 3509: "published" time in single-item atom feed is incorrect
Category: Feeds
Patch by:
fuDescription: More Atom hijinks: when you retrieved the Atom version of a single entry, the timestamp was from the future. Since our servers are not on Gallefry, that is not possible. Fu taught the Atom code how to tell time.
Bug 3510: /data/userpics throwing a 500 error
Category: Feeds
Patch by:
fuDescription: More cleanup of Atom. When the Atom generator got changed, some things were still expecting the old way, and got confused. We have explained the change, and now they work happily.
Bug 3511: Duplicate xmlns attributes in atom feeds
Category: Feeds
Patch by:
fuDescription: Even more cleanup of Atom. This time, things got shifted out of order when Fu did her thing, which again caused confusion, and broke the parser. Fu explained what was going on, and it got better.
Bug 3443: Funky Circles: some updates needed due to recent changes
Category: Style System
Patch by:
ninetydegreesDescription: Recent changes made Funky Circles not look quite like it was supposed to. So,
ninetydegrees re-worked it to make it look right again. Bug 3508: Front page needs text for when $LJ::USE_ACCT_CODES is off
Category: Frontend/Promotional Stuff
Patch by:
sophieDescription: This replaces the information about needing an invite code with a message explaining that you don't need one for the moment, and a adds a switch to turn it on and off. It's for the Invite-Free Week promotion thingamabob coming up.
Bug 3512: [Error: Undefined custom element 'SEARCHCSS'] when viewing FAQs
Category: Misc UI/Frontend
Patch by:
fuDescription: Fu is great. We love Fu. But she's not perfect, and she missed something during a "clean ALL the CSS" run. Sophie caught it, Fu fixed it, and all is well.
Bug 3445: editjournal.bml: missing UL on success page when entry's crossposted
Category: Misc UI/Frontend
Patch by:
ninetydegreesDescription: When an entry's been crossposted there's an additional message on the success page of edit entry. This message was displaying weirdly. Fixed now.
Bug 3120: Styles: 8 NaNoWriMo themes
Category: Styles
Description: Actually, this is kinda old news. These styles have been live for a while, this was just housekeeping in bugzilla. (So sayeth the
fu.)That's it for this round. Everything in this list aside from Bug 3445 should be live now.
no subject