![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png){kind=small}
![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png){kind=small}
Entry tags:
Code Tour: 14 October to 20 October
Hello everyone! This is a code tour. There are many like it, but this one is mine.
Behind the cut: 18 bugs for your perusal! As always, these fixes won't be live until the next code push. Also, no new contributors this week, but props go to![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
alierak for being the only man in the code tour this week. *G* (I think it's so funny that the gender balance on DW is tipped the other direction from most of the rest of the open source world!)
Bug 3128: allow promo codes to have attached paid time
Category: Site Administration
Patch by:exor674
Description: As part of businessy type promotion things, I decided that it was time for promo codes (the things we can give out so that people can create X number of accounts with a single code) to be able to be preloaded with paid time. Dre was awesome and picked it up immediately.
Bug 1761: Eliminate Class::Autouse from the code
Category: Unknown
Patch by:kareila
Description: KARZILLA, MODERNIZER OF CODE, strikes again. This removes a *mumble* that we don't need anymore because of *mumble* and *mumble*.
Bug 2030: create/setup.bml sends multiple subscription/access ESN if interests error
Category: Registration
Patch by:kareila
Description: This fixes a bug that's been annoying me for a while: if you enter invalid interests when creating your accounts, the system fires multiple notifications of the new account subscribing/granting access to you. It was a very bizarre bug.
Bug 3037: Modish: unreadable text in comments in some themes
Category: Style System
Patch by:ninetydegrees
Description: This fixes some CSS so that several Modish themes no longer have unreadable text.
Bug 3069: Fluid Measure: text unreadable in comment headers in several themes
Category: Style System
Patch by:ninetydegrees
Description: This fixes some CSS so that several Fluid Measure themes no longer have unreadable text.
Bug 3078: Styles: refactor the CSS styling of the navlinks module to remove the absolute positioning in some styles
Category: Style System
Patch by:ninetydegrees
Description: Absolute positioning can be bad in many cases! (And can be useful in others.) This removes it in places where it was no longer necessary.
Bug 3013: clear-my-answers link for polls
Category: Journal contents
Patch by:yvi
Description: So, how many times have you voted in a poll and then decided afterwards that you want to clear your answers, except you can't uncheck a radio button once you've checked it. It happens to me all the time. It annoyed me so much that I opened a bug for it, and now (okay, with the next code push) you will be able to clear your answers from a poll.
Bug 1677: Remember the option for "Disable Auto-Formatting"
Category: Misc UI/Frontend
Patch by:fu
Description: We actually added this a while ago, but there was some debate about whether we should make changes to the implementation. We decided against it! And so the bug is closed now.
Bug 2922: redirect m.dreamwidth.org to dreamwidth.org/mobile
Category: Site Layout/Navigation
Patch by:alierak
Description: This is a config change, so if you access m.dreamwidth.org it will redirect you. (Yay for shorter typing.)
Bug 2229: update cgi-bin/LJ/ConfCheck/General.pm
Category: Misc Backend
Patch by:kareila
Description: The process of installing DW on your own server is arcane and poorly documented. (We're working on fixing it, really!) As part of the improvements, this updates a script that runs on install to check your configuration, so that the options are better documented and the ones that don't get used anymore are removed.
Bug 2588: Don't announce upcoming birthdays for deleted journals
Category: Inbox/Notifications
Patch by:kareila
Description: This changes the birthday notification code so that birthdays of deleted journals aren't announced anymore, since there's nothing more annoying than getting notified of a birthday for someone who isn't even using the site anymore!
Bug 2830: Add Ravelry as a profile external site
Category: Misc UI/Frontend
Patch by:kareila
Description: DW attracts tons of crafty people! (Which makes me so happy, you have no idea.) As part of our drive to increase the tools available for people who do non-writing type creative things, we're adding Ravelry as an "external site" for the profile.
Bug 1845: Cumulative layout credits
Category: Style System
Patch by:ninetydegrees
Description: This will make it easier to show cumulative layout credits -- like, if the base layout is by one person, and the theme is by another, this will now show both names. This way everyone gets credit!
Bug 2942: Funky Circles: create new color props for easier customizing + correct some colors
Category: Style System
Patch by:ninetydegrees
Description: This exposes some new properties in the wizard in Funky Circles for changing the colors in the Calendar and Search modules. It also corrects some colors that were used in error.
Bug 3134: missing string /manage/circle/filter.bml.title2
Category: English-Stripping
Patch by:ninetydegrees
Description: So, when you viewed the Manage Filters page, there was a missing string. Now there is not!
Bug 3136: Make it easy to look up what the notification will look like (dev servers only)
Category: Site Administration
Patch by:fu
Description: This makes it easier for people who are doing DW development to see what a notification will look like, since running the notification system on dev installs is annoying and tedious and a pain in the ass.
Bug 3153: Gradation vertical/horizontal footer overlaps into content when all content is floated
Category: Misc UI/Frontend
Patch by:fu
Description: Fixes a bug in the Gradation site schemes where certain CSS in entries would cause the footer to migrate its way into the contents of the page.
Bug 3147: Cannot approve posts in moderated communities for users on dversion 9
Category: Misc Backend
Patch by:exor674
Description: ....Oops. So, when we changed things around to make icon keyword renaming easier, we made a mistake that made it impossible for people to approve posts in moderated comms, which we found out as we started moving people over to the new system. A quick fix byexor674 and a quick teeny code push by fu means that it's fixed in production now.
Behind the cut: 18 bugs for your perusal! As always, these fixes won't be live until the next code push. Also, no new contributors this week, but props go to
alierak for being the only man in the code tour this week. *G* (I think it's so funny that the gender balance on DW is tipped the other direction from most of the rest of the open source world!)Bug 3128: allow promo codes to have attached paid time
Category: Site Administration
Patch by:
exor674Description: As part of businessy type promotion things, I decided that it was time for promo codes (the things we can give out so that people can create X number of accounts with a single code) to be able to be preloaded with paid time. Dre was awesome and picked it up immediately.
Bug 1761: Eliminate Class::Autouse from the code
Category: Unknown
Patch by:
kareilaDescription: KARZILLA, MODERNIZER OF CODE, strikes again. This removes a *mumble* that we don't need anymore because of *mumble* and *mumble*.
Bug 2030: create/setup.bml sends multiple subscription/access ESN if interests error
Category: Registration
Patch by:
kareilaDescription: This fixes a bug that's been annoying me for a while: if you enter invalid interests when creating your accounts, the system fires multiple notifications of the new account subscribing/granting access to you. It was a very bizarre bug.
Bug 3037: Modish: unreadable text in comments in some themes
Category: Style System
Patch by:
ninetydegreesDescription: This fixes some CSS so that several Modish themes no longer have unreadable text.
Bug 3069: Fluid Measure: text unreadable in comment headers in several themes
Category: Style System
Patch by:
ninetydegreesDescription: This fixes some CSS so that several Fluid Measure themes no longer have unreadable text.
Bug 3078: Styles: refactor the CSS styling of the navlinks module to remove the absolute positioning in some styles
Category: Style System
Patch by:
ninetydegreesDescription: Absolute positioning can be bad in many cases! (And can be useful in others.) This removes it in places where it was no longer necessary.
Bug 3013: clear-my-answers link for polls
Category: Journal contents
Patch by:
yviDescription: So, how many times have you voted in a poll and then decided afterwards that you want to clear your answers, except you can't uncheck a radio button once you've checked it. It happens to me all the time. It annoyed me so much that I opened a bug for it, and now (okay, with the next code push) you will be able to clear your answers from a poll.
Bug 1677: Remember the option for "Disable Auto-Formatting"
Category: Misc UI/Frontend
Patch by:
fuDescription: We actually added this a while ago, but there was some debate about whether we should make changes to the implementation. We decided against it! And so the bug is closed now.
Bug 2922: redirect m.dreamwidth.org to dreamwidth.org/mobile
Category: Site Layout/Navigation
Patch by:
alierakDescription: This is a config change, so if you access m.dreamwidth.org it will redirect you. (Yay for shorter typing.)
Bug 2229: update cgi-bin/LJ/ConfCheck/General.pm
Category: Misc Backend
Patch by:
kareilaDescription: The process of installing DW on your own server is arcane and poorly documented. (We're working on fixing it, really!) As part of the improvements, this updates a script that runs on install to check your configuration, so that the options are better documented and the ones that don't get used anymore are removed.
Bug 2588: Don't announce upcoming birthdays for deleted journals
Category: Inbox/Notifications
Patch by:
kareilaDescription: This changes the birthday notification code so that birthdays of deleted journals aren't announced anymore, since there's nothing more annoying than getting notified of a birthday for someone who isn't even using the site anymore!
Bug 2830: Add Ravelry as a profile external site
Category: Misc UI/Frontend
Patch by:
kareilaDescription: DW attracts tons of crafty people! (Which makes me so happy, you have no idea.) As part of our drive to increase the tools available for people who do non-writing type creative things, we're adding Ravelry as an "external site" for the profile.
Bug 1845: Cumulative layout credits
Category: Style System
Patch by:
ninetydegreesDescription: This will make it easier to show cumulative layout credits -- like, if the base layout is by one person, and the theme is by another, this will now show both names. This way everyone gets credit!
Bug 2942: Funky Circles: create new color props for easier customizing + correct some colors
Category: Style System
Patch by:
ninetydegreesDescription: This exposes some new properties in the wizard in Funky Circles for changing the colors in the Calendar and Search modules. It also corrects some colors that were used in error.
Bug 3134: missing string /manage/circle/filter.bml.title2
Category: English-Stripping
Patch by:
ninetydegreesDescription: So, when you viewed the Manage Filters page, there was a missing string. Now there is not!
Bug 3136: Make it easy to look up what the notification will look like (dev servers only)
Category: Site Administration
Patch by:
fuDescription: This makes it easier for people who are doing DW development to see what a notification will look like, since running the notification system on dev installs is annoying and tedious and a pain in the ass.
Bug 3153: Gradation vertical/horizontal footer overlaps into content when all content is floated
Category: Misc UI/Frontend
Patch by:
fuDescription: Fixes a bug in the Gradation site schemes where certain CSS in entries would cause the footer to migrate its way into the contents of the page.
Bug 3147: Cannot approve posts in moderated communities for users on dversion 9
Category: Misc Backend
Patch by:
exor674Description: ....Oops. So, when we changed things around to make icon keyword renaming easier, we made a mistake that made it impossible for people to approve posts in moderated comms, which we found out as we started moving people over to the new system. A quick fix by
exor674 and a quick teeny code push by fu means that it's fixed in production now.