Code tour: 2010 October 08 to 2010 October 13

[azurelunatic]

This code tour includes 30 patches. We have contributions from ninetydegrees (congratulations on the rename), fu, kareila, yvi, denise, emclaughlin, and poulpette. This round also includes patches from new developer tyggerdev and the awesome teamdestroyer: Erin of Team Destroyer liked working with Dreamwidth so much during Google Summer of Code that she came back, bringing classmates and new developers Alicia, Josh, and Will with her.

Thanks to everyone involved, from the code reviewers on down to the good folks in dw_suggestions and the people reporting broken things to Support. These won't be live until the next code push; keep watch on dw_maintenance, who will tell you when you have to duck and cover (or at least load up something of reasonable length to read while the site might be down).

We have some new themes as usual, a nice serving of Styles bugfixes, and a sudden outpouring of love for OpenID users, as well as the assorted this and that.

On to the bugs!

Bug 3014: allow openid users to post suggestions
Category: Frontend, suggestions, OpenID users need love too
Patch by: fu
Description: The objective was simple: allow OpenID users to post suggestions. It turned out to take a little bit more doing on the back end, but it was for a good cause. Letting OpenID users post in communities at large is another, future, bug.

Bug 3119: Poll ajax from reading page goes to individual entry page
Category: Misc UI/Frontend, polls, reading page
Patch by: fu
Description: When polls were behind a cut, and you'd expanded them on your reading page and voted, you were getting sent to the entry once you'd filled them out. This fixes that.

Bug 3023: members list page only allows usernames up to 25 characters - too small for OpenID accounts
Category: Communities, OpenID users need love too
Patch by: denise
Description: A community admin inviting people could only enter 25 characters' worth of username: fine for a registered DW user, not so fine for inviting an OpenID user with the domain and all. (Well, unless they had a very short name, or were using the internal ext_ username, but we're trying to cut down on the places that someone has to use that.) This expands it to 75.

Bug 3071: Preview style links for openid accounts should go to /read page
Category: Style System, OpenID users need love too
Patch by: denise
Description: OpenID users trying to preview styles were running into trouble, since their Recent Entries page doesn't exist. This makes OpenID users' style previews point to their reading page instead.

Bug 3035: Drop no-longer-used table openid_external
Category: OpenID, back-end cleanup
Patch by: emclaughlin
Description: Cleaning up an old table no longer used to keep track of OpenID accounts.

Bug 2579: Improve comment preview with metadata and post text
Category: Journal contents, commenting, context is for the weak ;)
Patch by: kareila
Suggested by: msilverstar
Description: When previewing a comment, it's helpful to see the security status of the entry you're commenting on. Context will be visible below your comment; scroll down to see. (Let us know if you have any feedback about the positioning and how it could be made better.)

Bug 3109: interests.bml tweaks
Category: Misc Backend, interests
Patch by: kareila
Description: Fixes some problems with the back-end handling of interests searches involving long interests with special characters.

Bug 2971: Refried Tablet: 5 themes by rising
Category: Style System, shiny new themes are shiny and new
Patch by: ninetydegrees
Description: Five new themes for Refried Tablet. See dreamscapes entries:
http://dreamscapes.dreamwidth.org/32969.html
http://dreamscapes.dreamwidth.org/33186.html

Bug 3038: Nouveau Oleanders: make images accessible via Customize
Category: Style System, making things make sense
Patch by: ninetydegrees
Description: Someone was trying to change around the images that are part of Nouveau Oleanders, but ran into a few frustrations. This renames the images in the style to things that make sense for their function in the style, and makes it possible to swap them out in the Customize Style interface instead of mucking about with CSS.

Bug 3068: Boxes and Borders: Light on Dark: subject in comments unreadable
Category: Style System, fixing what's broke
Patch by: ninetydegrees
Description: When trying to read, light text on a dark background can be helpful. Light text on a light background, not so much. There was a problem with comment titles in Boxes and Borders.

Bug 3105: Crossroads: 5 themes by rising
Category: Style System, shiny new themes are shiny and new
Patch by: ninetydegrees
Description: Five new themes for Crossroads. See dreamscapes entry:
http://dreamscapes.dreamwidth.org/44924.html

Bug 3113: compartmentalize/practicality need margins for <p> tags
Category: Style System, fixing what's broke
Patch by: ninetydegrees
Description: Users of styles "Compartmentalize" and "Practicality" may have noticed that some paragraphs (using the <p> tag) were weird in certain browsers. This should fix that, and go unnoticed by everyone else.

Bug 1124: Can't create new entry after previewing it.
Category: Misc UI/Frontend, making things make sense
Patch by: tyggerdev
Description: There was a spot of confusion about previewing, and how to post after a preview. This will label the preview to say that it's a preview, and one should close the pop-up to continue and post the entry.

Bug 3009: After quoting, the text area does not receive focus
Category: Misc UI/Frontend, fixing what's broke
Patch by: teamdestroyer (Alicia, Erin, Josh, and Will)
Description: You can quote bits of things in your comment, but after putting the quote in the comment box, the focus (or the cursor, whichever way you prefer to think about it) should be back in the comment box. This fixes that.

Bug 2935: email to display on profile not working for comms
Category: Communities, fixing what's broke
Reported by: domtheknight
Patch by: yvi
Description: Email address for communities wasn't saving properly. Turns out there was something lurking in the code that accidentally saved the community's new email address to the user's own journal, not their community's. If you tried to change an email address on your community recently, and it didn't take, and you've had weirdness getting your own notifications since then, double-check!

Bug 3013: clear-my-answers link for polls
Category: Journal contents, polls, making things make sense
Patch by: yvi
Description: Sometimes you vote in a poll and then realize that maybe you weren't meant to. You can untick checkboxes, but you can't unselect radio buttons (without a little help). This patch gives everybody the option to clear all their votes in a poll if they didn't actually mean to vote there, or voted there by mistake.

Bug 2588: Don't announce upcoming birthdays for deleted journals
Category: Inbox/Notifications, journal deletion, making things make sense
Suggestion by: yvi
Patch by: kareila
Description: When a journal's deleted, it makes very little sense to keep telling the people who still have the journal in their circles about upcoming birthdays and such.

Bug 3030: convert htdocs/legal to TT
Category: Routing/TT, backend stuff
Patch by: kareila
Description: Dreamwidth is moving to using Template Toolkit for building pages on the back end. This converts the stuff in the 'legal' directory over.

Bug 2840: Page title should not change to just "Post comment" on the post comment (?mode=reply) page
Category: Journal contents, making things make sense
Suggested by: aithine
Patch by: tyggerdev
Description: You know how when you go to the reply page for some entry, and the title of the page becomes "Post comment" (or something similar, depending on the journal's style), regardless of what the entry's actual title is? And perhaps you have 10 comment pages open, and you'd really like to find the one you're interested in, but you have to look through them all? This will make sure that the username and the entry title are consistently kept in the page title, even on the reply page.

Bug 2843: Show tags in Inbox Entries
Category: Inbox/Notifications, tags
Suggested by: jassanja
Patch by: tyggerdev: congratulations on first patch!
Description: If you get notified of a new entry, it's helpful to see what its tags are from your notifications inbox, particularly if you've gotten the notification thanks to being subscribed to new entries of that tag from that person/community.

Bug 3095: difficulty clearing phone number from DW/Setting/TxtMsgSetup
Category: Misc UI/Frontend, making things make sense
Reported by: zelda
Patch by: yvi
Description: It's good to check to see that the user didn't accidentally forget to put in their number or service provider when setting up a new number for text messaging. It's not so good to fail to delete the number when someone tries to. So if someone clears the carrier and clears the phone number, the likelihood is they're trying to remove the number.

Bug 3114: Poll left-end/right-end images not showing up in notification emails
Category: Misc UI/Frontend, fixing what's broke
Patch by: fu
Description: Display of poll images in notifications was looking a little rough. This was tracked down to an issue deep in the image-handling code.

Bug 3123: shop-creditcard-charge worker does not have executable bit
Category: Site Administration, fixing what's broke
Patch by: fu
Description: Credit card orders can't run by themselves if their worker isn't already started, so some human had to kick the server. This fixes that.

Bug 3127: admin/propedit.bml has some potential issues with saving display value versus raw value
Category: Site Administration, fixing what's broke
Patch by: fu
Description: A bug on display and saving of certain settings that might cause some settings to be saved wrong, but with minimal impact. This fixes that.

Bug 3111: Funky Circles: rename 900degrees to ninetydegrees in credit
Category: S2 Backend
Patch by: ninetydegrees
Description: Hooray for renames! Congratulations to ninetydegrees on the rename! Switches credit to new username in styles.

Bug 3112: Negatives Entry footer needs to clear: both, if possible
Category: Style System, fixing what's broke
Patch by: ninetydegrees
Description: Some content below the main entry text was overlapping the management link bar in the footer of Negatives. This fixes that.

Bug 3122: Refried Tablet: footer modules display oddly when they have a background color
Category: Style System, fixing what's broke
Patch by: ninetydegrees
Description: Fixes some display weirdness.

Bug 3130: Negatives -- Autumn has a color that isn't a color in the theme layer
Category: Style System, fixing what's broke
Reported by: foxfirefey
Patch by: ninetydegrees
Description: There was a typo in a color: #9e900 instead of #9e9000.

Bug 3126: 500 error when trying to edit a comment while logged out
Category: Journal contents, making things make sense
Patch by: fu
Description: "Oops, there was a problem" isn't a very informative error if you're trying to edit a comment but you're logged out. This makes things more explicable.

Bug 3086: UI: navstrip input boxes are unreadable when using dark themes
Category: Browser Issues, fixing what's broke
Patch by: poulpette
Description: The input boxes on the navigation strip had dark text on a dark background in some circumstances. This fixes that.

Comments

[lanterne_rouee]

Erin of Team Destroyer liked working with Dreamwidth so much during Google Summer of Code that she came back, bringing classmates and new developers Alicia, Josh, and Will with her.

That is so cool. :)

Thank you for the code tour! I had a good time. :P

[msilverstar]

Thanks for the fixes to previewing comments: it's great to see things getting better!

[alixtii]

Yay for being able to clear radio buttons!