Code tour: 26th August - 1st Sept

[cesy]

We have 11 bugs fixed this week, all behind the cut. Once again, most of them are new themes or backend work. Thanks as always go to this week's contributors!

Bug 712: change order of need_res calls
Category: Misc Backend
Patch by: fu
Description: This makes the CSS files load in the right order, so that style-specific things override general things and inheritance works properly.

Bug 2983: Boxes and Borders: 4 themes by timeasmymeasure
Category: Style System
Patch by: ninetydegrees
Description: Previews available here

Bug 2970: Brittle: 4 themes by edgeraven
Category: Style System
Patch by: Rowan (edgeraven)
Description: More previews

Bug 2336: URL for community rules / welcome
Category: Communities
Patch by: fu
Description: The community rules / welcome entry setting (which new members get sent to when they join the community) has been there a while. What this does is to make a http://examplecommunity.dreamwidth.org/guidelines URL which redirects to the proper entry if it's been set.

Bug 2974: add siteadmin:invites priv
Category: Site Administration
Patch by: fu
Description: This allows denise to share out responsibilities by letting people help manage invite code distribution without giving them access to the payments system - previously the permissions were combined.

Bug 2808: fix t/dev-setup.t
Category: Misc Backend
Patch by: kareila
Description: Fixing tests means we can catch more problems before you see them.

Bug 2998: unbold the success/failure messages in the default TT result page
Category: Misc UI/Frontend
Patch by: fu
Description: Some warning messages and notices were bold on newer pages where we didn't want them to be. This makes the design of the site more consistent.

Bug 2963: Cleanup duplicated "is this the right format" code
Category: Routing/TT
Patch by: exor674
Description: Duplicated code makes babydevs cry. exor674 protects babydevs from evil code.

Bug 2985: Entries show as being posted at the current time when they are backdated to the beginning of time
Category: Misc Backend
Patch by: exor674
Description: The likelihood of someone posting an entry at the beginning of unix time was fairly low, but if anyone did, the poor computer got very confused. Now it knows that a time of zero is not the same thing as not specifying a time.

Bug 2949: Styles: make links display correctly when icons are switched to text and vice versa
Category: Style System
Patch by: ninetydegrees
Description: Styles have an option to change the display of the "comment", "10 comments", "link", "track", "memory" at the bottom of each entry, to make them buttons instead of text links. This makes sure that it displays properly in every style, whichever option you choose.

Bug 2984: Negatives: fix second module floating next to profile module
Category: Style System
Patch by: ninetydegrees
Description: If you had a short name and used the Negatives style, the "Syndicate" module sometimes ended up next to your icon instead of below it. This makes it display properly regardless of the length of your name.

Comments

[azurelunatic]

Hooray for another week and another code tour!

Think I just discovered a new bug

[unixronin]

...Either that, or I don't understand how a feature is supposed to work.

If I'm in my icon management screen, and I change the keywords on an icon, a checkbox is exposed to "Rename keywords". If I check this box, I assume that what is supposed to happen is that all posts using that icon by its old keywords are updated to use the new keywords. What ACTUALLY happens is that, after saving changes, the icon now has both the old AND the new keywords on it. Is this supposed to happen?

Also, while we're discussing icon management, is it possible to add a preference setting on the icon management page to make the selected sort order "sticky"? It would be nice if I could set my icon page to always display in keyword order, instead of the current rather less useful (IMHO, YMMV, BNI) default of sorting by upload order.

Re: Think I just discovered a new bug

[cesy]

For the first point, I'd suggest asking in Support if you don't get an answer here within an hour or two. It sounds like it might be a bug to me.

For the second one, I'd suggest making a suggestion to change it.