Code Tour! 4/20 - 4/26

[sporky_rat]

Welcome to the code tour for 4/20 - 4/26. There was a total of 44 bugs with 9 bugs for fu, a whopping 13 for kareila, 3 for ninetydegrees, 4 for mark, 1 for denise, 1 for jportela, 2 for mayank (congrats are in order for first patches!), 1 for zvi, 2 for chemicallace, 1 for zarhooie, 2 for exor674 and 3 for yvi.



Bug 496: Set up RTE to accept cross-site tags
Category:: Misc UI/Frontend
Patch: fu
Description: The RTE can now use cross-site tags! Yay! Now LJ users can be mentioned and things don't break. Go Fu!


Bug 2275: Screened Comment Converstions
Category:: Misc UI/Frontend
Patch: yvi
Description: You can now reply to a screened comment that was made in response to you (by a mod or author of a post) AND you can reply to any screened comment you can see.


Bug 2511: Apostrophes in 'restore draft' dialogue box escaped
Category:: Journal Contents
Patch: fu
Description: When saved as a draft, the dialogue box asking if you wanted to restore a draft had escaped apostrophes.


Bug 2543: Core2 containes references to 'posts' as nouns.
Category:: Style System
Patch: fu
Description: No longer do 'posts' fall under the category of noun! They are now verbs.

Bug 2446: Add cookie support to DW::Request
Category:: Misc UI/Frontend
Patch: exor674
Description: DW::Request needed cookie support. Modernization of code, people. It's the future!


Bug 2550: Update Diversity Statement
Category:: Frontend
Patch: denise
Description: The Diversity Statement needed a way to welcome our older users, since we can't use 'age' as a blanket term due to COPPA.


Bug 2407: Add priv-checking option to DW::Controller::controller()
Category:: Misc UI/Frontend
Patch: pauamma
Description: Apparently code was pointing and laughing if you didn't have the right privs. No longer shall it laugh! It shall also point to DW, not LJ.


Bug 2510: Data-ObjectDriver repo moved
Category:: Site Administration
Patch: pauamma
Description: The Data-ObjectDriver repo needed moving.


Bug 2454: Suspend command doesn't work for feed accounts
Category:: Site Administration
Patch: kareila
Description: Feeds can now be suspended via the suspend command.


Bug 2503: Cannot invite OpenID users to communities
Category:: Communities
Patch: kareila
Description: In the interest of friendliness, OpenID users can join communities.


Bug 2534: Remove referer warning
Category:: Misc/Backend
Patch: mark
Description: The referer warning has been removed because of spamming logs in production.


Bug 2546: Public Key Icon doesn't work on userinfo
Category:: Misc/Backend
Patch: mark
Description: The public key icon didn't work. Mark has fixed it!


Bug 2328: Layout: Modular
Category:: Style System
Patch: ninetydegrees
Description: A new layout! And might I say, a very pretty one!


Bug 2244: Add Gradation Horizontal
Category:: Misc UI/Frontend
Patch: foxfirefey
Description: Gradation Vertical....but horizontal! A new site scheme!


Bug 2237: Official Community Icon Lacks a 24x24 version
Category:: MiscUI/Frontend
Patch: zarhooie
Description: The lovely zarhooie created a 24x24 icon for staff usage.


Bug 2457: When expanding 'View Answers' on poll, hover box doesn't appear
Category:: Misc UI/Frontend
Patch: jportela
Description: A hover box with user names and icons wasn't showing up when expanding a poll.


Bug 2127: Alt Image text box in RTE is too small
Category:: Journal Contents
Patch: chemicallace
Description: The RTE alt image text was about 5 characters long. chemicallace increased the length so it's a little less unreasonable.



Bug 2537: 'No Messages' unstripped in cgi-bin/LJ/Widget/InboxFolder.pm
Category:: English Stripping
Patch: chemicallace
Description: Someone hard coded 'No Messages' and so a very brave Chemla went in and stripped it! Stripped it of the terrible hardcoding! That way the user-facing text can be in the translation system instead of....hardcoded. I need to go wash my hands now.


Bug 1392: Memcache domain mapping
Category:: Misc/Backend
Patch: exor674
Description: User-domain goes into memcache.


Bug 2227: move bin/test/*files into t/*
Category:: Misc/Backend
Patch: kareila
Description: Moved some of Mark's tests to t/*.


Bug 2349: Add extra info to userpic uploaded notification
Category:: Inbox/Notification
Patch: kareila
Description: Allows for more information to be sent when someone is notified of a new icon upload.


Bug 2481: fix t/console-changejournaltype.t
Category:: Misc/Backend
Patch: kareila
Description: Some tests weren't working because of lack of proper checking.


Bug 2484: fix t/console-expuncgeuserpic.t
Category:: Misc/Backend
Patch: kareila
Description: This wasn't broken, but it was ugly and could fail.


Bug 2485: fix t/assertions.t
Category:: Misc/Backend
Patch: kareila
Description: Something was broken, then it was blessed. I think. There's a lot of Perl terminology here, but it looks like something was being used that shouldn't have been and was then fixed.


Bug 2490: fix some esn tests
Category:: Misc/Backend
Patch: kareila
Description: ESN tests are now WTF compatible.


Bug 2491: fix notificationmethod tests
Category:: Misc/Backend
Patch: kareila
Description: Fixes for notificationmethod-email.t and notificationmethod-inbox.t.


Bug 2493: fix t/settings.t
Category:: Misc/Backend
Patch: kareila
Description: Removes tests for long-gone LJ/Setting/WebpageURL.pm, and fixes a surprising bug in cgi-bin/LJ/Setting/Gender.pm.


Bug 2492: fix t/entrycomment-create.t
Category:: Misc/Backend
Patch: kareila
Description: Wasn't broken, but was not working right.


Bug 2491: fix t/user-infoshow-migrate.t
Category:: Misc/Backend
Patch: kareila
Description: The opt_showbday default changed from F to D.


Bug 2539: fix proto-post-edit-roundtrip.t
Category:: Misc/Backend
Patch: kareila
Description: Another test was broken! Now it's not.


Bug 2141:
'Delete All' and 'Refresh' at top of inbox
Category:: Inbox/Notifications
Patch: mayank PS: Congrats on your first patch!
Description: Delete all and Refresh were awfully close together and the wrong one could be hit accidentally. mayank has fixed it!


Bug 2342: show the number of posts on a day as hover text in the sidebar calender
Category:: Style System
Patch: mayank
Description: The number of posts a person can see will be shown as hover text in the side bar calender.


Bug 2099: Inconsistent spacing between comment links on site scheme comment pages
Category:: Misc UI/Frontend
Patch: ninetydegrees
Description: Fixes some wonky spacing issues with comment links, adds TWO spaces instead of just one or none.


Bug 2491: Clean Transmogrified Layout.s2 file
Category:: Styles System
Patch: fu
Description: A clean file of Transmogrified.


Bug 1683: Unsubscribe to mulitple notifications
Category:: Inbox/Notifications
Patch: yvi
Description: We can now unsubscribe from multliple notifications ALL AT ONCE. ...unless your keyboard breaks or something.


Bug 2465: queue displaying if even community is not moderated and queue is empty
Category:: Communities
Patch: yvi
Description:No longer will unmoderated communities that were once moderated have queues!


Bug 1965: some styles do not set base font to 1em
Category:: Style System
Patch: zvi
Description: This allows for a set font size.


Bug 2491: Entryprops displays xpost and xpostdetails wrong
Category:: Site Administration
Patch: fu
Description: * xpost: Wrong mapping of account to server name
* xpostdetails: binary stuff


Bug 2538: Syntax error in adult_explicit_blocked
Category:: Journal Contents
Patch: fu
Description: Apparently things were not blocking or they were being blocked and weren't supposed to.


Bug 2542: RTE+user tags in Safari/Chrome/Opera has issues. Text after the user name gets put into the tag
Category:: Journal Content
Patch: fu - not really a patch?
Description: There were issues solved by a code merge.


Bug 2557: Importer frontend lacks message when status is aborted
Category:: Importer
Patch: fu


Bug 2491: error message in editicons when you try to upload from URL but weren't able to fetch the image
Category:: Misc UI/Front End
Patch: fu


Bug 2533: Tabula Rasa: no space between poster and subject on Month page
Category:: Styles System
Patch: ninetydegrees
Description: adds some space between poster and subject on Month page for Tabula Rasa

Comments

[ninetydegrees]

(and now for a real comment)

Oh pretty Jayne!
Thanks for listing all the names, sporky_rat. It's great to see so many people working for DW. :)
I'm particularly happy about #2275 and #1683 so thanks a lot, Yvi!

[azurelunatic]

Bug 2503 was even a bit more subtle than that! OpenID users could join communities, but the admin could not invite them! This fixed that.

[pinesandmaples]

Hey, I know you!

[sporky_rat]

Yeah, you know me. What of it? ;-) Hi to you too! When you get done with your senior year of college, would you like to jump in and help do things like this?

[afuna]

Whooo, code tour! Thank you \o/

[yvi]

The unsubscribe thing is actually not so much for multiple at once as it is without having to reload Each. Single. Time. Which I hope is still pretty nice :)

I can't wait for the next code push...

[cesy]

Yay for OpenID and styles and 2349, so much. Also yay for 1683 and all the tests. So much cool stuff this week!

[timeasmymeasure]

Screened Comment Converstions
This makes disproportionately crazy happy :)

[baggyeyes]

That's a lot of bugs!

Why exactly does Perl Bless things, anyway?

[vlion]

It has aspiration of priestly power.


*cough*

Perl does not have a 100% functional object system. A common word is bolt, as in, "You can bolt your own object system in". Blessing is a mechanism to sort of kinda make a hash an object approximately. If you squint just right and don't think about other languages it works out all right.

official documentation

Example.

Suppose you have a file Foo.pm that has package Foo, which you want to objectify (note the lack of snarky joke).

package Foo;
sub new
{ 
   my $self = shift; 
   bless $self; 
   return $self; 
}

$self now is blessed into being an object of type Foo.

[sporky_rat]

Thank you, Vlion! All some of us could guess and look up was that it was Perl!

[baggyeyes]

Thank you, vlion! I understand it now.

[yvi]

There are no words for how wrong that is!

(the bless thing, not your comment)

[vlion]

my info is wrong?

[yvi]

No, no, the existence of the "bless" command. It just... makes me want to scream "object orientation does not work that way".

[vlion]

I have pretty much decided Perl is a failed language at this point. From what I've seen, the maintainers are not interested in moving it forward into the 1990s. Things like bless, autovivification, no formal parameter lists, flattening of lists. Gah.

I'm learning Python when I can