denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)
Denise ([staff profile] denise) wrote in [site community profile] dw_dev2009-10-27 05:20 am
Entry tags:

Code Tour, 10/20-10/27

This week we had a rollicking development week, with 47 bugs resolved FIXED (our highest number in a while!) We're nearly at 1500 bugs resolved, which is pretty darn awesome too -- and this week, we closed Bug #3, which made us pretty happy. One of this week's patches is a security issue we decline to describe publicly to give other sites running the code a chance to apply the patch. Have a look at the rest of this week's development in our code tour, starting here...



Bug 1972: Negatives: fix display of navigation links when in sidebar
Category: Style display
Patch by: [personal profile] ninetydegrees
Description: This fixes the Negatives layout to evenly apply the styling for unordered lists so that the navigation links look identical no matter which module they're in.

Bug 1971: Negatives: module header text should be left-aligned in one-column
Category: Style display
Patch by: [personal profile] ninetydegrees
Description: This patch is a style fix for the one-column version of the Negatives layout so the header text behaves the same way as in the two-column version.

Bug 1963: talkscreen success has no return link
Category: Usability
Patch by: [staff profile] denise
Description: This changes around the page you get to if you screen a comment with Javascript off, or without using the AJAX screening method, so that it includes useful links back to the post in question.

Bug 1962: typofix in cgi-bin/LJ/Subscription.pm
Category: Cleanup
Patch by: [staff profile] denise
Description: This takes the prize for "most minor patch of the week": I was reading the file to try to figure something out and noticed one of the comments had a misspelling in it. These things annoy me. No cleanup too small!

Bug 1961: site search widget for homepage
Category: Search
Patch by: [staff profile] denise
Description: This adds a 'site search' module to the logged-in homepage, allowing you to more easily search Dreamwidth for interesting/useful content. Everyone can use the full site search, not just paid users, so go! Search!

Bug 1957: /manage/circle/add too squished
Category: Display
Patch by: [staff profile] denise
Description: [personal profile] zvi noted that the headers on the Add to Circle page you get when subscribing to someone or giving them access looked too squished, so this patch adds some extra padding between the two sets of filters.

Bug 1955: Suggestions generator has incorrect search link
Category: Bugfix
Patch by: [staff profile] denise
Description: This corrects the "search this community" link on the suggestions generator, which was accidentally malformed.

Bug 1954: AJAX track/untrack box text almost unreadable in Repose (probably others)
Category: Display fix
Patch by: [personal profile] wyntarvox
Description: This adds explicit foreground/background colors to the AJAX box so it's visible in all layouts.

Bug 1953: Make AJAX work on text links in S2
Category: Usability
Patch by: [personal profile] wyntarvox
Description: This makes the track/untrack options bring up the AJAX management options (allowing you to track/untrack without leaving the page) for text links, not just graphical links. (It was always there for graphical links, just not text.) Don't worry, we're aware of the problem where you can't control-click into a new window now, and we're fixing it!

Bug 1928: Some suggestions for the edges data file
Category: APIs
Patch by: [personal profile] foxfirefey
Description: This extends some of the data files we provide for people to use in their plugins/helper applications.

Bug 1921: Allow propgroups in multiple layers to be merged
Category: Styles backend
Patch by: [personal profile] afuna
Description: This is deep style system voodoo that does ... something. With properties. You know. *handwave*

Bug 1902: Site-wide search
Category: Search
Patch by: [staff profile] mark
Description: This was the meta-bug for adding site-wide search, which Mark has declared is now Done Enough to close the main bug and put anything else into new bugs.

Bug 1899: Disabled referer headers make login/logout redirect to blank page
Category: Bugfix
Patch by: [personal profile] wyntarvox
Description: Fixes up a problem where if people have the sending of referer headers disabled in their browser, they would get blank pages when logging in or out.

Bug 1898: Content Search not on site map
Category: Usability
Patch by: [staff profile] denise
Description: Adds site search to the site map.

Bug 1896: Rename div.datetime to div.datetime-container or div.datetime-block and fix Drifting
Category: Styles
Patch by: [personal profile] ninetydegrees
Description: Makes the CSS controlling the Drifting layout more sensible and logical.

Bug 1875: "Last updated" section on Manage Circle page
Category: Usability
Patch by: [staff profile] denise
Description: From a [site community profile] dw_suggestions suggestion, this adds the date that someone last updated (also visible on the profile) to the Manage Circle page.

Bug 1841: Repeat people/comms/feeds between each section on Manage Circle page
Category: Usability
Patch by: [staff profile] denise
Description: Another suggestion, this patch repeats links to the people/comms/feeds sections between each section on the Manage Circle page.

Bug 1839: Icon for filtered posts is unclear
Category: Usability/design
Patch by: [personal profile] afuna, icon by [personal profile] turlough
Description: Yet another suggestion, this changes the icon being displayed when you make a filtered post.

Bug 1832: keep summary module from overflowing
Category: Styles backend
Patch by: [personal profile] afuna
Description: Fixes some CSS so modules don't overflow if there's a long word or title.

Bug 1831: bootstrap.pl checks out out-of-date code
Category: install tools
Patch by: [personal profile] sophie
Description: This fixes up one of the admin tools that helps install the DW code so that it points to the right place.

Bug 1828: Theme: Greyscale (Modish)
Category: Layout
Patch by: [personal profile] wyntarvox, theme by [personal profile] twtd, preview by [personal profile] piranha
Description: A new color theme for the Modish layout.

Bug 1818: Reorder Funky Circles Properties in the Wizard
Category: Styles
Patch by: [personal profile] ninetydegrees
Description: Changes the ordering of some of the properties for the Funky Circles layout to make it more usable/easier to set.

Bug 1809: if comm isn't moderated, queue page says 'not a maintainer'
Category: Site copy
Patch by N/A, fixed on site
Description: Changes some text to make it clearer.

Bug 1780: quick reply form is missing "Quote" button
Category: Usability
Patch by: [personal profile] wyntarvox
Description: This adds the 'quote' button to the Quick Reply form (which is what most people use to comment, the AJAX-y box that usually pops up when you hit the link to comment).

Bug 1750: Subscribe to all comments for a community you maintain
Category: Notifications, Usability
Patch by: [personal profile] afuna
Description: This allows maintainers of a community to subscribe to all new comments for the comm (to set this subscription, go to the comm and hit the Track button from the profile). And with it, Afuna became my new favorite person, at least until my next new favorite person comes along. Also, did you know that [site community profile] dw_suggestions gets a lot of comments?

Bug 1745: "Success" page after joining a community should have a link to post to the comm you've just joined
CategoryPatch by: [personal profile] wyntarvox
Description: Another suggestion, this allows community maintainers to not only chose whether or not to include a "post to community" link after someone joins the comm, but also lets them include a link to the community guidelines.

Bug 1736: "Other" layerid when editing a style does not stick
Category: Styles bugfix
Patch by: [personal profile] afuna
Description: This fixes a problem with the styles backend that would cause errors when trying to select a style in certain circumstances.

Bug 1724: Make bin/dbcheck.pl support more than 10 clusters
Category: Backend
Patch by: LiveJournal
Description: This removes an old check (no longer necessary) in the admin script used to check the database configuration.

Bug 1713: Layout: Skittlish Dreams
Category: Layout
Patch by: [personal profile] afuna, theme by [personal profile] kaigou porting a Wordpress theme, preview by [personal profile] piranha
Description: A new (awesome) base layout with seven color themes.

Bug 1710: remove legacy database tables
Category: Cleanup
Patch by: [personal profile] kareila
Description: This patch removes some old and unused legacy database tables (left over from old designs) that we don't need anymore because we don't need to support backwards compatability with older versions of the code.

Bug 1701: Different icon for official communities
Category: Display
Patch by: [staff profile] denise
Description: This changes the user head icon for official communities to a version of the Dreamwidth swirl (it was [personal profile] rho's idea to use an alternate version of the favicon) so people know that they're official even if they don't have 'dw_' starting them off. If you spot a community I forgot to bless with the 'official' icon, let me know!

Bug 1692: Create a page that can share off-site content on DW
Category: Cross-site interoperability
Patch by: [personal profile] janinedog
Description: This adds a "Share This" URL that will let people post to their DW journal from outside sites, so other sites can add DW to their "share this" box if they want.

Bug 1572: Change the landing page of the Edit Filters page
Category: Usability
Patch by: [staff profile] denise
Description: Another suggestion, this one adds useful links to the page you wind up on after editing your posting filters.

Bug 1543: Submitting a blank search returns boxless page
Category: Usability
Patch by: technically, [staff profile] mark
Description: This bug involved useful errors when submitting a blank search box, and was fixed by [staff profile] mark as part of his other work, not explicitly for this bug.

Bug 1496: Memcache not properly being cleared on archive page
Category: Backend
Patch by: [personal profile] afuna
Description: Memcache is the thing that keeps the site from falling over dead: it stores frequently-accessed information in memory (which is quick to look up in) rather than on disk (which is slow to look up in). This patch fixes up a bug with properly setting and clearing memcache information on the archive pages.

Bug 1404: invite code distribution results admin email slightly wonky
Category: Admin tools
Patch by: N/A
Description: We've been getting spotty (which is to say, maybe three or four) reports of the invite code distribution email having weird control characters in it; we hope we've fixed it this time.

Bug 1391: Inbox sometimes inaccessible because of an undefined event
Category: Bugfix
Patch by: LiveJournal
Description: This fixes a problem (hopefully) that can manifest during periods of high site load where the inbox can't display.

Bug 1371: generated html for links to tags containing "about:" is malformed
Category: Bugfix
Patch by: [personal profile] kareila
Description: This slightly tweaks the HTML cleaner that strips potentially malicious code to allow for tags and/or URLs that begin with "about:".

Bug 1260: Bad behavior of current memories system
Category: Bugfix
Patch by: [personal profile] meowth
Description: Makes it possible to delete memories of entries you don't have access to view anymore without having to resort to the ?multidelete=1-in-the-URL hack.

Bug 1217: Expanded comments don't have contextual hovers
Category: Usability
Patch by: [personal profile] wyntarvox
Description: Fixes a bug where expanded comments didn't have the contextual hover box (if you've chosen to turn that on) after expansion.

Bug 921:
importer not rewriting <lj user> tags in subjects for cross-site
Category: Importer
Patch by: [personal profile] exor674
Description: When you import a journal from another source, we automatically rewrite any <lj user> tags so they properly have the "site=foo" parameter, preserving the original link. A bug meant that the rewriting was only happening in the entry itself, not in the subject as well; this fixes that.

Bug 886: Remove "notify me when someone comments on my entry" notification for OpenID
Category: Usability
Patch by: [staff profile] denise
Description: As part of our ongoing efforts to make OpenID accounts more easy to use -- as well as not showing them options that they can't use or that don't apply -- this patch removes the "notify me when someone comments on one of my entries" notification option for OpenID accounts, since they can't post entries and thus the subscription would be useless. I also owe [personal profile] kareila an apology; she questioned my code when reviewing it and I assured her it was the right logic, and then we did the code push and suddenly nobody could subscribe to comments in communities because she was right and I was wrong. Oops.

Bug 832: Add Feed Information to Create Feed Page
Category: Usability
Patch by: [personal profile] wyntarvox
Description: For usability purposes, this changes the text shown when you're creating a new feed account so that the URL of the feed you're adding is displayed to you.

Bug 744: Migrate /settings settings to an Advanced Settings tab
Category: Usability
Patches by: [personal profile] afuna, [staff profile] denise
Description: This was an ongoing bug to make sure that there weren't any settings only accessible by the old settings page (which shouldn't be necessary anymore). We're pretty sure we've got them all, except for settings that don't apply on DW, so we closed this bug as resolved.

Bug 602: account creation: interest examples or copy-pasted text disappear if field loses focus
Category: Bugfix
Patch by: [personal profile] wyntarvox
Description: This patch fixes the create process so that the "sample" interests, etc, reappear when you click outside the box if you haven't typed anything of your own.

Bug 3: Filter inbox by which entry a comment was a reply to
Category: Usability
Patch by: [personal profile] afuna
Description: So, this is pretty awesome: this is one of our oldest bugs (as evidenced by the number), and one of the things I put on the list of "things I want to do with DW" back when we were still calling it HypotheticalJournal. This adds a link, in the inbox, to only display notifications from a particular entry all at once.
cesy: Home is where the <3 is (Dreamwidth) (Dreamwidth)

[personal profile] cesy 2009-10-27 09:26 am (UTC)(link)
So many cool patches \o/
baggyeyes: Princess Leia (Default)

\o/

[personal profile] baggyeyes 2009-10-27 04:06 pm (UTC)(link)
Yesss.
yvi: Kaylee half-smiling, looking very pretty (Default)

[personal profile] yvi 2009-10-27 09:30 am (UTC)(link)
47! Wow!

Of course now I am kind of sad that I didn't contribute anything to that. Maybe next week ;)
afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)

[personal profile] afuna 2009-10-27 09:35 am (UTC)(link)
Bug 1750:

*snickers* I admit to a vested interest. I was tired of refreshing the recent comments page for [site community profile] dreamscapes all the time!
ninetydegrees: Drawing: a girl's face, with a yellow and green stripe over one eye (Default)

[personal profile] ninetydegrees 2009-10-27 10:10 am (UTC)(link)
1972: it's the opposite actually. :) It makes the styling apply only when they're in the header and footer. They will look like regular unordered lists when in the sidebar.

1971: same thing. On the left in one-column. On the right, otherwise.

[personal profile] rho 2009-10-27 11:04 am (UTC)(link)
Do you happen to have a list of all the communities you marked as official? I know that FAQ 65 is missing at least a couple of official journals and needs updating, and wonder if there are any more that I've missed.

[personal profile] rho 2009-10-27 11:49 am (UTC)(link)
Oh, duh. I can't believe I didn't think of that. Have updated the FAQ now, though (there were a few others that were missing).
baggyeyes: Princess Leia (Default)

[personal profile] baggyeyes 2009-10-27 04:04 pm (UTC)(link)
Re: Bug 1750: Paid communities only?
afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)

[personal profile] afuna 2009-10-27 04:24 pm (UTC)(link)
Nope, all communities.
baggyeyes: Princess Leia (Default)

[personal profile] baggyeyes 2009-10-27 04:41 pm (UTC)(link)
I don't mean to be a bug, but - where is this switch? Ach. It'll probably be in an easily accessible place, too.
foxfirefey: Fox stealing an egg. (Default)

[personal profile] foxfirefey 2009-10-27 04:52 pm (UTC)(link)
If you go to the profile of the community and click the "Track" action, it will be one of the options in that list!
baggyeyes: Princess Leia (Default)

[personal profile] baggyeyes 2009-10-27 05:03 pm (UTC)(link)
Aha. One of those options I have never used before. Thank you! :)
turlough: deckchairs on Brighton Beach, June 2013 ((mcr) bob approves)

[personal profile] turlough 2009-10-27 04:07 pm (UTC)(link)
Bug 3 is so awesome!
kellyfaboo: Photo Shadow of me July 09 (Default)

[personal profile] kellyfaboo 2009-10-30 05:28 pm (UTC)(link)
Did you do something this week which would make the Make A Post page issue a large amount of NSF calls. I almost shut down our network today.
mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)

[staff profile] mark 2009-10-30 05:34 pm (UTC)(link)
What is an NSF call?

To my knowledge the update page has not changed in the past code push.
kellyfaboo: Photo Shadow of me July 09 (Default)

[personal profile] kellyfaboo 2009-10-30 05:44 pm (UTC)(link)
Sorry, migraine. Our NFS (Network File System instead of National Science Foundtion) was experiencing a lot of traffic while I had my update tab open. Quit when I closed the tab.

First time this has happened.
mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)

[staff profile] mark 2009-10-30 05:51 pm (UTC)(link)
That's odd. Web sites generally don't have access to your file system (local disk, NFS, whatever). Dreamwidth doesn't, at any rate.

It could be some interaction with your browser? Are you using something old like IE6? Does it happen every time you have the update page open, or was it just once?
kellyfaboo: Photo Shadow of me July 09 (Default)

[personal profile] kellyfaboo 2009-10-30 06:09 pm (UTC)(link)
I'm using Firefox that is run over our NFS (program stored on the server not on the Mac). That might be part of the problem. They said it has happened (though not as catastrophically) so I'm beginning to suspect that this is just part of how my Firefox is interacting with the update page.
kellyfaboo: Photo Shadow of me July 09 (Default)

[personal profile] kellyfaboo 2009-10-30 06:12 pm (UTC)(link)
Just for reference (mostly mine, because I'm fascinated now). When I opened it and starting making a post in Safari which is stored on the desktop it got noisy too.