Code tour, 10/13-10/19

[denise]

Happy Monday, everyone! This week, sophie and I are sharing code tour duties; she did the first half, and I did the second half. Turning it over to sophie:

This week we've had 21 bugs resolved - thank you to foxfirefey, afuna, exor674, wyntarvox, gchick, ninetydegrees, kareila, yvi, denise, janinedog, and first-time contributor meowth!

In particular, a big thank you to our theme contributors - twtd, wizard101 and zvi!

Apart from the topmost two, all these fixes are already live. As always, you can check when they go live using the code status page.



Bug 1952: Bug in LJ::User->raw_prop
Category: Misc Backend
Patch by: LiveJournal; packaged for DW by foxfirefey
Description: This is a code merge from LiveJournal that fixes a bug where a command was always executed, even when it didn't need to be.


Bug 1950: Apply theme button is far away from the theme name above it
Category: Misc UI/Frontend
Patch by: afuna
Description: On the Select Journal Style page, the Apply Theme buttons were too far from the previews; this patch fixes that with some HTML and CSS changes.


Bug 1946: Imported entries will crosspost if auto-crosspost is on.
Category: Importer
Patch by: exor674
Description: This bug was the cause of denise's headdesking earlier this week. This patch introduces a new internal 'no_xpost' flag that the importer uses when posting to make sure that imported posts don't get crossposted any more.


Bug 1944: Comment edited at time in odd spot in Fluid Measure
Category: Style System
Patch by: wyntarvox
Description: Those of you using the Fluid Measure style may have noticed that the 'edited at' date on a comment floated to the right instead of staying on the left where the actual 'Edited At' text was. This patch fixes that.


Bug 1942: sticky entry breaks core1 styles
Category: Style System
Patch by: afuna
Description: This patch allows people who imported their own styles from LJ using core1 to use sticky entries. We don't normally add features to core1 (since it's intended to be compatible with LiveJournal's S2 core), but any core1 users using the new sticky entries feature found that it broke when they tried it. Oops.


Bug 1941: Page::print_theme_stylesheet function to hold theme-specific CSS
Category: Style System
Patch by: wyntarvox, suggestions by afuna
Description: In a lot of S2 styles, using theme-specific CSS required that you first had to specifically ask the layout to print out its stylesheet onto the page first. This patch allows style creators to override a new function, Page::print_theme_stylesheet(), which gets called after the layout's own CSS, which reduces the amount of code needed.


Bug 1929: Allow suspending single entries in/posted by deleted and purged journals
Category: Misc UI/Frontend
Patch by: LiveJournal; packaged for DW by gchick
Description: In cases where entries needed to be hidden from view to comply with the ToS, but the poster in question had already deleted their journal (and been purged by the system), it used to be impossible to hide those entries due to a check that was unnecessary. This patch removes that check and allows these entries to be hidden.


Bug 1920: Blanket: hardcoded header and footer border color(s)
Category: Style System
Patch by: ninetydegrees
Description: This patch allows users of the Blanket style (and any of its themes) to set the colour of the hrader and footer border.


Bug 1919: Theme: The Teal and the Grey (Blanket)
Category: Style System
Patch by: twtd, ninetydegrees, piranha
Description: A new theme for the Blanket layout! twtd made the theme, ninetydegrees converted it, and piranha made the preview thumbnail.


Bug 1913: Theme: Nevermore (Funky Circles)
Category: Style System
Patch by: wizard101, wyntarvox, piranha
Description: Another theme, this time for Funky Circles. wizard101 made the theme, wyntarvox made it into a patch, and piranha again made the preview thumbnail.


And now, back to me for the second half:



Bug 1905: Theme: Idolatry (Drifting)
Category: Style System
Patch by: wyntarvox, theme by zvi, preview by piranha
Description: This is a burgundy-and-tan theme for the Drifting style, created by zvi.


Bug 1892: Filter Reading Page returns error
Category: Misc UI/Frontend
Patch by: kareila
Description: The page at http://www.dreamwidth.org/manage/circle/filter was returning an error; this patch fixes it.


Bug 1890: Modify the entry interaction links text
Category: Style System
Patch by: ninetydegrees
Description: In some styles, the entry management text (previous entry, next entry, add to memories, track/untrack this, etc) were too long for a single line, so we changed the long forms around a bit, and added an optional "short text" that people can use in their layouts if they'd like (and so designers have a little more wiggle room).


Bug 1887: Bases color properties adjustment
Category: Style System
Patch by: ninetydegrees
Description: This patch fixes up the header background color in the Bases layout, as well as fixing the header for the Strawberry Sundae theme to being the color the designer intended.


Bug 1881: Manage Comments page: toolbar in Latest Posted
Category: Misc UI/Frontend
Patch by: yvi
Description: From dw_suggestions, this patch repeats the Manage Comments toolbar above the Latest Posted section, as well as above the Latest Received section.


Bug 1878: Option to add account to subscription filter when subscribing
Category: Misc UI/Frontend
Patch by: yvi
Description: From dw_suggestions, this adds the ability to add the new subscription to your reading filters at the time of subscribing to an account.


Bug 1853: Control strip needs more wrapping
Category: Style System
Patch by: denise
Description: From dw_suggestions, this patch eliminates the no-wrap definition from the control strip in most places, so that users with smaller screens don't have to scroll when viewing a journal.


Bug 1849: Changes to "Request for invite codes has been granted" email
Category: Invite codes
Patch by: denise
Description: From dw_suggestions, this patch changes the email sent out when someone requests more invite codes and that request is granted, so that the codes themselves are listed in the email (as well as the email following our usual rules for signoff).


Bug 1827: Theme: Strawberry Sundae (Bases)
Category: Style System
Patch by: wyntarvox, theme by sky, preview by piranha
Description: A pink-themed version of the Bases layout.


Bug 1526: Fix corner.gif
Category: Misc UI/Frontend
Patch by: janinedog, art by nova
Description: Replaces one of the background "filler" images (used in the Customize area) with a version colored for Dreamwidth.


Bug 813: warn if you are about to send a PM with no text
Category: Misc UI/Frontend
Patch by: meowth
Description: This patch changes it so that if you're trying to send a blank PM (for instance, if you accidentally hit enter at a point where your browser interprets that as 'send this form'), the system will ask you if you really want to do that. (If you do really want to do that, you still can.)

Comments

[nozdormu]

Awesome guys!

[afuna]

Oh! I just realized that Mark's changes aren't reflected in the code tour, since he bypasses zilla.