Code tour: 10/6 to 10/12

[foxfirefey]

Here is this week's code tour! We closed a total of 21 bugs. Thank you to our submitters this week (in no particular order): yvi, kareila, ninetydegrees, zvi, wyntarvox, piranha, twtd, cesy, branchandroot, sforzinda, yati, denise, gchick, and afuna. Most of these patches aren't live yet; you can keep track of which patches are live on the code status page.

Bug 312: openID security on posts screening anonymous comments
Category: Misc UI/Frontend
Patch by: yvi
Description: This makes it so that OpenID users who aren't screened when commenting don't get a false warning about that.

Bug 1670: create function for creating s2 entry objects
Category: Misc Backend
Patch by: yvi
Description: This is code clean up, to make the code in the S2 style system neater and more reusable.

Bug 1869: Add subscription filters to the navbar drop-down on reading pages
Category: Misc UI/Frontend
Patch by: yvi
Description: We wanted to have subscription filters in the nav strip's drop-down! This patch is live.

Bug 1940: sticky entry not showing up for older entries
Category: Style System
Patch by: yvi
Description: This fixes a bug where older sticky entries would load their tags but not the subject or entry.

Bug 355: tags miscounted on filtered posts
Category: Misc UI/Frontend
Patch by: kareila
Description: If a post is made to multiple access filters, the tags on it were counted once per filter used instead of once per post. This bug fix fixes that--and there's discussion about how to update the site to have the correct counts.

Bug 1720: duplicated viewall code in cgi-bin/LJ/S2/*.pm
Category: Misc Backend
Patch by: kareila
Description: This is more code clean up! We don't want to have code that does the same thing duplicated in two places.

Bug 1415: make transmogrified margins customizable through the wizard
Category: Style System
Patch by: ninetydegrees
Description: Because some of our changes have affected margins in Transmogrified, we decided to put these values into the wizard so that people can more easily change them to their preferences.

Bug 1823: Theme: Verdigris (Modish)
Category: Style System
Patch by: zvi, wyntarvox and piranha
Description: This theme for Modish by zvi was made into a patch by wyntarvox that goes into dw-free! piranha made the image preview.

Bug 1900: Theme: Light on Dark (Drifting)
Category: Style System
Patch by: cesy, wyntarvox, and piranha
Description: This Light on Dark theme (part of our effort to make light on dark themes for all layouts) was by cesy, patched by wyntarvox and with a screenshot by piranha.

Bug 1901: Theme: Sun and Sand (Bases)
Category: Style System
Patch by: twtd, wyntarvox, and piranha
Description: This theme for Bases was by twtd, with the patch made by wyntarvox and the screenshot by piranha

Bug 1917: Layout: Crossroads (16 themes)
Category: Style System
Patch by: branchandroot, wyntarvox, and piranha
Description: branchandroot made a new layout with 16 themes! Patch by wyntaxvox and screenshots by piranha.

Bug 1937: Move official-theme additional CSS from Page::print_custom_head
Category: Style System
Patch by: wyntarvox
Description: This makes it so that users can use Page::print_custom_head without needing to worry about losing customizations--the official-theme additional CSS is now in Page::print_default_stylesheet.

Bug 1924: New layout: Brittle
Category: Style System
Patch by: sforzinda, yati, and piranha
Description: sforzinda made this style, and yati did the conversion to a patch (yati's very first!) with piranha making the screenshots.

Bug 1685: Preview suggestions
Category: Frontend
Patch by: yvi
Description: Fulfills some suggestions for dw_suggestions--now you can preview suggestions before posting them, with spell check!

Bug 1931: handling uppercase/lowercase content filters
Category: Misc UI/Frontend
Patch by: yvi
Description: This makes content filter names retain case, but case insensitive when comparing.

Bug 1889: return more informative error when username is not possible
Category: Registration
Patch by: denise
Description: This changes the error message to make it clearer why username is invalid, including information about what a valid username looks like.

Bug 1912: When using the Manage Account page as a community, the userhead is the LJ community userhead
Category: Misc UI/Frontend
Patch by: denise
Description: Whoops! Make sure that we use the DW community userhead and not the LJ one on the Manage Account page.

Bug 1866: On priv page, link back to admin page
Category: Site Administration
Patch by: gchick
Description: This only adds a link back to the main admin page from the priv page.

Bug 934: Transmogrified tags page doesn't have a content background
Category: Style System
Patch by: ninetydegrees
Description: This makes sure the background color on the Tags page can be set from the wizard for Transmogrified.

Bug 1911: Themes: Light on Dark/Olive/Shallows (Tranquility III)
Category: Style System
Patch by: cesy, ninetydegrees, and piranha
Description: This theme for Tranquility III is by cesy. ninetydegrees made the patch and piranha made the screenshots.

Bug 1916: Transmogrified: Subtle Almond: Tags Page: Title is invisible
Category: Style System
Patch by: ninetydegrees
Description: This fixes the title on the tags page for this theme, so it's visible.

Bug 1923: Transmogrified: Black Eye: links in footer are not visible
Category: Style System
Patch by: ninetydegrees
Description: Looks like this theme for Transmogrified had a problem where the links in the footer weren't visible--this fixes that according to the author's suggestion.

Bug 1925: Blanket: Sprung: day names are not visible on Calendar page
Category: Style System
Patch by: ninetydegrees
Description: This makes sure that day names will be visible on the calendar page for Blanket themes.

Bug 1926: Tranquility III: Hover & active link colors don't work in sidebar
Category: Style System
Patch by: ninetydegrees
Description: This make module module hover/active link colors work in Tranquility III.

Bug 1932: Theme: Light On Dark (Negatives)
Category: Style System
Patch by: ninetydegrees
Description: Another part of our push to make light on dark themes for all layouts. This theme is by cesy, ninetydegrees did the patch, and piranha did the screenshot.

Bug 1933: Theme: Light on Dark (Sunday Morning)
Category: Style System
Patch by: ninetydegrees
Description: Another part of our push to make light on dark themes for all layouts. This theme is by cesy, ninetydegrees did the patch, and piranha did the screenshot.

Bug 1934: Switch around featured layouts
Category: Style System
Patch by: afuna
Description: This makes it so we have exactly 12 featured layouts, with as much variety as possible.

Bug 1936: Second Teal (Modish) background image broken
Category: Style System
Patch by: wyntarvox
Description: Fixes the background image for a Modish theme.

If you want to do a code tour next week, see this guide!

Comments

[afuna]

*dances happily*

[yvi]

1869 is actually already live - I think it was the last one I sneaked in, though :)

And it looks like I was busy, huh?

Also, pretty styles! Code cleanup!

[foxfirefey]

Fixed!

And yes, yes you were.

[cesy]

Shiny fixes!

[wyntarvox]

the official-theme additional CSS is now in Page::print_default_stylesheet.

It will actually probably move to Page::print_theme_stylesheet() soon, but for now Page::print_default_stylesheets is correct.

Yay, code tour!