Code Tour: 9/28 - 10/05

[zarhooie]

Welcome to the Dreamwidth Code Tour for the week of 9/28-10/05. I am your host, Kat, coming to you from my living room (under a down blanket!) because it's a balmy 45F and rainy here in the midwest. Thankfully, the Dreamwidth coders are hot hot hot this week, with 23 patches being marked "Resolved Fixed"! Please remember that these patches aren't live on the site yet; you can keep track of their statuses at the code status page.

Thanks to everyone who wrote patches this week: yvi, exor674, kareila, mark, ninetydegrees, foxfirefey, denise and wyntarvox, with a special shout-out to piranha for the Style preview images!

A huuuuuge thank you to everyone who submitted style themes this week: zvi, sky, cesy, ambrya and dancing_serpent!



Bug 1573: Add text messaging setup to Manage Settings
Category: Misc UI/Frontend
Patch by: kareila
Description: This patch adds settings for the text messaging via profile feature to the Manage Settings page for paid users.

Bug 1610: birthday sort order needs fixing
Category: Misc Backend
Patch by: kareila/mark
Description: This patch was a team effort to get the birthday list sorted correctly. WHOO TEAM EFFORTS!!!

Bug 1652: "Invalid journal" error when you have a < form > inside the entry
Category: Tags
Patch by: afuna
Description: This patch resolves a problem with the < form > tag.

Bug 1771: Use different userpics for the t/userpics.t test
Category: Misc Backend
Patch by: denise
Description: This set of patches was written to replace the current icon upload test icons with ones that are very clearly and very obviously marked as test icons. They look like this:


Bug 1784: auth=digest qop="auth" not required (but is being enforced)
Category: APIs (RPC, XML, Flat)
Patch by: exor674
Description: This patch makes Dreamwidth follow the Digest protocol better and allows tools like wget to properly use auth=digest.

Bug 1806: Adding duplicate subscription filter fails silently
Category: Misc UI/Frontend
Patch by: yvi
Description: This patch prevents a user from creating two filters with the same name. It will automatically load the existing filter for editing. This fix is elegant and well-thought out.

Bug 1807: Can't remove users from subscription filters
Category: Misc UI/Frontend
Patch by: yvi
Description: This patch fixes a bug with subscription filters that wouldn't let you remove anyone from a filter.

Bug 1816: bin/renameuser.pl busted
Category: Site Administration
Patch by: kareila
Description: This makes the error message more informative if there's a problem connecting to the database when you run a script.

Bug 1819: Theme: Chocolate Cherry (Drifting)
Category: Style System
Patch by: Theme by zvi, patch by wyntarvox, scheme preview image by piranha
Description: This patch is for a new color scheme for the style Drifting.

Bug 1825: Theme: Ocean (Transmogrified)
Category: Style System
Patch by: Theme by dancing_serpent, patch by wyntarvox, scheme preview image by piranha
Description: This patch is for a new color scheme for the style Transmogrified.

Bug 1826: Theme: Wintergreen (Tranquility III)
Category: Style System
Patch by: Theme by dancing_serpent, patch by wyntarvox, scheme preview image by piranha
Description: This patch is for a new color scheme for the style Tranquility III.

Bug 1827: Theme: Strawberry Sundae (Bases)
Category: Style System
Patch by: Theme by sky, patch by wyntarvox, scheme preview image by piranha
Description: This patch is for a new color scheme for the style Bases.

Bug 1829: Theme: Light On Dark (ColorSide)
Category: Style System
Patch by: Theme by cesy, patch by wyntarvox, scheme preview image by piranha
Description: This patch is for a new color scheme for the style ColorSide.

Bug 1885: no background color on the Tags Page of Negatives
Category: Style System
Patch by: ninetydegrees
Description: This patch gives a color property to the background of the Tags page. This solution was particularly elegant, as it made the tags page look like the calendar module boxes. Stylish!

Bug 1893: Themes: seven color themes (Funky Circles)
Category: Style System
Patches by: Themes and patches by ninetydegrees, scheme preview images by piranha
Description: This set of patches is for seven new color schemes for the style Funky Circles. WHOA.

Bug 1897: checkconfig checks for Net::OpenID::Server twice, never Net::OpenID::Consumer
Category: Site Administration
Patch by: foxfirefey
Description: This is for people running our code. The script was checking for the same module twice, instead of the proper two. This patch fixes that.

Bug 1908: Theme: Black Eye (Transmogrified)
Category: Style System
Patch by: Theme by dancing_serpent, patch by ninetydegrees, scheme preview image by piranha
Description: This patch is for a new color scheme for the style Transmogrified.

Bug 1909: Theme: Clear Green (Stepping Stones)
Category: Style System
Patch by: Theme by ambrya, patch by ninetydegrees, scheme preview image by piranha
Description: This patch is for a new color scheme for the style Stepping Stones.

Bug 1910: Theme: Red Contrast (Sunday Morning)
Category: Style System
Patch by: Theme by ambrya, patch by ninetydegrees, scheme preview image by piranha
Description: This patch is for a new color scheme for the style Sunday Morning.

Bug 1914: Celerity has stray red link on /customize/ page
Category: Misc UI/Frontend
Patch by: wyntarvox
Description: This fix gets rid of a stray red link in the site scheme Celerity.

Bug 1915: Importer xpost map doesn't canonicalize username
Category: Importer
Patch by: exor674
Description: This patch fixes duplication problems that arise with imports by users with underscores in their names.

Bug 1922: Create S2 function to parse image properties
Category: Style System
Patch by: wyntarvox
Description: Saves having to use the same piece of code every time to check whether an image is a custom image hosted elsewhere, or if it's a relative path and therefore should have the static directory path appended.

Bug 1926: Tranquility III: Hover & active link colors don't work in sidebar
Category: Style System
Patch by: ninetydegrees
Description: This patch makes the module hover/active link colors work in Tranquility III.

That's it for this week's tour, so be sure to tune in next week for another thrilling installment of Dreamwidth Code Tour Theater! If you want to do the code tour next week, you should check out foxfirefey's fabulous walk-through here.

Happy Monday, Dreamers. :)

-Kat

Comments

[afuna]

Yaaay code tour! \o/

[zarhooie]

omg I did it and didn't majorly screw anything up! WHOOOOO.

[cesy]

Typo in 1816 ;)

I have so much love for 1807.

[zarhooie]

What typo? I'm sure I've got no idea what you're talking about <_<

[cesy]

:)

[yvi]

:)

*lives to serve*

[turlough]

Yay! for 1807! When that's gone through I can start fiddling with my filters again :-)

[zarhooie]

The workaround is to create new filters and hand-populate them. It's hack-y but it works.

[turlough]

Yeah, but then I end up adding a couple of wrong comms or journals to THAT filter, etc, etc :-) I hate that interface so much, it's absolutely hopeless to work with! I've been trying to come up with something better, but I think it needs some kind of serious studies to find out which model would work best.