Code tour: 9/14 to 9/21

[yvi]

Dear dwenizens, it is Monday and therefore it is my pleasure to welcome you to another round of "We are awesome, we fix things". Also known as the code tour.

This one is proudly presented by me, with special thanks to foxfirefey for the shiny Python script. Also thanks to this week's contributors: pauamma, superluminal, denise, cesy, kareila, yvi, wyntarvox, afuna, mark, ninetydegrees, and exor674.

None of these are live yet. I still reserve the right to switch between past, present and future :)

Bug 1300: Manage Filters page dies with more than thirty access groups
Category: Misc UI/Frontend
Patch by: pauamma
Description: One of the nice things about shifting from 32 bit to 64 bit is that DW supports more access filters. And now it doesn't even die anymore when you actually try to use those.

Bug 1305: allow crossposting from clients
Category: Crossposter
Patch by: superluminal
Description: Allow crossposting from clients. I think it does what it says on the tin :)

Bug 1469: Bugfix for QotD without dates
Category: Misc Backend
Patch by: denise
Description: Oh, this week's tour is hard. I had to ask denise what QotD actually is and it seems to be the "Question of the Day" module. Which we don't yet have. Anyway, when we have it, the dates will be okay.

Bug 1700: Add link to advanced layer area from layer editor
Category: Style System
Patch by: cesy
Description: We now have a link back to the advanced layer area from the layer editor.

Bug 1705: Colorside Nadeshiko has misaligned userpics
Category: Style System
Patch by: kareila
Description: The userpic in Colorside was overlapping with parts of the entry content. That's now fixed.

Bug 1738: Basic Boxes/ColorSlide: inconsistent alignment of Module headers
Category: Style System
Patch by: yvi
Description: Some of the module headers were right-aligned and some center-aligned in ColorSlide and Basic Boxes. They are now all center-aligned.

Bug 1739: Negatives: too much space between page links
Category: Style System
Patch by: yvi
Description: With the addition of the network page, the Negatives page links on top were wrapping into two lines even on a rather big screen. This reduced the space between the links.

Bug 1753: "Mark All Read" and "Delete All" buttons at the top of the Inbox
Category: Inbox/Notifications
Patch by: wyntarvox
Description: Because sometimes messages get long, it took a lot of scrolling to get to the "Mark All Read" and "Delete All" buttons in the inbox. We now have a set on the top as well.

Bug 1764: Transmogrified shifts aside the entry title bar even when there is no userpic
Category: Style System
Patch by: afuna
Description: With the userpic set to be shown on the right, the entry title bar was shifted even when the entry had no userpic. This shouldn't happen anymore.

Bug 1765: Code cleanup in manage/settings/index.bml.text
Category: Misc Backend
Patch by: kareila
Description: We are still doing quite a bit of code-cleanup. This patch removed an unused translation string.

Bug 1773: multiple layouts hardcode time font color
Category: Style System
Patch by: kareila
Description: The color of the time and entry or comment was posted was hardcoded in several layouts. It is now under user control.

Bug 1774: "Open Source" is missing from site footer in Celerity
Category: Misc UI/Frontend
Patch by: denise
Description: The Celerity sitescheme was missing the link to http://www.dreamwidth.org/site/opensource

Bug 1785: extra link on RSS/Atom feed URLs on Manage Settings page
Category: Misc UI/Frontend
Patch by: yvi
Description: http://www.dreamwidth.org/manage/settings/?cat=privacy has links to the Atom and RSS feeds of your journal. Unfortunately, they had an extra http:// at the beginning, which I removed. (yay for seven character patches? well, fourteen)

Bug 1790: Improve comment reply postform for Funky Circles
Category: Style System
Patch by: afuna
Description: A color tweak for the reply form in our new Funky Circles layout.

Bug 1791: sort users alphabetically on Manage Subscription Filters page
Category: Misc UI/Frontend
Patch by: mark
Description: I was having a bit of a difficult time making my dw_ reading filterbecause the account names weren't sorted alphabetically. And now it is implemented :)

Bug 1793: Tweaks to multiform and qrdiv appearance in Funky Circles
Category: Style System
Patch by: ninetydegrees
Description: A few more tweaks for Funky Circles.

Bug 1794: Network page in Funky Circles lacks padding and some formatting
Category: Style System
Patch by: afuna
Description: And one more time :) The network page of Funky Circles is now formatted the same as the reading page.

Bug 1796: Missing translation string on htdocs/changepassword.bml
Category: Misc UI/Frontend
Patch by: wyntarvox
Description: We don't like having even the tiniest bit of English hardcoded into the source code. So the "Success" message had to move.

Bug 1797: Make it clearer which theme "Apply Theme" button refers to
Category: Style System
Patch by: denise
Description: According to a user report (and our own experience) it was a bit difficult to see whether the "Apply Theme" button belongs to the theme above or below the button. That should be clearer when this is live.

Bug 1800: Userpic can overlap entry poster name in Sunday Morning
Category: Style System
Patch by: afuna
Description: Some more icons overlapping content issues fixed, this time in Sunday Morning.

Bug 1804: 'Reply to' in inbox escapes special characters
Category: Misc UI/Frontend
Patch by: exor674
Description: When you replied to a message with special characters, they showed up escaped. This was unnecessary and has been fixed.

Bug 1808: Basic Boxes Eggplant improperly credit on /customize/
Category: Style System
Patch by: kareila
Description: Correct user credited.

Bug 1815: Read page by date accidentally broken.
Category: Misc Backend
Patch by: exor674
Description: Ouups. There was a typo which prevented the reading page by date's function to work.

Bug 1820: a:hover doesn't apply to already visited links
Category: Style System
Patch by: yvi
Description: When I implemented the a:hover, a:visited and a:active links in Transmogrified and Negatives I didn't know order mattered. That is now fixed.

Bug 1830: put style=light in navstrip on recent entries/read/network/calendar/...
Category: Misc UI/Frontend
Patch by: yvi
Description: style=light is now available on all pages that show the navstrip, so we could stop special-casing it in the code and just always show the link to reload the page in this style on the navigation strip.

And that was it! I hope there were some fixes you like in there :)

Comments

[cesy]

Aww, and poor szabgab still doesn't get a mention, because it's all in one giant bug.

Are we going to get QotD eventually, then? What does it actually do? It's not in the LJ FAQs, either.

1700 is going to make Styles stuff easier, I hope, as previously there wasn't any way to get from that page back to a site-schemed page.

1705 and 1738 have been annoying me for a while, so yay.

1753 is one of the ones that's come from LJ Suggestions, to our wiki, to DW Suggestions, migrated to Bugzilla, and now fixed. So that's very cool. I may have to go and mention it on the original LJ Suggestion.

1791 is sooo useful.

I am quite impressed with how many of these were bugs I reported :)

Also, that's quite a lot of bugs.

[janinedog]

QotD stands for "Question of the Day". It's implemented as "Writer's Block" on LJ...you can see it on the LJ homepage at the top.

[baggyeyes]

What gets me is, how happy everybody is 'round here at finding bugs, reporting them, dealing with them. I looked in at the KDE people (Linux Desktop environment), and they were all bored with their bugs, and regarded them as a necessary evil to get out of the way.

People here are, "YAY, BUGS!"

Dreamwidth: Happy as a snug bug in a rug.

[cesy]

I suspect that a part of it is because planned features go in the same bugtracker, and there's no distinction, apart from in keywords. So "bug" in DW means "bug or upcoming enhancement", whereas in a lot of places, it just means "bug", so is less shiny.

Also, it's influenced by the number of people who've come from LJ, where bugs getting fixed happens very rarely from the user's point of view. So bugs actually getting fixed is "Wow, yay" rather than "That should have been done years ago", because we've already had all the "That should have been done years ago" and come out the other side resigned. 'Course, LJ does stuff behind the scenes, and there have been recent signs of improvement, but from the point of view of a lot of users, there are some bugs that have been untouched for years, that are now getting fixed on DW.

[turlough]

This is definitely the case for me. It's wonderful to see things GETTING DONE and not just disappearing into a black hole somewhere.

[baggyeyes]

Course, LJ does stuff behind the scenes, and there have been recent signs of improvement, but from the point of view of a lot of users, there are some bugs that have been untouched for years, that are now getting fixed on DW.

This is true.

I know there was an enormous amount of work done just bringing the code out of the 1990's.

[baggyeyes]

It could also be because people are happy to be contributing something useful to a project they love, no matter how small the contribution.

(sorry - shaky hands)

[foxfirefey]

Yay, I am glad my script is useful!

[brownbetty]

Omigosh, crossposting from clients! THIS IS THE BEST BIRTHDAY PRESENT EVER.

[turlough]

I love 1700! The lack of a link back has irritated me for years on LJ.

[cesy]

It's good to know it'll be used :)

[baggyeyes]

\o/ BUG 1700! Alright!