Supplemental Code Tour: 7 Jun - 11 Jun

[denise]

All of these fixes and features are live!



Bug 3483: Pretty URLs
Category: Journal contents
Suggested by: damned_colonial
Patch by: mark
Description: WOO-HOO. This patch allows you to specify a 'slug', or short phrase that will be used in the entry's URL. You can read more in How do I add a slug to change the URL of my entry?. (Note: this only works with the new beta update page.)

Bug 5088: Icon browser in comments - change class of icon comment div
Category: Icons
Patch by: lucymclaughlin
Description: Fixes a problem where some CSS wasn't being narrowly-enough targeted, causing the icon browser to appear improperly.

Bug 4927: Add "more options" button to the comment preview page
Category: Misc UI/Frontend
Patch by: lucymclaughlin
Description: Super usability win! This adds a "more options" section to the comment preview page, so if you preview a comment and realize you've forgotten to change a setting, you can change it right then and there instead of having to backbutton out.

Bug 5023: Text on tag settngs is confusing
Category: Doc Tools
Patch by: lucymclaughlin
Description: Another usability win; this one makes the labels on the "who can add/remove/edit tags in this journal" part of the Manage Tags page more understandable.

Bug 5093: SVG expand collapse arrow fallback doesn't work on Firefox 3.6
Category: Browser Issues
Patch by: deborah
Description: This code push replaced the cut tag arrow, which was a simple .png image, with a vector graphics version that can be resized on-the-fly by your browser -- this helps to make it more accessible for people who browse with larger font sizes set. We discovered after the code push that Firefox 3.6 is a lying liar that lies: it claims it supports vector images, but it doesn't support them inline. So, we fall back to the old PNG version.

Bug 4571: Bannering: icon overlaps entry text in smaller font size
Category: Style System
Patch by: momijizukamori
Description: Display fix for the Bannering layout, which was having some overlap issues.

Bug 4996: FAQ #108: add 'feed has a new source'
Category: User documentation
Patch by: misskat
Description: Edit The feed I'm following isn't updating. Why? to clarify what to do if a feed you're reading has changed its location. (Answer: open a support request.)

Bug 1716: fuzzier feed matching
Category: Feeds
Patch by: exor674
Description: And speaking of feeds: there are often a number of subtly different ways you can access the same feed, such as the difference between "feed.feedburner.net" in the URL and "feed2.feedburner.net". They're all the same feeds, just using a different URL. The system does try to weed out those duplicates, but it wasn't very smart about it. exor674 has done an incredible amount of work to make the parser smarter, so we can weed out those duplicates.

Bug 3448: Make youtube video URLs visible to non-flash users
Category: Journal contents
Suggested by: emperor
Patch by: deborah
Description: So, when you embed a YouTube video, it consists of a little Flash widget that will play the video for you. Not everybody uses Flash, though, so deborah made it so that when you post a video, the site goes out and fetches the URL of the video itself and puts it in the post outside the Flash widget. It's a lot more complex than it looks.

Bug 5096: gradation schemes: entry title invisibly "on top" of tags, rendering them unclickable
Category: Browser Issues
Patch by: momijizukamori
Description: Another display bugfix, this time with Gradation Horizontal/Gradation Vertical interacting weirdly with the new entry/comment pages.

Bug 5100: Abstractia/Cocoa: incorrect preview pic
Category: Style System
Patch by: momijizukamori
Description: Oops. When we added this theme, we accidentally used the wrong preview pic for it. Fixed now!

Bug 5101: Librarian's Dream: incorrect preview pic for some themes
Category: Style System
Patch by: momijizukamori
Description: Oops again! This fixes some more incorrect preview pics.

Bug 5038: Contextual popup has unreadable font color in some site skins and styles
Category: Misc UI/Frontend
Patch by: ninetyd
Description: Last time around, we made some changes so that the hover menu would be less likely to appear in inaccessible colors. Turns out we were using the wrong set of user-defined colors for it, so this fixes it up a bit more.

Bug 5089: SVG cuttag arrows need a border
Category: Journal contents
Patch by: momijizukamori
Description: When we replaced the cut-tag arrow with the vector graphics version, we forgot to outline it, so the (black) arrow on a dark background would disappear. Fortunately, momijizukamori was able to edit the vector version of the graphic pretty quickly and replace it.

Bug 5094: S2 pages don't show 'view thread from start' in flat view
Category: Style System
Patch by: momijizukamori
Description: No matter how long you beat on something in beta, there's always that one last bug. In this case, the new entry/comment pages were missing the "thread from start" link on comments when they were viewed in flat view instead of nested/threaded view. Fortunately, it was a much quicker fix than we were fearing.

Bug 5097: Patsy themes: wrong credit on new ones
Category: Style System
Patch by: ninetyd
Description: A few of the new themes for the Patsy layout were credited to the wrong theme designer.

Bug 5111: document pretty urls
Category: User documentation
Patch by: denise
Description: I wrote a faq!

Bug 5013: Icons sometimes changing keywords to pic#
Category: Icons
Patch by: allen
Description: THIS BUG HAS BEEN DRIVING US NUTS FOR AGES AND allen FINALLY FIGURED IT OUT. If your account expired, you had icons inactivated, you opened up your Edit Icons page with those inactive icons displayed on it, opened up another tab and renewed your account, then came back to the Edit Icons tab you'd previously opened, then hit "save" on that stale tab, your keywords would get eaten and replaced with the system-generated "pic###" version. And now they won't do that anymore, and we love allen more than we already did.

Comments

[onyxlynx]

Oh, that's why I was finally able to change that pic#zzzzzzz to the proper keyword (I wasn't expired or inactive when I downloaded that icon, but it refused to be renamed until yesterday).

Thanks.

[denise]

Partially! When we initially made the userpic renaming function, it didn't allow you to rename the system-generated "pic###" keywords, because those were a special case. randomling managed to make it work this week, though. (That part of it was in one of the previous code tours!)

[momijizukamori]

I'm still facepalming at letting those preview pic mistakes go live. I CHECK THESE THINGS HOW DID I LET THAT HAPPEN.

(The answer probably involves times I shouldn't be awake and/or sleep meds)

[denise]

Mistakes happen to everybody sometimes!

[momijizukamori]

Or a lot to me, because I am super absentminded XD

[ninetydegrees]

Oh look at that URL! ^_^

[denise]

ISN'T IT PRETTY

LOOK AT MY PRETTY URL

[kate_nepveu]

Bug 3448: Make youtube video URLs visible to non-flash users

That is _so_ cool.

[denise]

Even better having heard deborah cursing at it for like two days straight :)

[justhuman]

Yay, slugs!

But I did see something inconsistent things with the pretty URLs.

I edited an entry with a 'cut'. I added the slug.
http://justhuman.dreamwidth.org/2013/06/09/in_the_dark.html

The pretty URL does indeed work when I type it in the browser and it works when I hit 'reply'.

However, it comes up with the system URL when
"View this entry" link after edit
or
Click the cut text

The original URL is also used in the footer of the crossposted entry.

Okay, crossposting had some unique behaviors. It looks like when I edited, the system assigned a new URL to the entry. I noticed afterwards that the "crosspost to LJ" had become unchecked. When I clicked it and saved again, DW crossposted a second version of the entry to LJ.

(Entries are on June 9 - http://justhuman.livejournal.com/)

Older entry has the original URL in the footer.
Newer entry has the new system URL in the footer.
Clicking on either leads to the entry on DW with the new System URL, not the slug

Not sure if this is expected behavior or not

[denise]

For the crossposting thing, can you open a support request so we can open a bug for that?

The post-edit screen using the old URL we already know about and have a bug open for -- turned out that a few places aren't using the "correct" method of generating URLs, and instead build them up the old hacky way.

[justhuman]

opened!

[denise]

ty!