Code Tour: 02/02/17 - 02/12/17

[momijizukamori]

11 items on this second half of the code tour, all by karzilla, Wielder of the Code Machete.


Issue 1947: remove unused module SixDegrees.pm (pull request)
Category: Code Machete
Patch by: kareila
Description: Our code base is old enough to vote, and, like many teenagers, has old weird junk laying around that might have been useful once, but now is just taking up space. This was one of those things.

Issue 1948: problems with HTML cleaner's insertion of "wbr" tags (pull request)
Category: HTML support, Dark Magic
Patch by: kareila
Description: <wbr> is a rarely-used HTML tag to provide hinting to the browser about where to break a word when it's too long to fit on a single line. The HTML cleaner, which runs on dark, arcane magic, did not handle this very well, and we decided fifteen years was more than long enough to have not done anything about it.

Issue 1951: fix variable reuse warning in DW::Pay (pull request)
Category: Code Machete
Patch by: kareila
Description: Perl doesn't like it when you use the same name to mean two different things in the same code. This fixes an instance of that in part of the payment code (in this case, by giving the second thing a different name)

Issue 1955: Cleanup 2017q1 (pull request)
Category: Code Machete
Patch by: kareila
Description: To quote mark, 'The code machete cleaneth :)' (Cleans up some warnings and errors from the log, as well as tidying up the whitespace in some tiles.)

Issue 1958: return suffix-neutral URIs from BML::get_uri (pull request)
Category: Code Machete
Patch by: kareila
Description: We use a couple different templating systems of varying vintages to generate the site pages you see, and you're not supposed to see which one of them generates which, because it doesn't matter to the end user - but BML::get_uri was bad and in some cases slapped it's suffix on there. This fixes things so URIs are all consistent.

Issue 1959: add compile checking of command line scripts (pull request)
Category: Testing
Patch by: kareila
Description: Our testing code had logic to make sure all our fancy packaged modules compiled properly, but we have a whole directory of command-line utility scripts that weren't being checked. This adds a check for those files to the testing system.

Issue 1962: Migrate userpicblob2 icons (pull request)
Category: OMG FILES
Patch by: kareila
Description: Right now, userpics are stored in one of our database tables, which isn't necessarily the most efficient or flexible way of doing things. kareila wrote a script to move them from there to mark's new BlobStore system, which gives us more choices of where and how to store themm.

Issue 1963: remove bin/ljubackup.pl (pull request)
Category: Code Machete
Patch by: kareila
Description: More old cruft! bin/ljubackup.pl was a script that repeatedly ran a different script (which no longer exists) and copied the results into MogileFS (which we are getting rid of). Time to toss it!

Issue 1964: Blobstore-related cleanup (pull request)
Category: Code Machete, OMG FILES
Patch by: kareila
Description: Assorted bits and pieces of clean-up related to the new BlobStore system.

Issue 1967: allow etc/log4perl.conf to be superceded by ext/local (pull request)
Category: OMG FILES
Patch by: kareila
Description: Generally, it helps for specific configuration files to be able to override the default configuration settings. This adds this for Log4Perl, which is part of the new BlobStore system.

Issue 1968: whitelist iframe embeds from scratch.mit.edu (pull request)
Category: Embedding
Patch by: kareila
Description: Another site added to the whitelist! This one is an educational learn-to-code game, which is pretty cool.

Comments

[azurelunatic]

Wheeeeeeeeeee!

[momijizukamori]

Double the code tour, double the fun! Or something.

[momijizukamori]

Double the code tour, double the fun! Or something.

[niqaeli]

*squints at 1958* this seems like a good thing! but also I am now wondering

on the day the last of BML is finally gutted from the DW codebase, replaced by things written in this century, is there going to be a party? it seems like there should be a party.

[kareila]

There sure as hell ought to be a party.

[momijizukamori]

I for one will be partying.

[brainwane]

Congrats and yay! I'm glad there's more testing coverage -- and I know someone who researches Scratch usage so it's particularly neat to me that you can now embed Scratch into DW posts.

[momijizukamori]

Oh, neat! I hadn't heard of it before doing the code tour last night, but it definitely looks like a cool project.