Code tour, 8/17-8/23

[denise]

We resolved 41 bugs this week, 34 of which were resolved FIXED and the remainder of which were duplicates, invalid, or otherwise closed without action. One was resolved with action other than a patch (in this case, a FAQ update), and one's a security issue that we decline to describe until other sites running the code can get it patched, too. Come with me as we go on a tour of this week's development ...

I believe some of these fixes are live already, but only a few.



Bug 1666: Add additional color specifications for anchor tags in Transmogrified
Category: Styles
Patch by: afuna
Description: Via dw_suggestions, this brings some more layout link colors into the customization wizard, rather than having to use custom CSS to control it.

Bug 1662: background_*_position properties don't contain the full list of acceptable values
Category: Styles
Patch by: afuna
Description: This patch adds three more background image properties into the customization wizard: center center, center left, center right.

Bug 1654: "Mean Median Std. Dev" showing up twice on polls
Category: Cleanup
Patch by: wyntarvox
Description: This fixes an error with the code that generates polls to take out an accidental doubled line.

Bug 1653: OpenID can't authenticate via comment form
Category: Bugfix
Patch by: wyntarvox
Description: This was my bug, and thank you for fixing it, Wyn! This fixes the problem OpenID accounts were having when trying to log in from the comment form.

Bug 1651: Drifting tag cloud needs space at bottom
Category: Styles
Patch by: kareila
Description: Adds a space to the bottom of the tag cloud in the Drifting layout.

Bug 1647: Drifting Blue's bottom controls section is not differentiated from the comment above.
Category: Styles
Patch by: kareila
Description: This patch adds CSS to more easily distinguish the bottom bits of the entry/comment controls in the Drifting layout.

Bug 1645: recent comments page auto vivification
Category: Bugfix
Patch by: denise
Description: A few weeks ago, when we updated the code to use more modern methods of referring to account types and account status, we uncovered a few old bugs that had been lurking in the code for a while that had been covered up by the old method of doing things. This patch fixes one of them by adding in a check to see that the user object actually exists on the Recent Comments page before trying to do something with it.

Bug 1642: Icon height created by user tags for syndicated accounts
Category: Bugfix
Patch by: rat
Description: This patch fixes the problem with generating the height in the <img> tag for the userhead on syndicated accounts when created with the <user name=foo_feed> tag.

Bug 1641: Table's right border missing on /shop/confirm in IE 7
Category: Bugfix
Patch by: wyntarvox
Description: This cleans up the HTML on the shop page so it displays properly in IE7.

Bug 1640: Style credit contents overflow column
Category: Styles
Patch by: kareila
Description: This fixes the HTML generated by the credit module in layouts so that it doesn't overflow the sidebar column.

Bug 1639: Stepping Stones layout has misaligned userpics
Category: Styles
Patch by: kareila
Description: CSS fix for the Stepping Stones layout to fix up the userpic display.

Bug 1633: add search link to suggestions generator
Category: Usability
Patch by: kareila
Description: This adds a link to search the dw_suggestions community to the Suggestions generator itself (not just the comm profile).

Bug 1631: remove editjournal_do.bml.text
Category: Cleanup
Patch by: kareila
Description: This removes some old/unused stuff from the translation system, and moves the partially-used bits into the file that makes more sense for it to be in.

Bug 1628: Removal of S1 has broken the dreamwidth.org/mobile page
Category: Bugfix
Patch by: kareila
Description: This fixes the Mobile page, which we broke last code push (oops) when we went through and removed the last remnants of S1 support.

Bug 1627: editing tags broken in communities
Category: Bugfix
Patch by: afuna
Description: Last code push, we changed the name of the tag security level (used by the backend) in order to get rid of more instances of 'friends' terminology (since that's not what we call things). When we did that, though, we forgot that we'd break things for any community that had already set their tag permissions. This patch fixes it to add in a check for the 'friends' terminology as well, for backwards compatability. (And if your community is affected, you can fix it by going and changing the tag settings to something else, then back to the members-only tagging, and it will then use the right version.)

Bug 1626: Random Paid Gifts opt-out does not save
Category: Bugfix
Patch by: afuna
Description: This fixes a problem with the setting package to opt out of getting random paid time to make it save properly.

Bug 1625: Network page errors out when user has friends who aren't in memcache
Category: Bugfix
Patch by: afuna
Description: Another hidden bug that was uncovered by changing the way in which we check account status; this fixes it.

Bug 1624: autovivification error in Userpic.pm
Category: Bugfix
Patch by: kareila
Description: Another hidden bug, fixed!

Bug 1622: Feed account entries missing journal_$account class
Category: Styles backend
Patch by: kareila
Description: Adds some more CSS classes to entries on your reading pae; this one makes sure that feed account entries are properly CSS-classed.

Bug 1618: When header image property is blank, Modish and ColorSide try to use the directory URL as a background image
Category: Styles bugfix
Patch by: afuna
Description: This patch fixes some issues with header images in two of our new layouts.

Bug 1617: /community/create missing translation strings
Category: Cleanup
Patch by: kareila
Description: This patch changes where some translation bits live in the code, moving them from one translation file to the proper one.

Bug 1613: news module on homepage should reflect current reading status
Category: Cleanup
Patch by: afuna
Description: This changes the news module on the front page so that if you're already reading dw_news, it will prompt you to modify your subscription, not subscribe.

Bug 1609: Moods not defined in Chasy's Teeny Tinies moodtheme
Category: Cleanup
Patch by: afuna
Description: This patch fixes up some mis-defined mood images (where images were assigned to the wrong mood, etc).

Bug 1604: Cannot delete account
Category: Bugfix
Patch by: exor674
Description: Yet another old/hidden bug that was uncovered by the move to the new way of referring to accounts in the code!

Bug 1559: Drifting background images do not work with changed colors
Category: Styles bugfix
Patch by: av8rmike
Description: This patch moves the Drifting header/background images into the wizard, so people who are customizing their journal can remove them if they want.

Bug 1549: Investigate LJ::Knob, remove?
Category: Cleanup
Patch by: denise
Description: Removes old and unused code.

Bug 1464: remove ".bml" on the end of links throughout site
Category: Cleanup
Patch by: denise
Description: This is more removal of .bml from the end of links on the site. (The version with the .bml on the end will continue to work, but 'canonical' reference from here on out is the page without the .bml on the end.)

Bug 1441: Icon description is lost when using Icon Factory
Category: Bugfix
Patch by: wyntarvox
Description: This fixes a bug with the icon factory (the utility that will let you resize/etc your icons if they're larger than the allowed size or dimensions on upload).

Bug 1328: "network" view should be in lang_viewname and $p.view_url
Category: Styles backend
Patch by: foxfirefey
Description: This patch adds a link to the Network (what LJ calls the "friends of friends" view) into layouts for paid users.

Bug 1184: replying from email doesn't thread properly
Category: Bugfix
Patch by: afuna
Description: Fixes a bug that was causing comments made using the emailed comment form to be posted as a top-level reply, not as a reply to the comment being replied to.

Bug 1150: Site layouts don't change link color for hovering/visited/active link
Category: Styles/accessibility
Patch by: yvi
Description: This finishes adding support for changing link colors in all the current layouts.

Bug 211: Random Account Sponsorship/Paid Account Fairy
Category: Bugfix
Patch by: janinedog
Description: The feature went live last code push, but the bug was reopened to optimize the script used to determine who's eligible for random paid time.

Comments

[gchick]

Thanks - I always love these tours!

[denise]

I love doing them! It's great to remind myself of what we did every week -- it's a bit of a tedious task to do sometimes, especially on high-volume weeks, but it's still a great reminder that we're accomplishing incredible amounts of development, even when it doesn't feel like we are.

[yvi]

Description: This fixes an error with the code that generates polls to take out an accidental doubled line.

*whistles* What do you mean, I suck at copy&paste?

So many shiny styles stuff! And so many shiny layouts to come :)

[denise]

NOBODY SAW THAT

[yvi]

AND THE ONES THAT DID WILL FORGET IT!

(note to self: caps-lock key != tab key)

[denise]

Nobody saw that, either.

[wyntarvox]

It is forgotten!