Code tour, 19th June--22nd July 2016

[kaberett]

Code tour code tour CODE TOUR aaaaaah. A buch of new themes, plus a lot of tidying!

Edit: and a belated welcome to rshatch, who I am pretty sure has their first fix featured in this code tour!

Issue 1479: Themes for Heads Up by phidari (pull request)
Category:
Patch by: rshatch
Description: 6 new themes for the Heads Up style, going live in the next code push!

Issue 1599: Clarity & consistency when joining moderated-membership communities (pull request)
Category:
Patch by: cesy
Description: Some communities have moderated membership. Joining works like this: you submit a request to join, or you get invited by a community admin. Or, in some cases, BOTH AT ONCE: if you were invited to join a community but you had no idea what it was for, and you clicked through to look at it, and then you hit "join" on the community profile or journal page, you would... submit... a join request... that would just sort of sit there alongside your unaccepted invitation. Once this patch goes live, if you request to join a community you've been invited to (at least via this route - the nav bar is to come) you accept the invitation instead!

Issue 1652: Punctuation marks in PM subjects are converted to HTML entities (pull request)
Category:
Patch by: kaberett
Description: So it's important that the site handle HTML safely and appropriately, in such a way that you don't end up running malicious scripts people have sent via comments or PMs. Part of upping site safety is "escaping" certain characters -- replacing < with &lt;, for instances, or & with &amp; (and note that both of those start with an & -- this is generally true). However, in a couple of places the escaping was overzealous -- notably, if you had a multi-PM thread with someone, where the subject line included JUST FOR EXAMPLE an apostrophe or a <3, the special character would get re-escaped every single time a reply was sent. Leading to, well, PM subjects that looked a little like "Re: &amp;amp;amp;amp;amp;amp;3". That will no longer happen as of the next code push -- the subject is now escaped only once, in the correct place -- and yea verily I look upon my works and am satisfied.

Issue 1733: fix UserMessaging.pm to use method instead of raw prop (pull request)
Category:
Patch by: hotlevel4
Description: If a user is a minor and hasn't changed their UserMessaging setting from the default, the Settings page will tell them that they can receive PMs from Registered Users, when in fact they are only allowed to receive PMs from Mutually Trusted Users. This was a small tweak to ensure that, as of the next code push, that dropdown box will actually display who can send you messages, in the default case where you've not changed the setting.

Issue 1735: eliminate specialcasing for default messaging settings for under-18 accounts (pull request)
Category:
Patch by: hotlevel4
Description: ... and at the same time, hotlevel4 updated the code so that the default setting for who can send messages to accounts owned by under-18s was the same as for all other accounts.

Issue 1815: 7 themes for Corinthian (pull request)
Category:
Patch by: rshatch
Description: 7 new themes for the style Corinthian, going live in the next code push!

Issue 1820: extra padding on /entry/new (pull request)
Category:
Patch by: kareila
Description: After the last code push, it was noticed that the some extra spacing between items had been added to the Create Entries beta (which you can opt into if you're interested!). This fixed one instance of that and was pushed immediately, so you might not even have noticed the problem; unfortunately the tag box is proving a little trickier to sort out.

Issue 1824: Remove userblob (pull request)
Category:
Patch by: zorkian
Description: Code that nobody ever used for anything. Getting rid of code nobody uses (and therefore nobody's familiar with, and nobody updates, etc etc etc) makes the codebase easier to understand and less likely to go mysteriously wrong In The Future. Tada! The code is gone.

Issue 1826: Remove reproxying (pull request)
Category:
Patch by: zorkian
Description: I... am afraid I don't SUPER understand this one so my ability to explain it clearly and concisely is, ah, limited. HOWEVER. The very short version is that this is removing some obsolete code; it was once useful code, but nowadays Dreamwidth recommends that anyone who forks the project uses a third-party provider such as Cloudflare to achieve similar (but more thorough!) functionality, so keeping it around and unmaintained is probably Misleading and Unhelpful.

Issue 1828: Cleanup for June 2016 (pull request)
Category:
Patch by: kareila
Description: Various bits of codebase cleanup! Removes some more obsolete code, and encourages Perl to make fewer unhappy squawkings about the state in which it finds itself.


Issue 1840: We have probably done dev work past 2009 that should be mentioned in the license (pull request)
Category:
Patch by: kareila
Description: Does... more or less what it says on the tin: updates the license so that it's more informative, more accurate, and all-around more useful!

11 total issues resolved
Contributors: cesy, hotlevel4, kaberett, kareila, pinterface, rshatch, zorkian