dw_dev | Code tour, 8/10-8/16

We resolved 15 bugs, all of which were resolved FIXED. (Although the numbers look like it was a slow week in development-land, many of these fixes are things I've been wanting for a really long time...)

All of these will be live on the site as of tomorrow night's code push. You may also want to review the past few weeks' code tours to see what else is going live tomorrow -- it's going to be a huge code push.

Bug 1603: Paid Account Fairy / Random Account Sponsorship should be under the Shop menu
Category: Shameless money grubbing
Patch by:

yvi
Description: This adds a link to the "sponsor a random free user" under the Shop menu.

Bug 1601: base-data.sql cleanup
Category: Cleanup
Patch by:

kareila
Description: This patch clears out some unused database tables; we removed the code that worked with those tables, but hadn't removed the tables themselves.

Bug 1557: Update direct referer checks to use check_referer instead
Category: Code cleanup
Patch by:

draigwen
Description: In a few (older) places in the code, some pages checked the referring page directly instead of using the check_referer function. This wasn't a problem until we switched to allowing pages to function both with and without the .bml extension on the end of the page. We updated the check_referer function to handle that case, but the direct referer check would fail in those circumstances, so this patch fixes it so that everything uses the function.

Bug 1540: Base layouts should use print_default_stylesheet()
Category: Styles backend
Patch by:

av8rmike
Description: This updates all of the styles to use a different way of calling the default stylesheet, so that layouts designed to serve as bases for other layouts wil use the right CSS. (I think. My understanding of S2's backend guts is ... poor.)

Bug 1396: DB name and user should be defined in config-private.pl
Category: Backend config
Patch by:

afuna
Description: This patch rearranges some configuration files so that information is in the right place. (LJ code has one config file; we broke ours down into three, and have been rearranging them since.)

Bug 1283: Font properties in the wizard
Category: Styles frontend
Patch by:

av8rmike
Description: This updates the customization wizard so people can manipulate more font properties using the customization wizard (as opposed to having to do it via CSS). Side note: this also fixed a bug in the Transmogrified style sheet that may have been causing the layout to appear 'wrong' (using the default browser font & size) in some browsers, so your layouts may look different after this code push if yours is one of the affected browsers.

Bug 1272: Imported OpenID accounts use ext_xx, instead of their address, as their name
Category: Importer
Patch by:

denise
Description: This fixes the importer-based creation of OpenID accounts so that the Name field on the profile uses the OpenID address, not the backend system ext_XXX address. It won't retroactively fix all of the accounts that have already been created, but it will fix it going forward.

Bug 1142: crossposter: no check made for validity of entered account
Category: Crossposter
Patch by:

yvi
Description: This adds a verification step to the crossposter, so that when you enter a new account for crossposting it will check to make sure the account exists and your password is correct.

Bug 1031: Tag security uses 'friends' terminology
Category: Backend cleanup
Patch by:

foxfirefey
Description: Removes instances of 'friends' in the tag security display.

Bug 992: Links on standout have poor contrast in tropo purple
Category: Display
Patch by:

yvi
Description: This fixes up a display issue in the Tropospherical Purple site scheme to enhance the contrast in standout boxes.

Bug 985: Some classes for the tags on the Tag Page
Category: Styles
Patch by:

foxfirefey
Description: This adds some more CSS classes to make styling things easier on style designers, specifically around the <li> tags based on who can view the tags.

Bug 962: manage circle page doesn't error if an invalid account is provided
Category: Bugfix/usability fix
Patch by:

carynb
Description: If you used the Manage Circle page to add people to your circle, and misspelled a username, the page wouldn't give you an error message; it would just silently drop things on the floor. This changes the page so that valid usernames are added successfully, and an error message tells you which usernames had problems.

Bug 952 crossposter: importing crossposted entries
Category: Importer/crossposter
Patch by:

exor674 &

mark
Description: This is probably one of the #1 most frequently requested things, and I'm really happy about this fix. It makes it so that if you use the Dreamwidth-based crossposter to crosspost entries to another site, then re-run the import feature to import your entries from that site, the crossposted entries won't be double-imported. (It also fixes up a few minor bugs here and there that Mark found while testing.)

Bug 926: Standardize height + width attributes for user icon display
Category: Display/accessibility
Patch by:

draigwen
Description: This patch adds full height and width attributes to userpics, so browsers will properly draw the box (if images are off) and things won't look squished up or in the wrong place.

Bug 375: Hide empty FAQ categories
Category: Admin pages
Patch by:

draigwen
Description: This page hides empty FAQ categories from the FAQ index, preventing a bug with the "view all" link.

Code tour, 8/10-8/16

no subject